Crash during system_health.common_mobile browse:media:youtube on Nexus5 Perf bot |
||||
Issue descriptionGoing to attempt bisecting crash. Link to crash is here... https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Nexus5_Perf__2_%2F5327%2F%2B%2Frecipes%2Fsteps%2Fsymbolized_breakpad_crashes%2F0%2Fstdout ...but for some reason stackwalker tool seems to be unable to usefully symbolize.
,
Mar 30 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8983677610029167536
,
Mar 30 2017
=== Auto-CCing suspected CL author yosin@chromium.org === Hi yosin@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Test failure found with culprit Suspected Commit Author : yosin Commit : 9744d5bffb3fbdf761455b355ebc4faa757d1aaf Date : Thu Mar 30 09:02:53 2017 Subject: Get rid of computeVisibleSelectionInDOMTreeDeprecated() in InputMethodController::textInputType() and textInputInfo() Bisect Details Configuration: android_nexus7_perf_bisect Benchmark : system_health.common_mobile Metric : BenchmarkDuration/BenchmarkDuration Revision Exit Code N chromium@460629 0 +- N/A 3 good chromium@460683 0 +- N/A 3 good chromium@460701 0 +- N/A 3 good chromium@460704 0 +- N/A 3 good chromium@460705 1 +- N/A 3 bad <-- chromium@460706 1 +- N/A 3 bad chromium@460710 1 +- N/A 3 bad chromium@460719 1 +- N/A 3 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse:media:youtube system_health.common_mobile Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8983677610029167536 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5344145624793088 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Mar 30 2017
=== BISECT JOB RESULTS === Test failure found with culprit Suspected Commit Author : yosin Commit : 9744d5bffb3fbdf761455b355ebc4faa757d1aaf Date : Thu Mar 30 09:02:53 2017 Subject: Get rid of computeVisibleSelectionInDOMTreeDeprecated() in InputMethodController::textInputType() and textInputInfo() Bisect Details Configuration: android_nexus5_perf_bisect Benchmark : system_health.common_mobile Metric : BenchmarkDuration/BenchmarkDuration Revision Exit Code N chromium@460685 0 +- N/A 3 good chromium@460701 0 +- N/A 3 good chromium@460704 0 +- N/A 3 good chromium@460705 1 +- N/A 3 bad <-- chromium@460706 1 +- N/A 3 bad chromium@460710 1 +- N/A 3 bad chromium@460716 1 +- N/A 3 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse:media:youtube system_health.common_mobile Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8983678108661047952 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5689139946586112 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Mar 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc19a899c0f97dcd259a3ec506396c43db14ef23 commit dc19a899c0f97dcd259a3ec506396c43db14ef23 Author: sullivan <sullivan@chromium.org> Date: Thu Mar 30 22:09:15 2017 Revert of Get rid of computeVisibleSelectionInDOMTreeDeprecated() in InputMethodController (patchset #4 id:60001 of https://codereview.chromium.org/2782413002/ ) Reason for revert: This causes a crash in a telemetry benchmark on android. To reproduce, run: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse:media:youtube system_health.common_mobile BUG= 706865 Original issue's description: > Get rid of computeVisibleSelectionInDOMTreeDeprecated() in InputMethodController::textInputType() and textInputInfo() > > This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by replacing > it with |rootEditableElementOf()| with non-canonicalize position from > |textInputInfo()| and |textInputType()| of |InputMethodController| for improving > code health. > > Node: Because of selection can't cross editing boundary, root editable element for > non-canonicalized position and canonicalized position are same. > > This patch is intentionally not change all call sites of |rootEditableElement()| > in |InputMethodController| to merge this patch as workaround of [1]. > > [1] http://crbug.com/704763 Opacity animation consuming main thread resources > > BUG=698633, 704763 > TEST=n/a; no behavior changes > > Review-Url: https://codereview.chromium.org/2782413002 > Cr-Commit-Position: refs/heads/master@{#460705} > Committed: https://chromium.googlesource.com/chromium/src/+/9744d5bffb3fbdf761455b355ebc4faa757d1aaf TBR=tkent@chromium.org,xiaochengh@chromium.org,yoichio@chromium.org,yosin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=698633, 704763 Review-Url: https://codereview.chromium.org/2785333002 Cr-Commit-Position: refs/heads/master@{#460903} [modify] https://crrev.com/dc19a899c0f97dcd259a3ec506396c43db14ef23/third_party/WebKit/Source/core/editing/InputMethodController.cpp
,
Mar 31 2017
,
Mar 31 2017
,
Mar 31 2017
Issue 706836 has been merged into this issue.
,
Mar 31 2017
Issue 706857 has been merged into this issue.
,
Apr 3 2017
The crash is caused by Doucment.cpp(1997) |CHECK(lifecycle().stateAllowsTreeMutations())| by Element::clientHeight() with dirty layout tree. We are painting dirty layout tree, or |Document::needsLayoutTreeUpdate()| returns true. My patch [1] exposes invalid state rather than causes the crash. The root cause is we are painting with dirty layout tree. [1] http://crrev.com/2782413002 Get rid of computeVisibleSelectionInDOMTreeDeprecated() in InputMethodController Full crash log: https://docs.google.com/a/google.com/document/d/1CdI_DR6OS1jd_KSEsHUIUyVX6D5UqLrxC7gXvD6CpqU/edit?usp=sharing Here is stack trace: I 10.802s Main signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr -------- I 10.802s Main [FATAL:Document.cpp(1997)] Check failed: lifecycle().stateAllowsTreeMutations(). I 10.803s Main I 10.803s Main Stack Trace: I 10.803s Main RELADDR FUNCTION FILE:LINE I 10.803s Main 000a557d ~LogMessage /usr/local/google/home/yoichio/src/chromeAndroid/src/base/logging.cc:537 I 10.803s Main 006a57f7 blink::Document::updateStyleAndLayoutTree() /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/dom/Document.cpp:1997 I 10.803s Main 006a8b5b blink::Document::updateStyleAndLayoutTreeIgnorePendingStylesheets() /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/dom/Document.cpp:2297 I 10.803s Main v------> blink::Document::updateStyleAndLayoutIgnorePendingStylesheets(blink::Document::RunPostLayoutTasks) /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/dom/Document.cpp:2302 I 10.803s Main 006a88c7 blink::Document::updateStyleAndLayoutIgnorePendingStylesheetsForNode(blink::Node*) /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/dom/Document.cpp:2192 I 10.803s Main I 10.803s Main ----------------------------------------------------- I 10.804s Main I 10.804s Main r0 00000000 r1 00005a60 r2 00000006 r3 00000008 I 10.804s Main r4 e464f978 r5 00000006 r6 e464f920 r7 0000010c I 10.804s Main r8 e464bf90 r9 e464bf90 sl e464c430 fp e464c990 I 10.804s Main ip 00000002 sp e464bf28 lr ecf6f557 pc ecf71db4 I 10.804s Main I 10.804s Main Stack Trace: I 10.804s Main RELADDR FUNCTION FILE:LINE I 10.804s Main 00049db4 tgkill+12 /system/lib/libc.so I 10.804s Main 00047553 pthread_kill+34 /system/lib/libc.so I 10.805s Main 0001d8a5 raise+10 /system/lib/libc.so I 10.805s Main 000193f1 __libc_android_abort+34 /system/lib/libc.so I 10.805s Main 00017034 abort+4 /system/lib/libc.so I 10.805s Main v------> base::debug::(anonymous namespace)::DebugBreak() /usr/local/google/home/yoichio/src/chromeAndroid/src/base/debug/debugger_posix.cc:221 I 10.805s Main 00091777 base::debug::BreakDebugger() /usr/local/google/home/yoichio/src/chromeAndroid/src/base/debug/debugger_posix.cc:251 I 10.805s Main 000a5793 ~LogMessage /usr/local/google/home/yoichio/src/chromeAndroid/src/base/logging.cc:759 I 10.805s Main 006a57f5 blink::Document::updateStyleAndLayoutTree() /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/dom/Document.cpp:1997 I 10.805s Main 006a8b59 blink::Document::updateStyleAndLayoutTreeIgnorePendingStylesheets() /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/dom/Document.cpp:2297 I 10.805s Main v------> blink::Document::updateStyleAndLayoutIgnorePendingStylesheets(blink::Document::RunPostLayoutTasks) /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/dom/Document.cpp:2302 I 10.805s Main 006a88c5 blink::Document::updateStyleAndLayoutIgnorePendingStylesheetsForNode(blink::Node*) /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/dom/Document.cpp:2192 I 10.806s Main 006d1117 blink::Element::clientHeight() /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/dom/Element.cpp:771 I 10.806s Main 00c05857 blink::MediaControlsPainter::paintMediaOverlayPlayButton(blink::LayoutObject const&, blink::PaintInfo const&, blink::IntRect const&) /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp:196 I 10.806s Main 00bf53cf blink::BoxPainter::paintBoxDecorationBackgroundWithRect(blink::PaintInfo const&, blink::LayoutPoint const&, blink::LayoutRect const&) /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/paint/BoxPainter.cpp:177 I 10.806s Main 00bf51ad blink::BoxPainter::paintBoxDecorationBackground(blink::PaintInfo const&, blink::LayoutPoint const&) /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/paint/BoxPainter.cpp:87 I 10.806s Main 00a89999 blink::LayoutBox::paintBoxDecorationBackground(blink::PaintInfo const&, blink::LayoutPoint const&) const /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/layout/LayoutBox.cpp:1494 I 10.806s Main 00bedbbb blink::BlockPainter::paintObject(blink::PaintInfo const&, blink::LayoutPoint const&) /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/paint/BlockPainter.cpp:175 I 10.806s Main 00a6b137 blink::LayoutBlock::paintObject(blink::PaintInfo const&, blink::LayoutPoint const&) const /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/layout/LayoutBlock.cpp:892 I 10.806s Main 00bed5d9 blink::BlockPainter::paint(blink::PaintInfo const&, blink::LayoutPoint const&) /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/paint/BlockPainter.cpp:53 I 10.806s Main 00a6b113 blink::LayoutBlock::paint(blink::PaintInfo const&, blink::LayoutPoint const&) const /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/layout/LayoutBlock.cpp:882 I 10.807s Main 00c1ba4f blink::PaintLayerPainter::paintFragmentWithPhase(blink::PaintPhase, blink::PaintLayerFragment const&, blink::GraphicsContext&, blink::ClipRect const&, blink::PaintLayerPaintingInfo const&, unsigned int, blink::PaintLayerPainter::ClipState) /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:998 I 10.807s Main 00c1ab85 blink::PaintLayerPainter::paintBackgroundForFragments(WTF::Vector<blink::PaintLayerFragment, 1u, WTF::PartitionAllocator> const&, blink::GraphicsContext&, blink::LayoutRect const&, blink::PaintLayerPaintingInfo const&, unsigned int) /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:1012 I 10.807s Main 00c1a2a7 blink::PaintLayerPainter::paintLayerContents(blink::GraphicsContext&, blink::PaintLayerPaintingInfo const&, unsigned int, blink::PaintLayerPainter::FragmentPolicy) /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:533 I 10.807s Main 00b1e5f9 blink::CompositedLayerMapping::doPaintTask(blink::GraphicsLayerPaintInfo const&, blink::GraphicsLayer const&, unsigned int const&, blink::GraphicsContext&, blink::IntRect const&) const /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp:2985 I 10.807s Main 00b1ed67 blink::CompositedLayerMapping::paintContents(blink::GraphicsLayer const*, blink::GraphicsContext&, unsigned int, blink::IntRect const&) const /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp:3283 I 10.807s Main 00190841 blink::GraphicsLayer::paintWithoutCommit(blink::IntRect const*, blink::GraphicsContext::DisabledMode) /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp:320 I 10.807s Main 0019061d blink::GraphicsLayer::paint(blink::IntRect const*, blink::GraphicsContext::DisabledMode) /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp:278 .... I 10.808s Main 0084e411 blink::FrameView::paintTree() /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/frame/FrameView.cpp:3198 I 10.809s Main 0084d37f blink::FrameView::updateLifecyclePhasesInternal(blink::DocumentLifecycle::LifecycleState) /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/frame/FrameView.cpp:3094 I 10.809s Main 00bd35ad blink::PageAnimator::updateAllLifecyclePhases(blink::LocalFrame&) /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/core/page/PageAnimator.cpp:86 I 10.809s Main 00104abd blink::WebViewImpl::updateAllLifecyclePhases() /usr/local/google/home/yoichio/src/chromeAndroid/src/third_party/WebKit/Source/web/WebViewImpl.cpp:2042 I 10.809s Main 00b2d30d content::RenderWidget::UpdateVisualState() /usr/local/google/home/yoichio/src/chromeAndroid/src/content/renderer/render_widget.cc:944 I 10.809s Main 0014457d cc::ProxyMain::BeginMainFrame(std::__ndk1::unique_ptr<cc::BeginMainFrameAndCommitState, std::__ndk1::default_delete<cc::BeginMainFrameAndCommitState> >)
,
Apr 3 2017
,
May 19 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Mar 30 2017