Issue metadata
Sign in to add a comment
|
Internal page icon missing from PageInfo in MacViews |
||||||||||||||||||||||
Issue descriptionChrome Version: 59.3056 What steps will reproduce the problem? (1) Enable chrome://flags#secondary-ui-md (2) Click the Page Info button (3) Observe: Icon is missing, only "You're viewing a secure Google Chrome page" is shown. The IDR_PRODUCT_LOGO_16 icon is present in Windows/CrOS/Cocoa.
,
Mar 30 2017
Ah, interesting, this does appear to be a Harmony thing?
bool LayoutDelegate::ShouldShowWindowIcon() const {
return true;
}
bool HarmonyLayoutDelegate::ShouldShowWindowIcon() const {
return false;
}
LayoutDelegate* LayoutDelegate::Get() {
return ui::MaterialDesignController::IsSecondaryUiMaterial()
? HarmonyLayoutDelegate::Get()
: layout_delegate_.Pointer();
}
From a pure user point-of-view, the bubble looks pretty bare without the icon.
,
Apr 3 2017
Yep, that behavior is exactly per spec: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)/Preview/11-Permissions#%2F02-Permissions_OIB_chrome.png It does look kind of bare, but it's definitely deliberate.
,
Apr 3 2017
Sounds good. Thanks for the spec reference! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
/Secondary%20UI%20Previews%20and%20specs%20(exports)/Preview/11-Permissions#%2F02-Permissions_OIB_chrome.png){kind=link}
Comment 1 by lgar...@chromium.org
, Mar 30 2017Status: Assigned (was: Untriaged)