New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706850 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 706833

Blocking:
issue 634542
issue 704155



Sign in to add a comment

Test coverage for Rec2020 and P3 in ImageDataTest::TestGetImageDataInCanvasColorSettings

Project Member Reported by zakerinasab@chromium.org, Mar 30 2017

Issue description


When  crbug.com/706833  is fixed, update the uni test ImageDataTest::TestGetImageDataInCanvasColorSettings in core/html/ImageDataTest.cpp such that the conversion from/to Rec2020 and P3 have test coverage.
 
Labels: -Type-Bug Type-Feature
Blocking: 704155
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8befd9e691b73db52cc1d6edb6a99c1043a15b89

commit 8befd9e691b73db52cc1d6edb6a99c1043a15b89
Author: zakerinasab <zakerinasab@chromium.org>
Date: Fri Mar 31 22:17:36 2017

Prepare ImageData for color managed BaseRenderingContext2D::create/put/get-ImageData

* createImageData() and getImageData() must return an ImageData for which the color space and storage format matches those of canvas.
If canvas pixel format is "float16", the storage format of the returned ImageData must be "float32". Values must be properly converted from float16 to float32.

* putImageData must do the color conversion from the color space and storage format of given ImageData to the color space and matching pixel format of canvas prior to putting data into the canvas.

This CL does half the job by adding required methods and the proper unit tests to ImageData.

BUG= 704155 , 706850 

Review-Url: https://codereview.chromium.org/2771813003
Cr-Commit-Position: refs/heads/master@{#461249}

[modify] https://crrev.com/8befd9e691b73db52cc1d6edb6a99c1043a15b89/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
[modify] https://crrev.com/8befd9e691b73db52cc1d6edb6a99c1043a15b89/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp
[modify] https://crrev.com/8befd9e691b73db52cc1d6edb6a99c1043a15b89/third_party/WebKit/Source/core/html/ImageData.cpp
[modify] https://crrev.com/8befd9e691b73db52cc1d6edb6a99c1043a15b89/third_party/WebKit/Source/core/html/ImageData.h
[modify] https://crrev.com/8befd9e691b73db52cc1d6edb6a99c1043a15b89/third_party/WebKit/Source/core/html/ImageDataTest.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/634dbb84b4876a928019a96d8cc80a011223f854

commit 634dbb84b4876a928019a96d8cc80a011223f854
Author: timloh <timloh@chromium.org>
Date: Tue Apr 04 07:09:18 2017

Revert of Prepare ImageData for color managed BaseRenderingContext2D::create/put/get-ImageData (patchset #10 id:180001 of https://codereview.chromium.org/2771813003/ )

Reason for revert:
TestConvertPixelsFromCanvasPixelFormatToImageDataStorageFormat crashing

On WebKit Linux Trusty (dbg), has been flakily crashing (passing on retry) since it was added but now is crashing consistently.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29

Crashes more on the ClangToTLinuxASan/ClangToTMacASan fyi bots.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_unit_tests&tests=TestConvertPixelsFromCanvasPixelFormatToImageDataStorageFormat

Original issue's description:
> Prepare ImageData for color managed BaseRenderingContext2D::create/put/get-ImageData
>
> * createImageData() and getImageData() must return an ImageData for which the color space and storage format matches those of canvas.
> If canvas pixel format is "float16", the storage format of the returned ImageData must be "float32". Values must be properly converted from float16 to float32.
>
> * putImageData must do the color conversion from the color space and storage format of given ImageData to the color space and matching pixel format of canvas prior to putting data into the canvas.
>
> This CL does half the job by adding required methods and the proper unit tests to ImageData.
>
> BUG= 704155 , 706850 
>
> Review-Url: https://codereview.chromium.org/2771813003
> Cr-Commit-Position: refs/heads/master@{#461249}
> Committed: https://chromium.googlesource.com/chromium/src/+/8befd9e691b73db52cc1d6edb6a99c1043a15b89

TBR=junov@chromium.org,zakerinasab@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 704155 , 706850 

Review-Url: https://codereview.chromium.org/2798523002
Cr-Commit-Position: refs/heads/master@{#461651}

[modify] https://crrev.com/634dbb84b4876a928019a96d8cc80a011223f854/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
[modify] https://crrev.com/634dbb84b4876a928019a96d8cc80a011223f854/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp
[modify] https://crrev.com/634dbb84b4876a928019a96d8cc80a011223f854/third_party/WebKit/Source/core/html/ImageData.cpp
[modify] https://crrev.com/634dbb84b4876a928019a96d8cc80a011223f854/third_party/WebKit/Source/core/html/ImageData.h
[modify] https://crrev.com/634dbb84b4876a928019a96d8cc80a011223f854/third_party/WebKit/Source/core/html/ImageDataTest.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4df23d876fddc1f90b17aeaf4bad970239c6ecf

commit c4df23d876fddc1f90b17aeaf4bad970239c6ecf
Author: zakerinasab <zakerinasab@chromium.org>
Date: Tue Apr 04 17:13:13 2017

Prepare ImageData for color managed BaseRenderingContext2D::create/put/get-ImageData

* createImageData() and getImageData() must return an ImageData for which the color space and storage format matches those of canvas.
If canvas pixel format is "float16", the storage format of the returned ImageData must be "float32". Values must be properly converted from float16 to float32.

* putImageData must do the color conversion from the color space and storage format of given ImageData to the color space and matching pixel format of canvas prior to putting data into the canvas.

This CL does half the job by adding required methods and the proper unit tests to ImageData.

BUG= 704155 , 706850 

Review-Url: https://codereview.chromium.org/2771813003
Cr-Original-Commit-Position: refs/heads/master@{#461249}
Committed: https://chromium.googlesource.com/chromium/src/+/8befd9e691b73db52cc1d6edb6a99c1043a15b89
Review-Url: https://codereview.chromium.org/2771813003
Cr-Commit-Position: refs/heads/master@{#461758}

[modify] https://crrev.com/c4df23d876fddc1f90b17aeaf4bad970239c6ecf/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
[modify] https://crrev.com/c4df23d876fddc1f90b17aeaf4bad970239c6ecf/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp
[modify] https://crrev.com/c4df23d876fddc1f90b17aeaf4bad970239c6ecf/third_party/WebKit/Source/core/html/ImageData.cpp
[modify] https://crrev.com/c4df23d876fddc1f90b17aeaf4bad970239c6ecf/third_party/WebKit/Source/core/html/ImageData.h
[modify] https://crrev.com/c4df23d876fddc1f90b17aeaf4bad970239c6ecf/third_party/WebKit/Source/core/html/ImageDataTest.cpp

Blocking: 634542

Sign in to add a comment