New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706831 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Invoke the `backgroundfetchabort` event for aborted fetches

Project Member Reported by peter@chromium.org, Mar 30 2017

Issue description

The explainer defines the following text:

https://github.com/WICG/background-fetch#reacting-to-abort

> If a background fetch job is aborted, either by the user, or by the developer calling abort() on the background fetch job, the following event is fired in the service worker: [backgroundfetchabort]

This bug is two-folded.
  1) When the developer calls BackgroundFetchManager.abort(), we need to end up calling the event.
  2) When the user aborts the fetch through a user interface, we also need to call the event.

I'll pick up (1), and will then reassign to harkness@ who is working on enabling (2).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/438975fc49827c2b419b0c173570c4604c74c59b

commit 438975fc49827c2b419b0c173570c4604c74c59b
Author: peter <peter@chromium.org>
Date: Tue Apr 18 16:39:13 2017

Fire the `backgroundfetchabort` event for aborted fetches

When the status of a completed fetch is ABORTED, which can be caused by
either the user (by using the notification) or the developer (by calling
abort() on the registration), fire the aforementioned event.

BUG= 706831 

Review-Url: https://codereview.chromium.org/2824223002
Cr-Commit-Position: refs/heads/master@{#465263}

[modify] https://crrev.com/438975fc49827c2b419b0c173570c4604c74c59b/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/438975fc49827c2b419b0c173570c4604c74c59b/content/browser/background_fetch/background_fetch_service_unittest.cc

Comment 2 by peter@chromium.org, Apr 18 2017

Status: Fixed (was: Started)

Sign in to add a comment