should.beEqualTo(null) prints incorrectly |
||
Issue description
Consider this:
c = new AudioContext()
n = new ConvolverNode(c)
should(n.buffer, "n.buffer").beEqualTo(null)
This prints something like
FAIL X n.buffer is equal to ${expected}.
We didn't fill in ${expected} with the value null.
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a096748a260d779cf5fce84030f9fd079fadb53 commit 5a096748a260d779cf5fce84030f9fd079fadb53 Author: Raymond Toy <rtoy@chromium.org> Date: Tue Nov 14 20:28:34 2017 Handle Should().beEqualTo(null) Print out "null" in this case instead of the unhelpful "${expected}". Update the wpt version as well. Update test expectations appropriately. Bug: 706826 Test: Change-Id: I99466a5891d1902d4e516c2824cae481bd5c7fdb Reviewed-on: https://chromium-review.googlesource.com/769293 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#516407} [modify] https://crrev.com/5a096748a260d779cf5fce84030f9fd079fadb53/third_party/WebKit/LayoutTests/external/wpt/webaudio/resources/audit.js [modify] https://crrev.com/5a096748a260d779cf5fce84030f9fd079fadb53/third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt [modify] https://crrev.com/5a096748a260d779cf5fce84030f9fd079fadb53/third_party/WebKit/LayoutTests/webaudio/resources/audit.js [modify] https://crrev.com/5a096748a260d779cf5fce84030f9fd079fadb53/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures-expected.txt
,
Nov 15 2017
,
Nov 15 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by rtoy@chromium.org
, Mar 30 2017The code tests that the expected value is not null: if (this._expected !== null) { this._detail = this._detail.replace( /\$\{expected\}/g, this._expectedDescription); } Not sure what to do about this.