New issue
Advanced search Search tips

Issue 706824 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Chrome does not compile with pdf_enable_xfa_override = true

Project Member Reported by npm@chromium.org, Mar 30 2017

Issue description

Set the variable in build_overrides/pdfium.gni. Try to compile.

Errors are of the form:
../../third_party/pdfium/third_party/freetype/include/freetype/fttypes.h:354:19: error: redefinition of 'FT_UnitVector_'
  typedef struct  FT_UnitVector_
                  ^
../../build/linux/debian_wheezy_amd64-sysroot/usr/include/freetype2/freetype/fttypes.h:350:19: note: previous definition is here
  typedef struct  FT_UnitVector_

Cause: commit 4b0671ab3e795bbb5e6aaf6305cae3171d73d241 Reviewed-on: https://pdfium-review.googlesource.com/2971

 

Comment 1 by drott@chromium.org, Mar 30 2017

Status: Started (was: Assigned)
I'll take a look, some strange include path confusion, it's using both types of headers, system, as intended, and third_party bundled. Probably requires some adjustments to the third_party/BUILD.gn.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/dd046dac0819b2db4c445f7cc4b8bab15d8409c1

commit dd046dac0819b2db4c445f7cc4b8bab15d8409c1
Author: Dominik Röttsches <drott@chromium.org>
Date: Thu Mar 30 16:56:18 2017

Fix Chromium XFA build

Remove unnecessary FreeType include.

BUG= chromium:706824 

Change-Id: If3006a047e9431d6bf4111da867a998994034f56
Reviewed-on: https://pdfium-review.googlesource.com/3391
Reviewed-by: Nicolás Peña <npm@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>

[modify] https://crrev.com/dd046dac0819b2db4c445f7cc4b8bab15d8409c1/xfa/fgas/font/cfgas_fontmgr.h

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/dd046dac0819b2db4c445f7cc4b8bab15d8409c1

commit dd046dac0819b2db4c445f7cc4b8bab15d8409c1
Author: Dominik Röttsches <drott@chromium.org>
Date: Thu Mar 30 16:56:18 2017

Fix Chromium XFA build

Remove unnecessary FreeType include.

BUG= chromium:706824 

Change-Id: If3006a047e9431d6bf4111da867a998994034f56
Reviewed-on: https://pdfium-review.googlesource.com/3391
Reviewed-by: Nicolás Peña <npm@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>

[modify] https://crrev.com/dd046dac0819b2db4c445f7cc4b8bab15d8409c1/xfa/fgas/font/cfgas_fontmgr.h

Comment 5 by drott@chromium.org, Mar 30 2017

Status: Fixed (was: Started)
 Issue 706929  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/026a2f4a1f023de9bf72674db9c88cdcf651418e

commit 026a2f4a1f023de9bf72674db9c88cdcf651418e
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Thu Mar 30 23:12:03 2017

Roll src/third_party/pdfium/ 213f01205..bf9104d58 (15 commits)

https://pdfium.googlesource.com/pdfium.git/+log/213f01205a77..bf9104d5825d

$ git log 213f01205..bf9104d58 --date=short --no-merges --format='%ad %ae %s'
2017-03-30 tsepez vswprintf() part 1: move code, create helper function.
2017-03-30 dsinclair Move CXFA_XMLParser to CFDE_XMLParser
2017-03-30 thestig Fix some nits in the javascript util code.
2017-03-30 dsinclair Add some calls to MakeUnique
2017-03-30 dsinclair Move core/fxcrt XML files to core/fxcrt/xml
2017-03-30 tsepez Avoid one more instance of the anti-pattern in 706346.
2017-03-30 npm Libtiff security upstream patches
2017-03-30 dsinclair Rename tto/fde_textout to cfde_textout
2017-03-30 dsinclair Move CFX files into fxcrt
2017-03-30 thakis Revert "Enable Wshift-negative-value in PDFium."
2017-03-30 tsepez Protect against premature mask destruction in CFX_ClipRgn::IntersectRect
2017-03-30 drott Remove unnecessary FreeType include.
2017-03-30 dsinclair Rename FDE files to match contents.
2017-03-30 drott Fix Chromium XFA build
2017-03-30 dsinclair Rename fgas_stream to ifgas_stream

Created with:
  roll-dep src/third_party/pdfium
BUG= 507717 , 706346 , 706824 , 706824 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2787763003
Cr-Commit-Position: refs/heads/master@{#460917}

[modify] https://crrev.com/026a2f4a1f023de9bf72674db9c88cdcf651418e/DEPS

Sign in to add a comment