New issue
Advanced search Search tips

Issue 706821 link

Starred by 1 user
Status: Archived
Owner:
est...@chromium.org
Closed: Jun 2017
Cc:
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Rename Destroy*View() methods in SystemTrayItem

Project Member Reported by tdander...@chromium.org, Mar 30 2017 
The following three virtual methods in SystemTrayItem don't actually destroy anything, rather they are called when the corresponding item is about to be destroyed. They should be re-named accordingly, perhaps *ViewDestroyed() or *ViewWillBeDestroyed().

virtual void DestroyTrayView();
virtual void DestroyDefaultView();
virtual void DestroyDetailedView();

Comment 1 by est...@chromium.org, Mar 31 2017 

I think to match other parts of the code base we might want to use OnTrayViewDestroying()
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e70b0a6a828eff79932f293ccc4f90a27501fae2

commit e70b0a6a828eff79932f293ccc4f90a27501fae2
Author: Evan Stade <estade@chromium.org>
Date: Mon Jun 05 22:18:30 2017

Rename Destroy{Tray,Detailed,Default}View to On...ViewDestroyed()

TBR=oshima@chromium.org

Bug:  706821 
Change-Id: I87251f95fdc672c02246d1224191717e5d9fe23d
Reviewed-on: https://chromium-review.googlesource.com/523807
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Terry Anderson <tdanderson@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477097}
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/audio/tray_audio.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/audio/tray_audio.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/bluetooth/tray_bluetooth.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/brightness/tray_brightness.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/brightness/tray_brightness.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/cast/tray_cast.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/date/tray_system_info.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/date/tray_system_info.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/display_scale/tray_scale.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/display_scale/tray_scale.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/enterprise/tray_enterprise.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/enterprise/tray_enterprise.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/ime/tray_ime_chromeos.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/network/tray_network.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/network/tray_network.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/network/tray_vpn.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/network/tray_vpn.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/power/tray_power.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/power/tray_power.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/rotation/tray_rotation_lock.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/rotation/tray_rotation_lock.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/rotation/tray_rotation_lock_unittest.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/screen_security/screen_tray_item.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/screen_security/screen_tray_item.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/session/tray_session_length_limit.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/session/tray_session_length_limit.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/tiles/tray_tiles.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/tiles/tray_tiles.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/tray/system_tray.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/tray/system_tray_item.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/tray/system_tray_item.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/tray/tray_details_view_unittest.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/tray/tray_image_item.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/tray/tray_image_item.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/tray_accessibility.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/tray_accessibility.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/tray_caps_lock.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/tray_caps_lock.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/tray_tracing.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/tray_tracing.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/update/tray_update.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/update/tray_update.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/user/tray_user.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/system/user/tray_user.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/test/test_system_tray_item.cc
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/ash/test/test_system_tray_item.h
[modify] https://crrev.com/e70b0a6a828eff79932f293ccc4f90a27501fae2/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc

Comment 3 by est...@chromium.org, Jun 6 2017

Owner: est...@chromium.org
Status: Fixed (was: Available)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment