New issue
Advanced search Search tips

Issue 706813 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Apr 2017
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[Android O] Add UMA for disabling of notification channels

Project Member Reported by awdf@chromium.org, Mar 30 2017 
Right now we only record whether all notifications are disabled at an OS Level (Notifications.AppNotificationStatus), with Android O we could also be recording whether notifications are disabled for the channel, at the point a notification is to be displayed.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0ba3b6e3f693d2a11992a48dc28508bbfc89731

commit d0ba3b6e3f693d2a11992a48dc28508bbfc89731
Author: awdf <awdf@chromium.org>
Date: Fri Apr 21 19:59:22 2017

[Android O] Add SystemNotification.ChannelBlocked histogram

- Added a new histogram for notifications that were already being
logged via NotificationUmaTracker.

- Now, if notifications are enabled at the app level but blocked at the
channel level, they will be counted in this histogram, instead of the
SystemNotification.Shown histogram.

- If notifications are blocked at the app level they will still be
counted in SystemNotification.Blocked, regardless of channel status.

TBR=dtrainor@chromium.org

BUG= 706813 

Review-Url: https://codereview.chromium.org/2834633002
Cr-Commit-Position: refs/heads/master@{#466424}

[modify] https://crrev.com/d0ba3b6e3f693d2a11992a48dc28508bbfc89731/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/d0ba3b6e3f693d2a11992a48dc28508bbfc89731/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java
[modify] https://crrev.com/d0ba3b6e3f693d2a11992a48dc28508bbfc89731/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
[modify] https://crrev.com/d0ba3b6e3f693d2a11992a48dc28508bbfc89731/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java
[modify] https://crrev.com/d0ba3b6e3f693d2a11992a48dc28508bbfc89731/tools/metrics/histograms/histograms.xml

Comment 2 by awdf@chromium.org, Apr 24 2017

Labels: -Pri-2 M-59 Pri-1
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8191a0ccfd4ffb453432bf35875022899f22a3a2

commit 8191a0ccfd4ffb453432bf35875022899f22a3a2
Author: awdf <awdf@chromium.org>
Date: Mon Apr 24 17:33:50 2017

[Android] Log notification shown/blocked for all other notifications

- Added new SystemNotificationTypes and logging for Media Capture,
Physical Web, Media, Sites and Sync notifications.

- This now captures all notifications that are posted right now.

BUG= 706813 ,688435

Review-Url: https://codereview.chromium.org/2833583004
Cr-Commit-Position: refs/heads/master@{#466670}

[modify] https://crrev.com/8191a0ccfd4ffb453432bf35875022899f22a3a2/chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationService.java
[modify] https://crrev.com/8191a0ccfd4ffb453432bf35875022899f22a3a2/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
[modify] https://crrev.com/8191a0ccfd4ffb453432bf35875022899f22a3a2/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
[modify] https://crrev.com/8191a0ccfd4ffb453432bf35875022899f22a3a2/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
[modify] https://crrev.com/8191a0ccfd4ffb453432bf35875022899f22a3a2/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java
[modify] https://crrev.com/8191a0ccfd4ffb453432bf35875022899f22a3a2/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java
[modify] https://crrev.com/8191a0ccfd4ffb453432bf35875022899f22a3a2/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerServiceLifecycleTest.java
[modify] https://crrev.com/8191a0ccfd4ffb453432bf35875022899f22a3a2/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerTestBase.java
[modify] https://crrev.com/8191a0ccfd4ffb453432bf35875022899f22a3a2/tools/metrics/histograms/histograms.xml

Comment 4 by awdf@chromium.org, Apr 24 2017

Labels: Merge-Request-59
Status: Fixed (was: Started)
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 24 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 25 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab21f85201dc5947c009f97c6d0caf505f2be897

commit ab21f85201dc5947c009f97c6d0caf505f2be897
Author: Anita Woodruff <awdf@chromium.org>
Date: Tue Apr 25 09:50:19 2017

[Android O] Add SystemNotification.ChannelBlocked histogram

- Added a new histogram for notifications that were already being
logged via NotificationUmaTracker.

- Now, if notifications are enabled at the app level but blocked at the
channel level, they will be counted in this histogram, instead of the
SystemNotification.Shown histogram.

- If notifications are blocked at the app level they will still be
counted in SystemNotification.Blocked, regardless of channel status.

TBR=dtrainor@chromium.org

BUG= 706813 

Review-Url: https://codereview.chromium.org/2834633002
Cr-Commit-Position: refs/heads/master@{#466424}
(cherry picked from commit d0ba3b6e3f693d2a11992a48dc28508bbfc89731)

Review-Url: https://codereview.chromium.org/2837283002 .
Cr-Commit-Position: refs/branch-heads/3071@{#197}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/ab21f85201dc5947c009f97c6d0caf505f2be897/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/ab21f85201dc5947c009f97c6d0caf505f2be897/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java
[modify] https://crrev.com/ab21f85201dc5947c009f97c6d0caf505f2be897/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
[modify] https://crrev.com/ab21f85201dc5947c009f97c6d0caf505f2be897/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java
[modify] https://crrev.com/ab21f85201dc5947c009f97c6d0caf505f2be897/tools/metrics/histograms/histograms.xml
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfb19fe46ed110f8ecca2b0242d86f380d9b065d

commit bfb19fe46ed110f8ecca2b0242d86f380d9b065d
Author: Anita Woodruff <awdf@chromium.org>
Date: Tue Apr 25 10:18:31 2017

[Android] Log notification shown/blocked for all other notifications

- Added new SystemNotificationTypes and logging for Media Capture,
Physical Web, Media, Sites and Sync notifications.

- This now captures all notifications that are posted right now.

BUG= 706813 ,688435

Review-Url: https://codereview.chromium.org/2833583004
Cr-Commit-Position: refs/heads/master@{#466670}
(cherry picked from commit 8191a0ccfd4ffb453432bf35875022899f22a3a2)

Review-Url: https://codereview.chromium.org/2837283003 .
Cr-Commit-Position: refs/branch-heads/3071@{#198}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/bfb19fe46ed110f8ecca2b0242d86f380d9b065d/chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationService.java
[modify] https://crrev.com/bfb19fe46ed110f8ecca2b0242d86f380d9b065d/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
[modify] https://crrev.com/bfb19fe46ed110f8ecca2b0242d86f380d9b065d/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
[modify] https://crrev.com/bfb19fe46ed110f8ecca2b0242d86f380d9b065d/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
[modify] https://crrev.com/bfb19fe46ed110f8ecca2b0242d86f380d9b065d/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java
[modify] https://crrev.com/bfb19fe46ed110f8ecca2b0242d86f380d9b065d/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java
[modify] https://crrev.com/bfb19fe46ed110f8ecca2b0242d86f380d9b065d/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerServiceLifecycleTest.java
[modify] https://crrev.com/bfb19fe46ed110f8ecca2b0242d86f380d9b065d/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerTestBase.java
[modify] https://crrev.com/bfb19fe46ed110f8ecca2b0242d86f380d9b065d/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment