New issue
Advanced search Search tips

Issue 706804 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Feature



Sign in to add a comment

Remove deprecated console methods

Project Member Reported by domfarolino@gmail.com, Mar 30 2017

Issue description

Chrome Version       : 54.0.2840.100 (Official Build) (64-bit) on Ubuntu 16.04
URLs (if applicable) :
Other browsers tested: Firefox Safari Edge
  Add OK or FAIL, along with the version, after other browsers where you
have tested this issue:
     Safari: OK
    Firefox: OK
         IE: OK


As per this conversation (this comment specifically: https://github.com/whatwg/console/issues/27#issuecomment-289312546) console.timeline and console.timelineEnd should not appear on the console object anymore. They only appear in one other browser (Firefox) as no-op and it has been decided they will not appear in the console living standard. A bug has been opened up on Bugzilla to initiate the removal of these no-op methods as well.

Not sure how to CC people on issues, but I'd like to CC Paul Irish if possible  given the conversation linked above :)
 
Cc: paulir...@chromium.org nyerramilli@chromium.org
Components: Platform>DevTools
Labels: -Type-Bug Needs-Milestone OS-Linux OS-Mac OS-Windows Type-Feature
Status: Untriaged (was: Unconfirmed)
Thanks for the report..

Considering this as Feature request marking as Untriaged.

Requesting Dev team to look into this issue and update.

cced paulirish@, if you are not the concerned person please excuse.
Owner: paulir...@chromium.org
Status: Assigned (was: Untriaged)
Cc: domfarolino@gmail.com
paulirish@ would you mind if I took this?
Cc: -domfarolino@gmail.com
Owner: domfarolino@gmail.com
Status: Started (was: Assigned)
Summary: Remove deprecated console methods (was: console.timeline and console.timelineEnd should be removed.)
Changing this to focus on removing all deprecated console methods (this just entails removing one more method, markTimeline). See http://crrev.com/c/1082112 for details.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd8a54959dd463f6fcb91c39e33edbfb26a4bd3d

commit fd8a54959dd463f6fcb91c39e33edbfb26a4bd3d
Author: Dominic Farolino <domfarolino@gmail.com>
Date: Mon Jun 18 14:23:20 2018

Prepare to remove deprecated console methods

This CL removes layout tests for deprecated console methods as well as
removes expectation files for failing console WPTs that assert the
non-existence of these methods. These need removed so that the v8
auto-roll with the removed console methods don't fail the chromium
layout tests. Also this CL removes the test expectations for console
WPTs that assert the non-existence of these deprecated methods, but
marks the tests as skipped for now, until the v8 changes are in
chromium.

R=kozyatinskiy@chromium.org

Bug:  706804 
Change-Id: If11e0c6a26d6ccc29474fb0148900d034cd40b86
Reviewed-on: https://chromium-review.googlesource.com/1103937
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
Cr-Commit-Position: refs/heads/master@{#567994}
[modify] https://crrev.com/fd8a54959dd463f6fcb91c39e33edbfb26a4bd3d/third_party/WebKit/LayoutTests/MSANExpectations
[modify] https://crrev.com/fd8a54959dd463f6fcb91c39e33edbfb26a4bd3d/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/10c14ca46e16a1dfbe3325946f3f5414b45d5d62/third_party/WebKit/LayoutTests/external/wpt/console/console-tests-historical.any-expected.txt
[delete] https://crrev.com/10c14ca46e16a1dfbe3325946f3f5414b45d5d62/third_party/WebKit/LayoutTests/external/wpt/console/console-tests-historical.any.worker-expected.txt
[modify] https://crrev.com/fd8a54959dd463f6fcb91c39e33edbfb26a4bd3d/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/console-timeline-expected.txt
[modify] https://crrev.com/fd8a54959dd463f6fcb91c39e33edbfb26a4bd3d/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/console-timeline.js
[delete] https://crrev.com/10c14ca46e16a1dfbe3325946f3f5414b45d5d62/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-mark-timeline-expected.txt
[delete] https://crrev.com/10c14ca46e16a1dfbe3325946f3f5414b45d5d62/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-mark-timeline.js
[modify] https://crrev.com/fd8a54959dd463f6fcb91c39e33edbfb26a4bd3d/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-timer-fired-from-eval-call-site.js
[delete] https://crrev.com/10c14ca46e16a1dfbe3325946f3f5414b45d5d62/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-deprecated-methods-expected.txt
[delete] https://crrev.com/10c14ca46e16a1dfbe3325946f3f5414b45d5d62/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-deprecated-methods.js

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/888b6b538049e94313396b10aab3f21b5367d7a0

commit 888b6b538049e94313396b10aab3f21b5367d7a0
Author: Dominic Farolino <domfarolino@gmail.com>
Date: Fri Jun 22 11:40:29 2018

Remove console deprecation web features

This CL removes the console deprecation web features as well as fixes
more tests that fail with the deprecated console methods removed. Until
the v8 CL that actually removes these deprecated methods lands however,
we have to disable tests on the Chromium side until v8 auto-rolls with
the removed methods. See crrev.com/c/1082112.

Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/pNn_QZxtRlg

R=kozyatinskiy@chromium.org, mkwst@chromium.org

Bug:  706804 
Change-Id: I14f4b43373941871333389c9fc8f0f3f770d71b6
Reviewed-on: https://chromium-review.googlesource.com/1105628
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
Cr-Commit-Position: refs/heads/master@{#569580}
[modify] https://crrev.com/888b6b538049e94313396b10aab3f21b5367d7a0/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/888b6b538049e94313396b10aab3f21b5367d7a0/third_party/WebKit/LayoutTests/fast/workers/chromium/shared-worker-console-log.html
[modify] https://crrev.com/888b6b538049e94313396b10aab3f21b5367d7a0/third_party/WebKit/LayoutTests/fast/workers/chromium/worker-console-log-expected.txt
[modify] https://crrev.com/888b6b538049e94313396b10aab3f21b5367d7a0/third_party/WebKit/LayoutTests/fast/workers/chromium/worker-console-log.html
[modify] https://crrev.com/888b6b538049e94313396b10aab3f21b5367d7a0/third_party/WebKit/LayoutTests/http/tests/serviceworker/usecounter.html
[modify] https://crrev.com/888b6b538049e94313396b10aab3f21b5367d7a0/third_party/WebKit/LayoutTests/http/tests/workers/shared-worker-usecounter.html
[modify] https://crrev.com/888b6b538049e94313396b10aab3f21b5367d7a0/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/888b6b538049e94313396b10aab3f21b5367d7a0/third_party/blink/renderer/core/frame/deprecation.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/313bc6d43f5393d3f9f4cd52aab1c4fa8e5b0b62

commit 313bc6d43f5393d3f9f4cd52aab1c4fa8e5b0b62
Author: Dominic Farolino <domfarolino@gmail.com>
Date: Fri Jun 22 15:16:29 2018

[inspector] remove deprecated console methods

As per https://github.com/whatwg/console/issues/27#issuecomment-289312546
and https://bugs.chromium.org/p/chromium/issues/detail?id=706804 we're
leaving the console timeline/timelineEnd methods out of the specification
and testing that implementations do not expose them (relevant WPTs at
https://github.com/web-platform-tests/wpt/blob/master/console/console-tests-historical.any.js).
Their implementations should be removed from Chrome, one of the last
implementers of these legacy methods. The same goes for markTimeline, as
it is deprecated in Chrome and not being included in the spec.

R=bmeurer@chromium.org, kozyatinskiy@chromium.org

Bug:  chromium:706804 
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibe05848fb664d26d16eeb5bdf6f519c1eeb4b2df
Reviewed-on: https://chromium-review.googlesource.com/1082112
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
Cr-Commit-Position: refs/heads/master@{#53973}
[modify] https://crrev.com/313bc6d43f5393d3f9f4cd52aab1c4fa8e5b0b62/src/bootstrapper.cc
[modify] https://crrev.com/313bc6d43f5393d3f9f4cd52aab1c4fa8e5b0b62/src/builtins/builtins-console.cc
[modify] https://crrev.com/313bc6d43f5393d3f9f4cd52aab1c4fa8e5b0b62/src/builtins/builtins-definitions.h
[modify] https://crrev.com/313bc6d43f5393d3f9f4cd52aab1c4fa8e5b0b62/src/debug/interface-types.h
[modify] https://crrev.com/313bc6d43f5393d3f9f4cd52aab1c4fa8e5b0b62/src/inspector/v8-console.cc
[modify] https://crrev.com/313bc6d43f5393d3f9f4cd52aab1c4fa8e5b0b62/src/inspector/v8-console.h
[modify] https://crrev.com/313bc6d43f5393d3f9f4cd52aab1c4fa8e5b0b62/test/inspector/runtime/console-context-expected.txt
[delete] https://crrev.com/f2b90bd4dcbc87c4bf9ca8b6025cb82c7bf9210a/test/inspector/runtime/console-deprecated-methods-expected.txt
[delete] https://crrev.com/f2b90bd4dcbc87c4bf9ca8b6025cb82c7bf9210a/test/inspector/runtime/console-deprecated-methods.js

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b235eb9200f0ed9c80f5dc4960cf916751871624

commit b235eb9200f0ed9c80f5dc4960cf916751871624
Author: Dominic Farolino <domfarolino@gmail.com>
Date: Mon Jul 09 16:04:53 2018

Re-enable console historical tests

Historical console tests should be re-enabled after deprecated console
methods are removed.

Bug:  706804 
Change-Id: I4e4ae9c98a95a142168f2eaf45724ee172408766
Reviewed-on: https://chromium-review.googlesource.com/1123773
Reviewed-by: Dominic Farolino <domfarolino@gmail.com>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
Cr-Commit-Position: refs/heads/master@{#573323}
[modify] https://crrev.com/b235eb9200f0ed9c80f5dc4960cf916751871624/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Started)

Sign in to add a comment