New issue
Advanced search Search tips

Issue 706796 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

PRESUBMIT black listing on .gitignore needs more work

Reported by techtonik@gmail.com, Mar 30 2017

Issue description

.gitignore filtering in depot_tools PRESUBMIT.py could be made more universal and reusable. Right now it covers pylint only.

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+blame/1bc7bfe5d9d8360a611d3f73299249e2124c11d7/PRESUBMIT.py#23

The concern is that regexps from .gitignore start with leading / and are matched against relative paths, so this black lists probably do not work. 

Also, on Windows paths need to be translated to forward slashes before matching. This, together with relative path requirement can be refactored into separate Filter component.

It is also hard to test what the internal function that reads .gitignore gets on the output. Connected is the fact that this piece is not covered by tests.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Mar 30 2018

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment