In chrome://md-settings, unnecessary text continuation is seen for 'More actions' tooltip.
Reported by
ngu...@etouch.net,
Mar 30 2017
|
||||||
Issue descriptionChrome Version: 59.0.3056.0 (Official Build) abd1360936725f296381ceb3c194307a29137c53-refs/heads/master@{#460603} (32/64-bit) OS: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS) What steps will reproduce the problem? 1) Launch chrome, navigate to chrome://md-settings and click on 'Manage search engines' button. 2) Mouse hover on iron icon for any search engine entry and observe the tooltip. Unnecessary text continuation is seen for 'More actions' tooltip. Text continuation should not be seen for 'More actions' tooltip. This is a Non-Regression issue seen from M-58 (Chrome version: 58.0.3026.0) Note: 'More actions' tooltip was not seen in previous builds.
,
Apr 3 2018
Looking across Chrome strings, some places uses "More actions..." and some use "More actions". We should at least make them consistent. Removing the "..." seems fine to me, which would also match what chrome://bookmarks does. FWIW, the original "More actions..." string was added at [2] [1] https://cs.chromium.org/search/?q=%22+More+actions%22+-file:third_party+-file:infra+-file:out/Debug+file:grdp&type=cs [2] https://codereview.chromium.org/2716233002
,
Apr 3 2018
,
Apr 3 2018
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/796722dca8f04a814d1b32f17a02a3203efba8c7 commit 796722dca8f04a814d1b32f17a02a3203efba8c7 Author: Esmael El-Moslimany <aee@chromium.org> Date: Wed Apr 04 21:37:21 2018 Settings WebUI: removing unnecessary ellipses Bug: 706795 Change-Id: I524a968de6e1d41d920fc8e70dcda0cdf778a380 Reviewed-on: https://chromium-review.googlesource.com/993239 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#548208} [modify] https://crrev.com/796722dca8f04a814d1b32f17a02a3203efba8c7/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/796722dca8f04a814d1b32f17a02a3203efba8c7/chrome/app/generated_resources.grd [modify] https://crrev.com/796722dca8f04a814d1b32f17a02a3203efba8c7/chrome/app/settings_strings.grdp
,
Apr 4 2018
,
Apr 5 2018
Update : Verified the above issue in latest Canary #67.0.3389.0 build on Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS) OS and the issue is fixed. The fix is working as intended. Kindly review an attached screenshot. Thank you! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by msrchandra@chromium.org
, Mar 30 2017