New issue
Advanced search Search tips

Issue 706787 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

LargeIconService only allows returning raw data

Project Member Reported by jkrcal@chromium.org, Mar 30 2017

Issue description

This is advantagous for some clients that cache (or in other way need to use) raw image data as encoding back is expensive. Still, many clients of the service need to do the decoding on their side.

We should add another function that returns a decoded gfx::Image.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fb02f69ac851beaeafbfcc84fb649744bc0944d

commit 5fb02f69ac851beaeafbfcc84fb649744bc0944d
Author: jkrcal <jkrcal@chromium.org>
Date: Wed Apr 05 17:08:57 2017

[LargeIconService] Allow decoding of images in the service

Previously, LargeIconService only returned raw results. This is
advantagous for some clients that cache (or in other way need to use)
raw image data as encoding back is expensive. Still, many clients of the
service need to do the decoding on their side.

This CL adds another API function with the same behaviour that returns
a decoded gfx::Image if available. It leaves renaming the existing
function, callback, and result struct to a follow-up CL.

BUG= 706787 

Review-Url: https://codereview.chromium.org/2784233003
Cr-Commit-Position: refs/heads/master@{#462125}

[modify] https://crrev.com/5fb02f69ac851beaeafbfcc84fb649744bc0944d/components/favicon/core/large_icon_service.cc
[modify] https://crrev.com/5fb02f69ac851beaeafbfcc84fb649744bc0944d/components/favicon/core/large_icon_service.h
[modify] https://crrev.com/5fb02f69ac851beaeafbfcc84fb649744bc0944d/components/favicon/core/large_icon_service_unittest.cc
[modify] https://crrev.com/5fb02f69ac851beaeafbfcc84fb649744bc0944d/components/favicon_base/favicon_callback.h
[modify] https://crrev.com/5fb02f69ac851beaeafbfcc84fb649744bc0944d/components/favicon_base/favicon_types.cc
[modify] https://crrev.com/5fb02f69ac851beaeafbfcc84fb649744bc0944d/components/favicon_base/favicon_types.h

Status: Fixed (was: Started)

Sign in to add a comment