FlashPermissionBrowserTest.BlockFileURL failing a lot |
||||||
Issue descriptionDisabling this test, since it has failed in the last five runs consistently and been failing intermittently since at least (and maybe longer): https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/53989 Disabling since I didn't see anything obvious in that build to associate with the error. I would have assigned this to Raymes, but got an OOO message, so wondering if Tommy can take a quick look and/or reassign to Raymes once back. The error is: FlashPermissionBrowserTest.BlockFileURL (run #1): [ RUN ] FlashPermissionBrowserTest.BlockFileURL Xlib: extension "RANDR" missing on display ":99". [27037:27037:0330/030517.478316:WARNING:audio_manager.cc(295)] Multiple instances of AudioManager detected [27037:27037:0330/030517.478362:WARNING:audio_manager.cc(254)] Multiple instances of AudioManager detected [27037:27037:0330/030517.525999:WARNING:password_store_factory.cc(247)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [27037:27235:0330/030517.783624:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico [27037:27037:0330/030517.904193:INFO:CONSOLE(1)] "Uncaught ReferenceError: flashIsEnabledForPluginWithoutFallback is not defined", source: (1) BrowserTestBase received signal: Terminated. Backtrace: #0 0x0000029132b7 base::debug::StackTrace::StackTrace() #1 0x000002e96a66 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7efc6b771cb0 <unknown> #3 0x7efc6b827fdd __poll #4 0x7efc71299fe4 <unknown> #5 0x7efc7129a0ec g_main_context_iteration #6 0x00000292c7c6 base::MessagePumpGlib::Run() #7 0x00000292a917 base::MessageLoop::RunHandler() #8 0x000002949fde base::RunLoop::Run() #9 0x000002ebda21 content::MessageLoopRunner::Run() #10 0x0000029b2c82 content::DOMMessageQueue::WaitForMessage() #11 0x0000029b1c67 content::(anonymous namespace)::ExecuteScriptHelper() #12 0x0000029b1f69 content::ExecuteScriptAndExtractBool() #13 0x000000d1ed92 PermissionsBrowserTest::RunScriptReturnBool() #14 0x000000d24063 FlashPermissionBrowserTest::FeatureUsageSucceeds() #15 0x000000d1f7d3 PermissionsBrowserTest::CommonFailsIfBlocked() #16 0x000000d22f12 FlashPermissionBrowserTest_BlockFileURL_Test::RunTestOnMainThread() #17 0x0000029c0ecf InProcessBrowserTest::RunTestOnMainThreadLoop() #18 0x000002e967c8 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #19 0x000002d017e2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #20 0x000002d00891 ChromeBrowserMainParts::PreMainMessageLoopRun() #21 0x00000197aaf5 content::BrowserMainLoop::PreMainMessageLoopRun() #22 0x000001c51c07 content::StartupTaskRunner::RunAllTasksNow() #23 0x000001978cdb content::BrowserMainLoop::CreateStartupTasks() #24 0x00000197ddbc content::BrowserMainRunnerImpl::Initialize() #25 0x0000019763c8 content::BrowserMain() #26 0x0000028fcd1c content::ContentMainRunnerImpl::Run() #27 0x000003d98c65 service_manager::Main() #28 0x0000028fbd62 content::ContentMain() #29 0x000002e96109 content::BrowserTestBase::SetUp() #30 0x0000029bf5c0 InProcessBrowserTest::SetUp() #31 0x00000347399e testing::Test::Run() #32 0x000003474560 testing::TestInfo::Run() #33 0x0000034748d7 testing::TestCase::Run() #34 0x00000347baf7 testing::internal::UnitTestImpl::RunAllTests() #35 0x00000347b777 testing::UnitTest::Run() #36 0x0000029d06e1 base::TestSuite::Run()raymes@chromium.org #37 0x0000029075c8 ChromeTestSuiteRunner::RunTestSuite() #38 0x000002eba04a content::LaunchTests() #39 0x000002907547 main #40 0x7efc6b75cf45 __libc_start_main #41 0x00000060052d <unknown>
,
Mar 30 2017
FlashPermissionBrowserTest.CommonFailsIfBlocked also failing on https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/54035 Probably related?
,
Mar 30 2017
Issue 706774 has been merged into this issue.
,
Mar 30 2017
,
Mar 31 2017
BTW this started flaking with PlzNavigate (--enable-browser-side-navigation) after I made browser-initiated navigations not do a renderer hop first. Previously it always did in case there was a beforeunload handler; with my change (r460581), this stops happening for the 95% of cases that don't have a beforeunload handler. Since the timing is different though, it can affect tests.
,
Mar 31 2017
,
Apr 4 2017
I know staring at it might help, but still... :)
,
Apr 4 2017
(see comment 6)
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ce6642bf40d6df1bd5a827286d1e58887c5012d commit 4ce6642bf40d6df1bd5a827286d1e58887c5012d Author: maxmorin <maxmorin@chromium.org> Date: Tue Apr 04 14:28:16 2017 Disabling FlashPermissionBrowserTest.BlockFileURL on all platforms. Also seen failing on win: https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/10061 BUG= 706780 TBR=tommycli@chromium.org Review-Url: https://codereview.chromium.org/2792003003 Cr-Commit-Position: refs/heads/master@{#461707} [modify] https://crrev.com/4ce6642bf40d6df1bd5a827286d1e58887c5012d/chrome/browser/plugins/flash_permission_browsertest.cc
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76fcce24671c86169992b4e4f120bb1498f7c7fd commit 76fcce24671c86169992b4e4f120bb1498f7c7fd Author: ellyjones <ellyjones@chromium.org> Date: Thu Apr 06 17:28:06 2017 plugins: disable FlashPermissionBrowserTest.CommonFailsIfBlocked BUG= 706780 TBR=jam@chromium.org Review-Url: https://codereview.chromium.org/2805053002 Cr-Commit-Position: refs/heads/master@{#462529} [modify] https://crrev.com/76fcce24671c86169992b4e4f120bb1498f7c7fd/chrome/browser/plugins/flash_permission_browsertest.cc
,
Apr 11 2017
jam: friendly ping, any update here?
,
Apr 12 2017
ah i had it reviewed and I hit cq, but the patch failed because of the other disable and I didn't notice. the fix will land now.
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b3bc5aa5ae314bd7f3eb2283b7b1efec8eb3499 commit 5b3bc5aa5ae314bd7f3eb2283b7b1efec8eb3499 Author: jam <jam@chromium.org> Date: Wed Apr 12 04:29:24 2017 Fix flakiness in FlashPermissionBrowserTest.BlockFileURL with PlzNavigate after r460581. The problem was that navigation now had one less hop to the renderer, and this causes races between the old DidStop IPC and the new navigation. This doesn't happen in production, because we don't dispatch IPCs in nested message loops. BUG= 706780 Review-Url: https://codereview.chromium.org/2793613003 Cr-Commit-Position: refs/heads/master@{#463927} [modify] https://crrev.com/5b3bc5aa5ae314bd7f3eb2283b7b1efec8eb3499/chrome/browser/plugins/flash_permission_browsertest.cc
,
Apr 12 2017
Thanks!
,
Apr 20 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Mar 30 2017