GetTouchKeyboardEnabled is unused |
|
Issue descriptionkeyboard::GetTouchKeyboardEnabled is never used except for test. Remove it and related codes.
,
Mar 30 2017
Can we merge g_touch_keyboard_enabled and g_requested_keyboard_state?
,
Mar 30 2017
I don't think it's immediately possible. They represents different kind of infomation. g_touch_keyboard_enabled represents if touch view mode (aka maximized mode) is enabled. g_requested_keybaord_state is for virtualKeyboardPrivate.setKeyboardState, so that priviledged apps can toggle virtual keyboard. hotrod uses the API. (https://cs.corp.google.com/piper///depot/google3/videoconf/gvc/hotrodapp/application/core/virtualkeyboardhandler.js?type=cs&q=setKeyboardState+file:%5C.js&sq=package:piper+file://depot/google3+-file:google3/obsolete&rcl=151401539&l=85)
,
Mar 31 2017
Oops, I mistakenly deleted the comment 4. So sorry. Fortunately the comment is just thank you by Hanada-san. |
|
►
Sign in to add a comment |
|
Comment 1 by oka@chromium.org
, Mar 30 2017