New issue
Advanced search Search tips

Issue 706765 link

Starred by 1 user
Status: Verified
Owner:
horo@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

preloadResponse of Service Worker Navigation Preload doen't resolve forever when the body is empty

Project Member Reported by horo@chromium.org, Mar 30 2017 
Chrome Version: 59.0.3053.3
OS: All

What steps will reproduce the problem?
(1) Enable chrome://flags/#enable-service-worker-navigation-preload
(2) Go https://horo-t.github.io/serviceworker/demo/tmp/20170105/
(3) Click "Click to register SW" button.
(4) Click "empty" link.

What is the expected result?
Chrome shows an empty page.

What happens instead?
Chrome doesn't stop loading.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f37399e1cb91a70730938f61008142ce61a00ad6

commit f37399e1cb91a70730938f61008142ce61a00ad6
Author: horo <horo@chromium.org>
Date: Fri Mar 31 08:57:02 2017

Resolve preloadResponse of Navigation Preload even if the response body is empty.

BUG= 706765 
TEST=virtual/service-worker-navigation-preload-wpt/external/wpt/service-workers/service-worker/navigation-preload/empty-preload-response-body.https.html

Review-Url: https://codereview.chromium.org/2787783002
Cr-Commit-Position: refs/heads/master@{#461082}

[modify] https://crrev.com/f37399e1cb91a70730938f61008142ce61a00ad6/content/renderer/service_worker/service_worker_context_client.cc
[add] https://crrev.com/f37399e1cb91a70730938f61008142ce61a00ad6/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-preload/empty-preload-response-body.https.html
[add] https://crrev.com/f37399e1cb91a70730938f61008142ce61a00ad6/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-preload/resources/empty-preload-response-body-scope.html
[add] https://crrev.com/f37399e1cb91a70730938f61008142ce61a00ad6/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-preload/resources/empty-preload-response-body-worker.js
[modify] https://crrev.com/f37399e1cb91a70730938f61008142ce61a00ad6/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

Comment 2 Deleted

Comment 3 Deleted

Comment 4 Deleted

Comment 5 by horo@chromium.org, Apr 3 2017

Labels: -Pri-1 Pri-2
Upps, I commented to wrong crbug.
Deleted comments.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 3 2017

Labels: merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/432269484584455b81b68bb58d0a356c0da29456

commit 432269484584455b81b68bb58d0a356c0da29456
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Mon Apr 03 08:10:53 2017

Merge to M58: Resolve preloadResponse of Navigation Preload even if the response body is empty.

BUG= 706765 , 691503 
TEST=virtual/service-worker-navigation-preload-wpt/external/wpt/service-workers/service-worker/navigation-preload/empty-preload-response-body.https.html

Review-Url: https://codereview.chromium.org/2787783002
Cr-Commit-Position: refs/heads/master@{#461082}
(cherry picked from commit f37399e1cb91a70730938f61008142ce61a00ad6)

Review-Url: https://codereview.chromium.org/2791963002 .
Cr-Commit-Position: refs/branch-heads/3029@{#540}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/432269484584455b81b68bb58d0a356c0da29456/content/renderer/service_worker/service_worker_context_client.cc
[add] https://crrev.com/432269484584455b81b68bb58d0a356c0da29456/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-preload/empty-preload-response-body.https.html
[add] https://crrev.com/432269484584455b81b68bb58d0a356c0da29456/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-preload/resources/empty-preload-response-body-scope.html
[add] https://crrev.com/432269484584455b81b68bb58d0a356c0da29456/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-preload/resources/empty-preload-response-body-worker.js
[modify] https://crrev.com/432269484584455b81b68bb58d0a356c0da29456/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

Comment 7 by horo@chromium.org, Apr 3 2017 

I merged it to M58 because  issue 691503  depends on this issue.

Comment 8 by kavvaru@chromium.org, Apr 5 2017

Labels: TE-Verified-M58 TE-Verified-58.0.3029.54
Tested the issue on windows 7, Ubuntu 14.04 and Mac 10.12.3 using chrome version 58.0.3029.54 with the steps mentioned in comment #0.Observed Chrome shows an empty page after clicking on empty link.
Please find the attached screen cast for the same.

Adding TE-Verified labels.

Thanks,
706765.mp4
1.8 MB View Download
►

Sign in to add a comment