New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706758 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Dec 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature


Show other hotlists

Hotlists containing this issue:
style-dev-current


Sign in to add a comment

Schedule fewer sets for ruleset invalidations

Reported by r...@opera.com, Mar 30 2017

Issue description

In  issue 680549  we limited invalidation of type selectors to the selectors where there were no other simple selectors for which we had an invalidation set. So, for a stylesheet like this:

  div {}
  #id span {}

we would invalidate all divs, but only invalidate spans which are descendants of #id through scheduling the invalidation set for #id.

Still, we schedule invalidation sets both for ".a" and ".b" if we have a selector ".a .b" where we could have scheduled for ".a" only, avoiding invalidation of ".b" not inside ".a".

For selectors with more than one combinators like ".a #b .c" it might be better to schedule invalidations for "#b" instead of ".a". Also, if we have a selector ".a .b .c" and no elements in the document has a class ".b", not scheduling a set for ".a" could be an optimization.

See https://codereview.chromium.org/2683373003/ which was done before the changes for type selector and custom pseudo optimizations were done for  issue 680549 .

 
Labels: -Performance -Type-Bug Needs-Investigation Performance-Loading Type-Feature
Adding some labels to file this appropriately. I expect some POC will need to be built to test these ideas and converge on what exactly to do to move forward.

Comment 2 by shend@chromium.org, Sep 28 2017

Cc: shend@chromium.org
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 19 2017

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
The assigned owner "rune@opera.com" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by nainar@chromium.org, Oct 19 2017

Labels: Hotlist-Reassign-In-Nov
Owner: nainar@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Hotlist-Recharge-BouncingOwner -Hotlist-Reassign-In-Nov
Owner: futhark@chromium.org
Cc: futhark@chromium.org
Owner: ----
Status: Available (was: Assigned)
Labels: -Update-Monthly
Project Member

Comment 8 by sheriffbot@chromium.org, Dec 6

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)
Not likely to be fixed any time soon.

Sign in to add a comment