New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706756 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

Factory bundle directory structure clean-up

Project Member Reported by littlecvr@chromium.org, Mar 30 2017

Issue description

We'd like to clean-up the directory structure in a factory bundle so it is more intuitive to find resources in it:

factory_toolkit -> toolkit (simplify)
factory_setup -> setup (prevent confusion)
factory_shim -> factory_shim (hard to figure out better names than this,
                              and to make signer happy)
release -> release_image (easier to understand)
factory_test -> test_image (technically it's not factory, so again prevent confusion)
                            hwid, shopfloor -> hwid, shopfloor (no need to change)
factory_flow -> (will be deprecated soon.)
 
How about combine release_image and test_image to a single images/ folder?
How about make folder/file name and umpire resource name consistent?
Re #1: in that case we can't easily distinguish which image is which under the same folder. We'll have to match the file name or using other techniques to determine the type of the image.

Re #2: yeah, hungte and I were discussing this yesterday. I think we should:
  - Put the full hash in Umpire resource file name to prevent collisions.
    (Currently we put only 6 characters and collisions happened some times.)
  - Separate resources by folders such as release_images, test_images.
    (But note that I'm using singular forms in bundle but plural forms here because there may
     be more than one images in Umpire resource folder.)

Comment 4 by hungte@chromium.org, Mar 31 2017

See my draft implementation in https://chromium-review.googlesource.com/#/c/463127/

The goal is to put everything in one single folder so the name can be consistent (release_image, test_image) and each JSON file manages what bundles have.
You can find the type of payload by the prefix of its file name.

Importing and installing that is pretty fast (unless if you unfortunately need to import from compressed tar.xz...) so I think this is basically a good way to follow on.

Comment 5 by hungte@chromium.org, Mar 31 2017

Made some experiments for partition compression rate (grabbed a random signed recovery image and est image)

release_image_part3: 1.3G, gz: 541M, xz: 436M
test_image_part1: 1.2G, gz: 305M, xz: 217M
test_image_part3: 2.0G, gz: 989M, xz: 854M

XZ is better than I expected.


Comment 6 by hungte@chromium.org, Sep 26 2017

Status: Fixed (was: Started)
seems like most of goals are done, or pending on easy bundle creation.

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 8 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment