New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706728 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocking:
issue 645094


Previous locations:
v8:6147


Sign in to add a comment

GN support for aix AND changes for building v8 with GN on ppc/s390

Reported by r...@ca.ibm.com, Mar 24 2017

Issue description

GN currently fails to build on AIX. Also changes need to be made in v8 for it to support a GN build on ppc/s390.

The changes required would span repositories across both v8 and chromium.

 
Project: chromium
Moved issue v8:6147 to now be  issue chromium:706728 .
Labels: Proj-GN-Migration-V8
Blocking: 645094
Cc: fran...@chromium.org ofrobots@google.com machenb...@chromium.org
Components: Blink>JavaScript
Status: Available (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/367a04209fcb6c3700daee65511945da7dd31f20

commit 367a04209fcb6c3700daee65511945da7dd31f20
Author: rayb <rayb@ca.ibm.com>
Date: Wed May 10 04:55:56 2017

For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64(both LE and BE).

Also add support for host_byteorder logic which is used in the following v8 and icu issues respectively -
https://codereview.chromium.org/2809963004/
https://codereview.chromium.org/2812173002/

R=machenbach@chromium.org, dpranke@chromium.org, adamk@chromium.org
BUG= 706728 

Review-Url: https://codereview.chromium.org/2815453004
Cr-Commit-Position: refs/heads/master@{#470463}

[modify] https://crrev.com/367a04209fcb6c3700daee65511945da7dd31f20/build/config/BUILD.gn
[modify] https://crrev.com/367a04209fcb6c3700daee65511945da7dd31f20/build/config/BUILDCONFIG.gn
[add] https://crrev.com/367a04209fcb6c3700daee65511945da7dd31f20/build/config/aix/BUILD.gn
[modify] https://crrev.com/367a04209fcb6c3700daee65511945da7dd31f20/build/config/compiler/BUILD.gn
[modify] https://crrev.com/367a04209fcb6c3700daee65511945da7dd31f20/build/config/gcc/BUILD.gn
[add] https://crrev.com/367a04209fcb6c3700daee65511945da7dd31f20/build/config/get_host_byteorder.py
[add] https://crrev.com/367a04209fcb6c3700daee65511945da7dd31f20/build/config/host_byteorder.gni
[modify] https://crrev.com/367a04209fcb6c3700daee65511945da7dd31f20/build/config/sysroot.gni
[modify] https://crrev.com/367a04209fcb6c3700daee65511945da7dd31f20/build/dotfile_settings.gni
[add] https://crrev.com/367a04209fcb6c3700daee65511945da7dd31f20/build/toolchain/aix/BUILD.gn
[modify] https://crrev.com/367a04209fcb6c3700daee65511945da7dd31f20/build/toolchain/gcc_ar_wrapper.py
[modify] https://crrev.com/367a04209fcb6c3700daee65511945da7dd31f20/build/toolchain/gcc_toolchain.gni
[modify] https://crrev.com/367a04209fcb6c3700daee65511945da7dd31f20/build/toolchain/linux/BUILD.gn

Project Member

Comment 6 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/deps/icu.git/+/c5f212bac791598c3367d9318c3452b47944cf54

commit c5f212bac791598c3367d9318c3452b47944cf54
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon May 15 06:37:16 2017

For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64(both LE and BE).

Also add support for host_byteorder logic which is introduced in -
https://codereview.chromium.org/2815453004/

R=adamk@chromium.org, dpranke@chromium.org, machenbach@chromium.org
BUG= 706728 

Review-Url: https://codereview.chromium.org/2812173002 .

[modify] https://crrev.com/c5f212bac791598c3367d9318c3452b47944cf54/BUILD.gn

Is this done, or is something missing here?

Comment 8 by r...@ca.ibm.com, Jun 28 2017

Yes, we now have everything in place to support a v8 build using GN on the aforementioned platforms.
Cc: v8-ppc-p...@googlegroups.com jochen@chromium.org
 Issue 616024  has been merged into this issue.
Cc: v8-s390-...@googlegroups.com
 Issue 616023  has been merged into this issue.
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5e4dcf7476492d74139f726ba7978c6fc9a22f5b

commit 5e4dcf7476492d74139f726ba7978c6fc9a22f5b
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Oct 13 13:50:22 2017

[build] Switch ppc and s390 bots to gn

NOTRY=true

Bug:  chromium:706728 
Change-Id: I211212a922ed9f522cf735fbdce84ca5c70f93f9
Reviewed-on: https://chromium-review.googlesource.com/718705
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48546}
[modify] https://crrev.com/5e4dcf7476492d74139f726ba7978c6fc9a22f5b/infra/mb/mb_config.pyl

Status: Fixed (was: Available)

Sign in to add a comment