New issue
Advanced search Search tips

Issue 706725 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 696356



Sign in to add a comment

Roll FreeType

Project Member Reported by drott@chromium.org, Mar 30 2017

Issue description

Addressing windows build failure under Clang and LLP64

For more details, see
https://savannah.nongnu.org/bugs/index.php?50560


 

Comment 2 by js...@chromium.org, Mar 30 2017

Cc: js...@chromium.org
This one (fixed today) is also needed for a better variable font support (HVAR/MVAR handling bug in FreeType). 

https://savannah.nongnu.org/bugs/index.php?50678
  

See https://github.com/fonttools/fonttools/issues/901

Comment 3 by drott@chromium.org, Mar 31 2017

Re #1, can you elaborate a bit around what we should be careful with? Thanks, Ben.

Comment 4 by bungeman@google.com, Mar 31 2017

http://savannah.nongnu.org/bugs/?50470 is interesting and has a long history. It reverts a change made in 2011. This 2011 change has been historically patched out in debian distributions (and a number of others) for years, but recently they didn't patch it out. I'm just saying we need to be careful rolling past it because there is a good chance it will affect a bunch of layout tests. 
Blocking: 696356

Comment 6 by drott@chromium.org, Apr 5 2017

Cc: agoode@chromium.org
Test CL up https://codereview.chromium.org/2786013002 and passing the CQ so far. agoode@, can you confirm this contains the commits you need for  issue 696356 ?
bcc74f4 '[truetype] Allow linear scaling for unhinted rendering (#50470).'

is the one  issue 696356  wants, and that's in this roll.
Is this roll for the Chrome OS build? Linux uses the system FreeType, correct?
Initial tests of the patch in Fedora have led to line spacing issues:
https://bugzilla.redhat.com/show_bug.cgi?id=1437999#c9

Not sure if its Gnome-specific code that has problems, but there may definitely be issues to watch out for.
This roll is for Chromium itself, which uses an own FreeType for layout tests and otherwise uses system FreeType. Which may change though, and we might decide to bundle FreeType on Linux as well. 

Comment 12 by drott@chromium.org, Apr 10 2017

Cc: thestig@chromium.org
Status: Fixed (was: Started)
Lei, fyi, we rolled to 5a3490e054bda without any pixel differences in our layout tests.

Project Member

Comment 13 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66ba5e7e910565510efe941cee9c1ba3c2db4f0e

commit 66ba5e7e910565510efe941cee9c1ba3c2db4f0e
Author: mkwst <mkwst@chromium.org>
Date: Mon Apr 10 09:26:15 2017

Revert of Roll FreeType to 5a3490e054bda8a318ebde482c7fb30213cab3d9 (patchset #3 id:40001 of https://codereview.chromium.org/2786013002/ )

Reason for revert:
Many CSS layout test failures, starting in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/25380.

I'm guessing that rolling FreeType in https://codereview.chromium.org/2786013002/ might have caused these differences, as it's the only patch in the diff that looks relevant (and because the CQ didn't run layout tests, which is unfortunate: not sure who's responsible for the `analyze` step?).

BUG= 709918 

Original issue's description:
> Roll FreeType to 5a3490e054bda8a318ebde482c7fb30213cab3d9
>
> https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/66725768cdf758..5a3490e054bda8
>
> Addresses Clang on Windows LLP64 build failure.
>
> BUG= 706725 
>
> Review-Url: https://codereview.chromium.org/2786013002
> Cr-Commit-Position: refs/heads/master@{#463187}
> Committed: https://chromium.googlesource.com/chromium/src/+/395ac4809e4a98b8745753caf2f3f9015b3ca1f1

TBR=bungeman@chromium.org,drott@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 706725 

Review-Url: https://codereview.chromium.org/2810643002
Cr-Commit-Position: refs/heads/master@{#463202}

[modify] https://crrev.com/66ba5e7e910565510efe941cee9c1ba3c2db4f0e/DEPS
[modify] https://crrev.com/66ba5e7e910565510efe941cee9c1ba3c2db4f0e/third_party/freetype/README.chromium
[modify] https://crrev.com/66ba5e7e910565510efe941cee9c1ba3c2db4f0e/third_party/freetype/include/freetype-custom-config/ftoption.h

Comment 14 by drott@chromium.org, Apr 10 2017

Re #12, correction, we did have layout test differences, our CQ did not trigger layout testing. Looking into it in https://codereview.chromium.org/2808793002

Comment 15 by drott@chromium.org, Apr 10 2017

Status: Started (was: Fixed)
I uploaded https://pdfium-review.googlesource.com/c/4011/ but trybots are not running at the moment. Locally, a bunch of pixel based tests fail. I haven't looked at the differences.
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d6ca52da9023346a99527fc6803ef26538f4b03

commit 8d6ca52da9023346a99527fc6803ef26538f4b03
Author: drott <drott@chromium.org>
Date: Tue Apr 11 12:39:36 2017

Reland: Roll FreeType to 5a3490e054bda8a318ebde482c7fb30213cab3d9

https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/66725768cdf758..5a3490e054bda8

Addresses Clang on Windows LLP64 build failure.
Touch whitespace.txt to trigger layout tests.

TBR because previous CL was reviewed.

BUG= 706725 
TBR=bungeman

Review-Url: https://codereview.chromium.org/2808793002
Cr-Commit-Position: refs/heads/master@{#463604}

[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/DEPS
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css1/color_and_background/background_attachment-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css2.1/t0602-c13-inheritance-00-e-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css2.1/t100801-c544-valgn-02-d-agi-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css2.1/t100801-c544-valgn-03-d-agi-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css2.1/t100801-c544-valgn-04-d-agi-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/css3-modsel-35-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/font-feature-settings-rendering-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/html/css3-modsel-30-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/html/css3-modsel-34-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/html/css3-modsel-35-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/html/css3-modsel-7-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/html/css3-modsel-75-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/html/css3-modsel-75b-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/html/css3-modsel-79-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/html/css3-modsel-8-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/html/css3-modsel-80-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xhtml/css3-modsel-30-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xhtml/css3-modsel-34-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xhtml/css3-modsel-35-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xhtml/css3-modsel-7-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xhtml/css3-modsel-75-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xhtml/css3-modsel-75b-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xhtml/css3-modsel-79-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xhtml/css3-modsel-8-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xhtml/css3-modsel-80-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xml/css3-modsel-30-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xml/css3-modsel-34-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xml/css3-modsel-35-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xml/css3-modsel-7-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xml/css3-modsel-75-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xml/css3-modsel-75b-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xml/css3-modsel-79-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xml/css3-modsel-8-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/css3/selectors3/xml/css3-modsel-80-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/backgrounds/body-generated-image-propagated-to-root-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/block/float/intruding-painted-twice-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-huge-assert-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/css-generated-content/before-with-first-letter-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/css/first-letter-detach-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/css/font-face-opentype-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/forms/button/button-inner-block-reuse-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/replaced/absolute-position-percentage-height-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/replaced/image-resize-width-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/ruby/base-shorter-than-text-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/selectors/034-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/table/border-collapsing/border-collapsing-head-foot-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/table/rtl-cell-display-none-assert-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text-autosizing/tables/table-cell-inflation-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/atsui-kerning-and-ligatures-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/atsui-multiple-renderers-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/atsui-small-caps-punctuation-size-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/atsui-spacing-features-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/chromium-linux-fontconfig-renderstyle-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/font-initial-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/international/003-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/international/bold-bengali-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/justify-ideograph-complex-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/justify-ideograph-simple-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/justify-ideograph-vertical-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/midword-break-before-surrogate-pair-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/should-use-atsui-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/sub-pixel/text-scaling-ltr-expected.txt
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/sub-pixel/text-scaling-pixel-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/sub-pixel/text-scaling-rtl-expected.txt
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/sub-pixel/text-scaling-vertical-expected.txt
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/sub-pixel/text-scaling-webfont-expected.txt
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/text/word-break-soft-hyphen-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/writing-mode/japanese-ruby-vertical-lr-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/writing-mode/japanese-ruby-vertical-rl-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fast/writing-mode/vertical-align-table-baseline-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fonts/monospace-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fonts/sans-serif-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/fonts/serif-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-image-shape-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/media/track/track-cue-rendering-vertical-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-intro-01-t-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-intro-03-b-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-intro-04-t-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/svg/custom/font-face-cascade-order-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/svg/text/bbox-with-glyph-overflow-zoomed-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/svg/text/bbox-with-glyph-overflow-zoomed-expected.txt
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-zoom-coords-expected.txt
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug139524-2-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug5838-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/transforms/transforms-with-zoom-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-shape-expected.png
[add] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/css1/color_and_background/background_attachment-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200/fast/hidpi/static/data-suggestion-picker-appearance-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200/fast/hidpi/static/popup-menu-appearance-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200withzoom/fast/hidpi/static/data-suggestion-picker-appearance-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200withzoom/fast/hidpi/static/popup-menu-appearance-expected.png
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/WebKit/LayoutTests/whitespace.txt
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/freetype/README.chromium
[modify] https://crrev.com/8d6ca52da9023346a99527fc6803ef26538f4b03/third_party/freetype/include/freetype-custom-config/ftoption.h

Comment 18 by e...@chromium.org, Apr 18 2017

Status: Fixed (was: Started)
Closing now that the roll has relanded.

Comment 19 by drott@chromium.org, Apr 19 2017

Re #16, I've only seen the capital A having a minor pixel difference, everything else was okay. So the Chromium FreeType roll is complete. It would be great if PDFium could sync to the same version.

Sign in to add a comment