New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 706714 link

Starred by 1 user
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Closed: Mar 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [DevTools] Unnecessary Add button gets enabled without entering path into textbox.

Reported by db...@etouch.net, Mar 30 2017 
Version: 59.0.3056.0 abd1360936725f296381ceb3c194307a29137c53-refs/heads/master@{#460603}-32/64 bit
OS: Windows (7,8,8.1,10),Mac OS X(10.11.6,10.12.1)

What steps will reproduce the problem?
(1) Launch Chrome, open devtools on NTP and press F1 key to open Settings of devtools
(2) Click on Workspace and add any folder, click on Add button seen against Excluded folder 
(3) Type any keyword into text box and click on Add button, again click on Add and observe.

Actual: Unnecessary Add button gets enabled without entering path into textbox.

Expected: Add button should not gets enabled without entering path into textbox.

This is regression issue, broken in ‘M 59’ and will soon update other info :

Good build:59.0.3055.0
Bad build: 59.0.3056.0
Actual_Add.mp4
766 KB View Download

Comment 1 by rbasuvula@chromium.org, Mar 30 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision OS-Linux
Owner: lushnikov@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3055.0 (Revision:460255).
Bad build:59.0.3056.0 (Revision:460603).

You are probably looking for a change made after 460511 (known good), but no later than 460512 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/c1036c002f34914a521b631d57b8c7bdd01f4ce3..7a9ca6839f01ad26a41816f4d91a404a0ad49a62

From the CL above, assigning the issue to the concern owner

@lushnikov: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:https://codereview.chromium.org/2744553003
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #59.0.3054.0
Its look similar to  issue 706706

Comment 2 by msrchandra@chromium.org, Mar 30 2017

Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be9a0b75fbcadccacec188737715ff16c05e7f68

commit be9a0b75fbcadccacec188737715ff16c05e7f68
Author: lushnikov <lushnikov@chromium.org>
Date: Fri Mar 31 01:39:01 2017

DevTools: fix adding excluded folder from settings screen

This patch makes sure excluded folders in settings screen are initialized
regardless of persistence2.0 experiment.

BUG= 706706 ,  706714 
R=dgozman

Review-Url: https://codereview.chromium.org/2790743002
Cr-Commit-Position: refs/heads/master@{#460983}

[modify] https://crrev.com/be9a0b75fbcadccacec188737715ff16c05e7f68/third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js

Comment 4 by lushnikov@chromium.org, Mar 31 2017

Status: Fixed (was: Assigned)

Comment 5 by sureshkumari@chromium.org, Apr 4 2017

Labels: TE-Verified-59.0.3061.3 TE-Verified-M59
Tested the issue on Windows-7,Mac 10.12.3 using Chrome version 59.0.3061.3 as per the comment #0

Observed that the fix is working as expected.Hence adding the verified labels.

Note: Verified the issue on Ubuntu 14.04 using chrome version #59.0.3061.0 as the linux chrome build #59.0.3061.3 got failed(Issue id: 708077)

Please find the attached screen cast for reference.

Thanks.
706714.mp4
865 KB View Download
►

Sign in to add a comment