New issue
Advanced search Search tips

Issue 706700 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 604105



Sign in to add a comment

chooser: Deselect disabled items.

Project Member Reported by ortuno@chromium.org, Mar 30 2017

Issue description

Should we? I think it's pretty confusing when the item is clearly still selected but for some reason I can't click the pair button. See screenshot attached.
 
disabled row.png
562 KB View Download
Yes please.
Cc: juncai@chromium.org
Cc: -juncai@chromium.org
Owner: juncai@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbe06a040450d03cda19e3fcec5e4d89948c7514

commit bbe06a040450d03cda19e3fcec5e4d89948c7514
Author: juncai <juncai@chromium.org>
Date: Wed Apr 05 19:10:54 2017

Deselect disabled item for ItemChooserDialog on Android

When a selected item on ItemChooserDialog is disabled, it needs to be
deselected.

BUG=706700

Review-Url: https://codereview.chromium.org/2794283004
Cr-Commit-Position: refs/heads/master@{#462167}

[modify] https://crrev.com/bbe06a040450d03cda19e3fcec5e4d89948c7514/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java
[modify] https://crrev.com/bbe06a040450d03cda19e3fcec5e4d89948c7514/chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java

Status: Fixed (was: Started)
Cc: juncai@chromium.org
Labels: Hotlist-GoodFirstBug
Owner: ----
Status: Available (was: Fixed)
Thanks for the initial code juncai!

On the adapter side the item is indeed marked as no longer selected but as far as the ListView is concerned the item is still highlighted.

The screenshot looks exactly like the one in #1.

Either of the following two functions should be called in setEnabled[1]

1. mListView.clearSelection()[1]
2. mListView.setItemChecked()[2]

setItemChecked is preferred so that in the future implementing multiple device selection is easier.
Project Member

Comment 8 by sheriffbot@chromium.org, Apr 6 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment