Users should be able to clearly see their focus and activate buttons using only a keyboard.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4485d3c0dda30d0355fc7086bba089555e604f7a commit 4485d3c0dda30d0355fc7086bba089555e604f7a Author: einbinder <einbinder@chromium.org> Date: Fri Mar 31 03:17:03 2017 DevTools: Focus indicators in Toolbars This patch adds a light gray background to buttons and comboboxes. It adds a default focus ring to checkboxes. These only appear when an item is focused via keyboard. http://i.imgur.com/E6j7851.gif BUG= 706699 Review-Url: https://codereview.chromium.org/2741863002 Cr-Commit-Position: refs/heads/master@{#461007} [modify] https://crrev.com/4485d3c0dda30d0355fc7086bba089555e604f7a/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js [modify] https://crrev.com/4485d3c0dda30d0355fc7086bba089555e604f7a/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js [modify] https://crrev.com/4485d3c0dda30d0355fc7086bba089555e604f7a/third_party/WebKit/Source/devtools/front_end/ui/checkboxTextLabel.css [modify] https://crrev.com/4485d3c0dda30d0355fc7086bba089555e604f7a/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/048c6e39319b24da880452acd1f96ea8c78e515d commit 048c6e39319b24da880452acd1f96ea8c78e515d Author: einbinder <einbinder@chromium.org> Date: Fri Mar 31 05:11:11 2017 DevTools: ViewContainer shouldn't be a tab stop ViewContainers had tabIndex=0, so when tabbing around devtools they recieved focus for no good reason. BUG= 706699 Review-Url: https://codereview.chromium.org/2790813002 Cr-Commit-Position: refs/heads/master@{#461046} [add] https://crrev.com/048c6e39319b24da880452acd1f96ea8c78e515d/third_party/WebKit/LayoutTests/inspector/elements/elements-tab-stops-expected.txt [add] https://crrev.com/048c6e39319b24da880452acd1f96ea8c78e515d/third_party/WebKit/LayoutTests/inspector/elements/elements-tab-stops.html [modify] https://crrev.com/048c6e39319b24da880452acd1f96ea8c78e515d/third_party/WebKit/Source/devtools/front_end/ui/View.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93cf8ced501ad85664fa80e69610621b69b6dd09 commit 93cf8ced501ad85664fa80e69610621b69b6dd09 Author: einbinder <einbinder@chromium.org> Date: Fri Mar 31 05:51:59 2017 DevTools: Allow tabbing in and out of TextPrompt TextPrompt was handling tab events even if there was no autocomplete. BUG= 706699 , 668161 Review-Url: https://codereview.chromium.org/2786003002 Cr-Commit-Position: refs/heads/master@{#461052} [modify] https://crrev.com/93cf8ced501ad85664fa80e69610621b69b6dd09/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c86b1f8a0db09846e20cf28a43cd4ead737e8c3c commit c86b1f8a0db09846e20cf28a43cd4ead737e8c3c Author: einbinder <einbinder@chromium.org> Date: Mon Apr 03 06:36:32 2017 DevTools: Allow ToolbarMenuButtons to be trigged via keyboard ToolbarMenuButtons were checking for a mousedown event before a click event. Pressing enter when the button is focused only sends a click event. BUG= 706699 Review-Url: https://codereview.chromium.org/2785993002 Cr-Commit-Position: refs/heads/master@{#461376} [modify] https://crrev.com/c86b1f8a0db09846e20cf28a43cd4ead737e8c3c/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1465b8cd7572282cebd6f05d226cc358cef80aec commit 1465b8cd7572282cebd6f05d226cc358cef80aec Author: einbinder <einbinder@chromium.org> Date: Fri Apr 28 22:26:22 2017 DevTools: Don't focus layers panel when it is shown The layers panel ends up stealing focus and disrupting keyboard navigation. BUG= 706699 Review-Url: https://codereview.chromium.org/2819863004 Cr-Commit-Position: refs/heads/master@{#468155} [modify] https://crrev.com/1465b8cd7572282cebd6f05d226cc358cef80aec/third_party/WebKit/Source/devtools/front_end/layers/LayersPanel.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7edef8fcbb3ed857191ff14296527fe918ade889 commit 7edef8fcbb3ed857191ff14296527fe918ade889 Author: einbinder <einbinder@chromium.org> Date: Mon May 22 21:42:33 2017 DevTools: Navigate TabbedPane with arrow keys BUG= 706699 Review-Url: https://codereview.chromium.org/2805593002 Cr-Commit-Position: refs/heads/master@{#473710} [add] https://crrev.com/7edef8fcbb3ed857191ff14296527fe918ade889/third_party/WebKit/LayoutTests/http/tests/inspector-unit/tabbed-pane-expected.txt [add] https://crrev.com/7edef8fcbb3ed857191ff14296527fe918ade889/third_party/WebKit/LayoutTests/http/tests/inspector-unit/tabbed-pane.js [modify] https://crrev.com/7edef8fcbb3ed857191ff14296527fe918ade889/third_party/WebKit/LayoutTests/inspector/elements/elements-tab-stops-expected.txt [modify] https://crrev.com/7edef8fcbb3ed857191ff14296527fe918ade889/third_party/WebKit/LayoutTests/inspector/elements/elements-tab-stops.html [modify] https://crrev.com/7edef8fcbb3ed857191ff14296527fe918ade889/third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js [modify] https://crrev.com/7edef8fcbb3ed857191ff14296527fe918ade889/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js [modify] https://crrev.com/7edef8fcbb3ed857191ff14296527fe918ade889/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js [modify] https://crrev.com/7edef8fcbb3ed857191ff14296527fe918ade889/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js [modify] https://crrev.com/7edef8fcbb3ed857191ff14296527fe918ade889/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js [modify] https://crrev.com/7edef8fcbb3ed857191ff14296527fe918ade889/third_party/WebKit/Source/devtools/front_end/ui/tabbedPane.css
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e03a5108e63adb7338835d179c27e41c834a6e7 commit 9e03a5108e63adb7338835d179c27e41c834a6e7 Author: einbinder <einbinder@chromium.org> Date: Thu May 25 03:46:53 2017 DevTools: Add focus indicator to vertical tabbed pane BUG= 706699 Review-Url: https://codereview.chromium.org/2902593002 Cr-Commit-Position: refs/heads/master@{#474544} [modify] https://crrev.com/9e03a5108e63adb7338835d179c27e41c834a6e7/third_party/WebKit/Source/devtools/front_end/ui/tabbedPane.css
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8460a371d21057323a77b7acedc5bf1f73674020 commit 8460a371d21057323a77b7acedc5bf1f73674020 Author: einbinder <einbinder@chromium.org> Date: Wed Jun 07 04:16:33 2017 DevTools: Add keyboard focus highlight when focusing window This adds data-keyboard-focus when the user focuses devtools by keyboard or focus wraps around the devtools page. BUG= 706699 Review-Url: https://codereview.chromium.org/2921363002 Cr-Commit-Position: refs/heads/master@{#477544} [modify] https://crrev.com/8460a371d21057323a77b7acedc5bf1f73674020/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
Bulk closing low-priority issues with no activity. Please re-file and refer to the closed issue if it's essential to fix.
Comment 1 by einbinder@chromium.org
, Mar 30 2017