New issue
Advanced search Search tips

Issue 706683 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

"Recent tabs" should start from the top

Project Member Reported by klo...@chromium.org, Mar 30 2017

Issue description

Make sure in Chrome Home mode.

Open "Recent tabs".

The content doesn't start from the top.
 

Comment 1 by k...@chromium.org, Mar 30 2017

Cc: mdjones@chromium.org twelling...@chromium.org
Components: UI>Browser>Mobile>NavPanel
Labels: -Restrict-View-Google -Hotlist-Home-needs-triage Hotlist-Chrome-Home
Owner: ----
Status: Available (was: Assigned)
Owner: twelling...@chromium.org
Status: Started (was: Available)
Screenshots from in-flight patch
Status: Fixed (was: Started)
Status: Started (was: Fixed)
Native pages need padding added to the bottom when Chrome Home is enabled.
Issue 719701 has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/475dadd52b797253bb2563c09112a31f7ce1078f

commit 475dadd52b797253bb2563c09112a31f7ce1078f
Author: twellington <twellington@chromium.org>
Date: Tue May 09 04:06:52 2017

[Home] Fix bottom offset for native pages

When the toolbar is at the bottom of the screen, native pages need
padding or margin on the bottom so that all of their content is
visible.

BUG= 706683 

Review-Url: https://codereview.chromium.org/2867183002
Cr-Commit-Position: refs/heads/master@{#470181}

[modify] https://crrev.com/475dadd52b797253bb2563c09112a31f7ce1078f/chrome/android/java/src/org/chromium/chrome/browser/BasicNativePage.java
[modify] https://crrev.com/475dadd52b797253bb2563c09112a31f7ce1078f/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in Chrome:60.0.3095.4 Device:Samsung Galaxy S4 (SCH-I545)/LRX22C

Sign in to add a comment