Factory: Change pbzip2 to lbzip2 |
|||||
Issue descriptionCurrently factory server docker image needs to get pre-built pbzip2 that alpine does not have. However, alpine does have lbzip2. And in fact lbzip2 is directly supported by GNU tar, if bzip2 is not found on system. Maybe we should consider either one of the solution below: 1. always use lbzip2 in factory code 2. find lbzip2 and fallback to pbzip2 3. contribute to alpine and add a pbzip2 package
,
Mar 30 2017
or, symlink lbzip2 as pbzip2 in docker image <evil>.
,
Mar 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/80e2302ac029d6b9e90752ea81a393107849ee0e commit 80e2302ac029d6b9e90752ea81a393107849ee0e Author: Hung-Te Lin <hungte@chromium.org> Date: Thu Mar 30 06:42:30 2017 docker: Use lbzip2 package to replace "pbzip2 from source". lbzip2 and pbzip2 are most identical (in how we use it) that we can just use a symlink and get rid of dirty build hacks. BUG= chromium:706678 TEST=./cros_docker.sh build; # launch dome to start a new umpire instance ./cros_docker.sh umpire shell # lbzip2; pbzip2; # both works Change-Id: If45c2399bc4dcfc84df0a3379123aa9fc5469101 Reviewed-on: https://chromium-review.googlesource.com/462876 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Trybot-Ready: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/80e2302ac029d6b9e90752ea81a393107849ee0e/py/umpire/docker/Dockerfile.deps [modify] https://crrev.com/80e2302ac029d6b9e90752ea81a393107849ee0e/setup/Dockerfile [modify] https://crrev.com/80e2302ac029d6b9e90752ea81a393107849ee0e/setup/cros_docker.sh
,
Mar 30 2017
symlink is good enough :)
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hungte@chromium.org
, Mar 30 2017