ImageCapture: takePhoto is not functioning in some devices
Reported by
infotoo...@gmail.com,
Mar 30 2017
|
|||||||||||
Issue descriptionSteps to reproduce the problem: Using samesung note 2 1. use imageCapture.setOptions to set photo resolution 2. call imageCapture.takePhoto 2. the camera is stopped, and no image is captured What is the expected behavior? What went wrong? https://chromium.googlesource.com/chromium/src.git/+/56.0.2924.122/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java#641 setParameters is called immediately after takePicture, before the CrPictureCallback.Doing this will cancel the takePicture action in some devices Did this work before? No Does this work in other browsers? Yes Chrome version: 56.0.2924.87 Channel: stable OS Version: 4.4.2 Flash Version:
,
Apr 11 2017
With Samsung S4, takePhoto return image with preview size instead of picture size
,
Apr 12 2017
,
Apr 14 2017
,
Apr 14 2017
I got a fix but want to get my hands on a Samsung S4/note 2 to verify it, stay tuned!
,
Apr 17 2017
Ongoing CL: https://codereview.chromium.org/2826453002/
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6c1b9d6d636b72d9b88cb2ab5723be4770d006f commit a6c1b9d6d636b72d9b88cb2ab5723be4770d006f Author: mcasas <mcasas@chromium.org> Date: Tue Apr 18 02:50:54 2017 Image Capture Android: only restore preview parameters after photo is taken This CL introduces a member variable |mPreviewParameters| to cache the preview capture parameters in order to restore them after a picture is being taken and, more importantly (see bug), delays restoring those parameters until after the picture is actually taken. While debugging these changes with a Nexus 7 and a Galaxy Note 2 7100, I reckoned that the Nexus 7 is very delicate so I added some try-catches and avoided setting the picture resolution if not truly set by the user (== use preview size). BUG= 706674 Review-Url: https://codereview.chromium.org/2826453002 Cr-Commit-Position: refs/heads/master@{#465118} [modify] https://crrev.com/a6c1b9d6d636b72d9b88cb2ab5723be4770d006f/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
,
Apr 18 2017
,
Apr 18 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6f7ea59c5633ef2dc2708448487585a7cfdf23b commit a6f7ea59c5633ef2dc2708448487585a7cfdf23b Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Tue Apr 18 17:19:49 2017 Image Capture Android: only restore preview parameters after photo is taken This CL introduces a member variable |mPreviewParameters| to cache the preview capture parameters in order to restore them after a picture is being taken and, more importantly (see bug), delays restoring those parameters until after the picture is actually taken. While debugging these changes with a Nexus 7 and a Galaxy Note 2 7100, I reckoned that the Nexus 7 is very delicate so I added some try-catches and avoided setting the picture resolution if not truly set by the user (== use preview size). BUG= 706674 Review-Url: https://codereview.chromium.org/2826453002 Cr-Commit-Position: refs/heads/master@{#465118} (cherry picked from commit a6c1b9d6d636b72d9b88cb2ab5723be4770d006f) Review-Url: https://codereview.chromium.org/2821343002 . Cr-Commit-Position: refs/branch-heads/3071@{#35} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/a6f7ea59c5633ef2dc2708448487585a7cfdf23b/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
,
Apr 18 2017
infotoo.hk@gmail.com, I'm seeing this issue as fixed on my end but could you verify as well using a Canary plz -- when #7: r465118 lands which should be today (probably 60.0.3075.0, [1] will say for sure). [1] https://storage.googleapis.com/chromium-find-releases-static/index.html#r465118 |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by candr...@chromium.org
, Mar 31 2017