[TTS] ContextualSearchTapEventTest#testTextTapFollowedByNonTextTap is flaky |
|||
Issue descriptionLooks like Matt's awesome test isn't actually being run, because I tried updating it and noticed it's failing even on Master. I'm updating tests as part of the tap-text-extract refactoring so I'll figure this out too. C 113.465s Main [FAIL] org.chromium.chrome.browser.contextualsearch.ContextualSearchTapEventTest#testTextTapFollowedByNonTextTap: C 113.465s Main junit.framework.AssertionFailedError: Tab never selected/initialized. C 113.466s Main at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:79) C 113.466s Main at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:117) C 113.466s Main at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:138) C 113.466s Main at org.chromium.chrome.test.ChromeActivityTestCaseBase.startMainActivityFromIntent(ChromeActivityTestCaseBase.java:471) C 113.466s Main at org.chromium.chrome.test.ChromeActivityTestCaseBase.startMainActivityWithURL(ChromeActivityTestCaseBase.java:435) C 113.466s Main at org.chromium.chrome.browser.contextualsearch.ContextualSearchTapEventTest.startMainActivity(ContextualSearchTapEventTest.java:243) C 113.466s Main at org.chromium.chrome.test.ChromeActivityTestCaseBase.setUp(ChromeActivityTestCaseBase.java:150) C 113.466s Main at org.chromium.chrome.browser.contextualsearch.ContextualSearchTapEventTest.setUp(ContextualSearchTapEventTest.java:226) C 113.466s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) C 113.466s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) C 113.466s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 113.466s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 113.467s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555) C 113.467s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879) C 113.467s Main ******************************************************************************** C 113.467s Main Summary C 113.467s Main ******************************************************************************** C 113.467s Main [==========] 1 test ran. C 113.467s Main [ PASSED ] 0 tests. C 113.467s Main [ FAILED ] 1 test, listed below: C 113.467s Main [ FAILED ] org.chromium.chrome.browser.contextualsearch.ContextualSearchTapEventTest#testTextTapFollowedByNonTextTap
,
Apr 5 2017
@RetryOnFailure seems to mostly keep it green but it did recently hit 3 failures on the browser_side_navigation_chrome_public_test_apk (chromium.android/Marshmallow 64 bit Tester) causing redness - https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=org.chromium.chrome.browser.contextualsearch.ContextualSearchTapEventTest%23testTextTapFollowedByNonTextTap&testType=browser_side_navigation_chrome_public_test_apk
,
Apr 5 2017
For that latest failure, mockTapEmptySpace probably just needs to be run on the UI thread like mockTapText: https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java?rcl=74849bc2fdb3ebde47584620b9a1c8da0c72bcd0&l=211
,
Apr 6 2017
This just flaked again on Marshmallow 64 bit Tester. https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/10972 I'm disabling the test in the following CL: https://codereview.chromium.org/2803053002
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2dd856b0ab41f39283d59a90ed4569eb5e9f80a9 commit 2dd856b0ab41f39283d59a90ed4569eb5e9f80a9 Author: peter <peter@chromium.org> Date: Thu Apr 06 16:38:26 2017 Disable ContextualSearchTapEventTest#testTextTapFollowedByNonTextTap It's still flaky, despite the @RetryOnFailure annotation. TBR=mdjones BUG= 706663 Review-Url: https://codereview.chromium.org/2803053002 Cr-Commit-Position: refs/heads/master@{#462504} [modify] https://crrev.com/2dd856b0ab41f39283d59a90ed4569eb5e9f80a9/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java
,
Apr 10 2017
I'll take another look.
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/954690e8953632f30cb944e78340bb8900830566 commit 954690e8953632f30cb944e78340bb8900830566 Author: donnd <donnd@chromium.org> Date: Thu Apr 13 20:58:43 2017 [TTS] Update testTextTapFollowedByNonTextTap. This test has been flaky and was disabled, reenbling with a change to call mockTapEmptySpace() on the UI thread. BUG= 706663 Review-Url: https://codereview.chromium.org/2816053002 Cr-Commit-Position: refs/heads/master@{#464543} [modify] https://crrev.com/954690e8953632f30cb944e78340bb8900830566/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java
,
Apr 14 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by donnd@chromium.org
, Mar 30 2017