sysmon should force a metric flush early |
||||
Issue descriptionCurrently, sysmon flushes metrics normally, which means that it will flush metrics for the first time a few minutes after starting. If there is a bug that causes sysmon to crash during flushing, it won't be detected by our unstable service detection during prod push, which checks if a service stays up for a minute or so after being started. We should force a flush early after sysmon starts to weed out errors during flushing.
,
Aug 15 2017
,
Nov 22 2017
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ddba434b6c0719187677daca1f014cea2c1e87c1 commit ddba434b6c0719187677daca1f014cea2c1e87c1 Author: Allen Li <ayatane@chromium.org> Date: Tue Nov 28 04:08:04 2017 sysmon: Dont sleep on start I dont think theres any value in this, as sysmon does not have the potential to saturate the network like, say, git fetch. This makes sysmon fail fast if there are any bugs, which can be detected during push. BUG= chromium:706655 TEST=None Change-Id: I70c34f1d34884823a3554acf2d89730fa1b95d27 Reviewed-on: https://chromium-review.googlesource.com/784312 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Shuqian Zhao <shuqianz@chromium.org> [modify] https://crrev.com/ddba434b6c0719187677daca1f014cea2c1e87c1/scripts/sysmon/mainlib.py
,
Dec 28 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ayatane@chromium.org
, Jun 30 2017