New issue
Advanced search Search tips

Issue 706650 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 691135



Sign in to add a comment

Add tests to ensure that Chrome proxy headers are correctly set

Project Member Reported by tbansal@chromium.org, Mar 30 2017 
Add tests to ensure that Chrome proxy headers are correctly set. Few things that we want to ensure:
(1) Chrome-Proxy header is sent if and only if the request is served by data saver proxy.
(2) Chrome-Proxy-ECT header is sent if and only if the request is served by data saver proxy.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd690b0bbec9e12f8554673c5501a36e4ec2d7b8

commit bd690b0bbec9e12f8554673c5501a36e4ec2d7b8
Author: tbansal <tbansal@chromium.org>
Date: Thu Mar 30 01:00:43 2017

DRP: Add check that ECT header is present when CPAT header is present.

Add a (d)check in data reduction proxy (DRP) code which verifies that
if the CPAT header is present in the request headers, then ECT header
must be present too.

Other checks added: e.g., chrome-proxy header should only
be sent when the resolved proxy is a data saver proxy.

Finally, the CL also modifies few unittests to avoid tripping the
DCHECKs.

BUG= 706650 

Review-Url: https://codereview.chromium.org/2771413004
Cr-Commit-Position: refs/heads/master@{#460609}

[modify] https://crrev.com/bd690b0bbec9e12f8554673c5501a36e4ec2d7b8/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
[modify] https://crrev.com/bd690b0bbec9e12f8554673c5501a36e4ec2d7b8/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc

Comment 2 by tbansal@chromium.org, Mar 30 2017

Status: Fixed (was: Started)
►

Sign in to add a comment