New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 706647 link

Starred by 2 users
Status: Fixed
Owner:
█ xlai@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Shrink OffscreenCanvas gpu pixel tests dimension

Project Member Reported by xlai@chromium.org, Mar 30 2017 
Nexus 5 is failing due to dimension of tests. Need to make the 
test even smaller.

https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%205%29/builds/4827

Traceback (most recent call last):
    _RunGpuTest at content/test/gpu/gpu_tests/gpu_integration_test.py:73
      self.RunActualGpuTest(url, *args)
    RunActualGpuTest at content/test/gpu/gpu_tests/pixel_integration_test.py:147
      page.test_rect[2] * dpr, page.test_rect[3] * dpr)
    Crop at third_party/catapult/telemetry/telemetry/util/image_util.py:111
      return impl.Crop(image, left, top, width, height)
    Crop at third_party/catapult/telemetry/telemetry/internal/image_processing/image_util_numpy_impl.py:155
      raise ValueError('Invalid dimensions')
  ValueError: Invalid dimensions
  
  Locals:
    height     : 600
    image      : array([[[  0, 128,   0],
          [  0, 128,   0],
          [  0, 128,   0],
          ..., 
          [255, 255, 255],
          [255, 255, 255],
          [255, 255, 255]],
  
         [[  0, 128,   0],
          [  0, 128,   0],
          [  0, 128,   0],
          ..., 
          [255, 255, 255],
          [255, 255, 255],
          [255, 255, 255]],
  
         [[  0, 128,   0],
          [  0, 128,   0],
          [  0, 128,   0],
          ..., 
          [255, 255, 255],
          [255, 255, 255],
          [255, 255, 255]],
  
         ..., 
         [[255, 255, 255],
          [255, 255, 255],
          [255, 255, 255],
          ..., 
          [255, 255, 255],
          [255, 255, 255],
          [255, 255, 255]],
  
         [[255, 255, 255],
          [255, 255, 255],
          [255, 255, 255],
          ..., 
          [255, 255, 255],
          [255, 255, 255],
          [255, 255, 255]],
  
         [[255, 255, 255],
          [255, 255, 255],
          [255, 255, 255],
          ..., 
          [255, 255, 255],
          [255, 255, 255],
          [255, 255, 255]]], dtype=uint8)
    img_height : 1533
    img_width  : 1080
    left       : 0
    top        : 0
    width      : 1200
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca0c42f15513945c221387f203b8521143612be1

commit ca0c42f15513945c221387f203b8521143612be1
Author: xlai <xlai@chromium.org>
Date: Thu Mar 30 01:52:15 2017

Temporarily Skip some pixel tests on Nexus 5 due to test dimension issue

We've shrunk the OffscreenCanvas gpu pixel tests' width dimension in
https://codereview.chromium.org/2774423006/. That worked for all other
Android bots except Nexus 5. So we need to further shrink the width
dimension.

TBR=zmo@chromium.org
TBR_REASON=Test suppression on Nexus 5
NOTRY=true
BUG= 706647 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2781183003
Cr-Commit-Position: refs/heads/master@{#460620}

[modify] https://crrev.com/ca0c42f15513945c221387f203b8521143612be1/content/test/gpu/gpu_tests/pixel_expectations.py
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26fc6c0ddcd07f840f1b6d0ec8e2a367ec7ea60a

commit 26fc6c0ddcd07f840f1b6d0ec8e2a367ec7ea60a
Author: xlai <xlai@chromium.org>
Date: Tue Apr 11 21:01:35 2017

Shrink OffscreenCanvas commit pixel tests' test rect dimension

BUG= 706647 
TBR=junov@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2811993003
Cr-Commit-Position: refs/heads/master@{#463766}

[modify] https://crrev.com/26fc6c0ddcd07f840f1b6d0ec8e2a367ec7ea60a/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_main.html
[modify] https://crrev.com/26fc6c0ddcd07f840f1b6d0ec8e2a367ec7ea60a/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_worker.html
[modify] https://crrev.com/26fc6c0ddcd07f840f1b6d0ec8e2a367ec7ea60a/content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_main.html
[modify] https://crrev.com/26fc6c0ddcd07f840f1b6d0ec8e2a367ec7ea60a/content/test/data/gpu/pixel_offscreenCanvas_webgl_commit_worker.html
[modify] https://crrev.com/26fc6c0ddcd07f840f1b6d0ec8e2a367ec7ea60a/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/26fc6c0ddcd07f840f1b6d0ec8e2a367ec7ea60a/content/test/gpu/gpu_tests/pixel_test_pages.py
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f507c20c1fb15aea209777169f831019aaf6874

commit 7f507c20c1fb15aea209777169f831019aaf6874
Author: xlai <xlai@chromium.org>
Date: Wed Apr 12 23:53:54 2017

Remove failed entries in pixel expectations

TBR=junov@chromium.org
BUG= 706647 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2816813002
Cr-Commit-Position: refs/heads/master@{#464212}

[modify] https://crrev.com/7f507c20c1fb15aea209777169f831019aaf6874/content/test/gpu/gpu_tests/pixel_expectations.py

Comment 4 by xlai@chromium.org, Apr 13 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment