New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706643 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

[MD settings] styling Done button in passwords dialog.

Project Member Reported by dschuyler@chromium.org, Mar 30 2017

Issue description

The Done button in the passwords dialog is too far left and it isn't styled as an action button.


[related to "[passwords - details dialog] DONE wrong text weight" in https://docs.google.com/spreadsheets/d/17uvG_CTZ7N16B7hSdobwSc8VQO6xFPk2Q3Hz4dbKrx4/edit#gid=0]
 
2017-03-29 (1).png
11.4 KB View Download
CL at https://codereview.chromium.org/2783063002/
Screenshot from 2017-03-29 17:37:55.png
1.4 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6a2ed91fb2df3c4f234ca8824cfb570f902897c

commit e6a2ed91fb2df3c4f234ca8824cfb570f902897c
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Mar 30 18:28:00 2017

[MD settings] done button in passwords dialog as action button

This CL makes the Done button in the passwords dialog an action button,
rather than a cancel button. This positions and styles the button as
desired. This CL also accepts the Enter key to close the dialog.

BUG= 706643 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2783063002
Cr-Commit-Position: refs/heads/master@{#460831}

[modify] https://crrev.com/e6a2ed91fb2df3c4f234ca8824cfb570f902897c/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/e6a2ed91fb2df3c4f234ca8824cfb570f902897c/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js

Status: Fixed (was: Started)

Sign in to add a comment