New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706638 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

[A11y Assessment - Tab Strip] Visibility of New Tab button

Project Member Reported by hwi@chromium.org, Mar 30 2017

Issue description

Chrome Version: 57.0.2987.110

On the default theme, the new tab button is low contrast (1.4~2.1) against the white bg. 

We should figure out a way to make the outline, or the button as a whole, more visible with better contrast. 
 

Comment 1 by hwi@chromium.org, Mar 30 2017

Labels: OS-Chrome
Also similar low contrast level on CrOS. 
Cc: bettes@chromium.org
Owner: hwi@chromium.org
Status: Assigned (was: Untriaged)
Hey Hwi, just  checking in on this. Anything we can do here to push this ahead? We've received additional user feedback that this button is pretty much invisible to anyone with low contrast (myself included). 

Comment 3 Deleted

Comment 4 by hwi@chromium.org, Aug 14 2017

pkasting@ for the help on the following. If anyone else can answer, that'll be helpful, too!

- how are the stroke colors defined? Measuring from the screenshot (attached), it seems we're using a gray with some opacity that results in different shades depending on colors under the strokes.
- what it takes to make the strokes non-blurry?

Thanks!
strokes.png
19.3 KB View Download

Comment 5 by rpop@chromium.org, Aug 14 2017

Cc: bsep@chromium.org
bsep, could you answer the Qs in #4? 

Comment 6 by bsep@chromium.org, Aug 21 2017

Hmm, the code is a bit tricky. Without digging into it too much, it looks like black is being blended into the button color. The new tab button is taking the tab stroke color and applying some additional calculations to it (that I don't understand) so that might be why it's different.

As for why it's blurry... I'm not sure. I know the tab strokes are sometimes blurry (see  bug 628039 ) so maybe it's the same problem.
The new tab button outline uses the same color as the tabstrip/toolbar border, which is dynamically computed based on the tab and frame colors so as to contrast some with each, but not too much (precise parameters were argued out with sgabriel@ during top chrome MD implementation).  However, it's also alpha blended against the frame to reduce contrast (alpha ~= 0.88 when pressed or 0.61 when unpressed).

The whole thing is then also given a 1 DIP drop shadow, which is masked in confusing ways, again depending on pressed or unpressed state; basically, when unpressed the shadow is cast outside the button, when pressed it's cast inside.

One way to sharpen all this would be to eliminate the drop shadow in the unpressed state, and the alpha blending at all times.  This would make the new tab button basically look exactly like the tabs do.  That might not be a desirable effect.

Comment 8 by hwi@chromium.org, Oct 9 2017

Labels: Hotlist-UX-Backlog-hwi
Friendly ping - Hwi, is this work still progressing? Would be great to get this in as part of our PE sweep. 

Comment 10 by hwi@chromium.org, Oct 19 2017

Owner: ----
Status: Available (was: Assigned)
It would be great if we can try the suggestion on #7 ("eliminate the drop shadow in the unpressed state, and the alpha blending at all times") in the code.
Labels: -Type-Feature Type-Bug
Labels: win-a11y
Labels: contrast
Labels: contrast
Labels: tabstrip
Labels: Pri-2
Setting to p2 since this was found during our assessment
Project Member

Comment 17 by sheriffbot@chromium.org, Dec 17

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
The New Tab Button changed fairly significantly in MD Refresh.  Is this bug still applicable?
Status: Archived (was: Untriaged)

Sign in to add a comment