Issue metadata
Sign in to add a comment
|
"Always Show Toolbar in Full Screen" Menu Item is Disabled when Chrome is Full Screen |
||||||||||||||||||||||
Issue descriptionChrome Version: 59.0.3054.0 (Official Build) canary (64-bit) OS: macOS 10.12.4 This is a pretty refresh regression as this only started repro'ing after I updated canary due to an OS update. This menu item was enabled this morning before restarting. The "Always Show Toolbar in Full Screen" menu item is disabled when Chrome is full screen. It's my understanding that this should always be enabled.
,
Apr 4 2017
It looks like this for me when I'm not in full screen, too — I can't turn this setting on at all.
,
Apr 11 2017
Able to reproduce the issue on Mac OS X 10.12.3 on Latest Dev# 59.0.3063.4. This is a Regression issue broken in M59. Chrome Good Build -- 59.0.3048.0 (Revision Number - 458590) Chrome Bad Build -- 59.0.3050.0 (Revision Number - 459323) Using per revision bisect, providing the bisect info -- You are probably looking for a change made after 458827 (known good), but no later than 458828 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/2d30e002c7613a18fed1c12da55a4a5527dd36aa..39480fd2b6d3b9a01026520f6bc50c42f23850b0 Adding the CL owner in Cc for further triaging. Thank You.
,
Apr 11 2017
The fix is simple, someone change the command's ID and forgot to update MainMenu.xib. I'll submit a fix tonight
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1a29ebf18d1e876df019c862c9e4f6719aff64f commit f1a29ebf18d1e876df019c862c9e4f6719aff64f Author: spqchan <spqchan@chromium.org> Date: Wed Apr 12 00:11:56 2017 Fix for the "Always Show Toolbar in Full Screen" Menu Item BUG= 706634 Review-Url: https://codereview.chromium.org/2808333003 Cr-Commit-Position: refs/heads/master@{#463851} [modify] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/chrome/app/nibs/MainMenu.xib
,
Apr 12 2017
,
Apr 17 2017
Issue 708988 has been merged into this issue.
,
Apr 18 2017
Tested the issue on Mac 10.12.4 using chrome version# 59.0.3071.9. Observed that the "Always Show Toolbar in Full Screen" menu item is enabled when Chrome is full screen . Hence adding TE-Verified labels. Please find the attached screen cast for the same. Thanks!! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by spqc...@chromium.org
, Mar 30 2017Labels: -Pri-2 ReleaseBlock-Stable M-59 Pri-1
Owner: spqc...@chromium.org
Status: Assigned (was: Untriaged)