New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706629 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 668541



Sign in to add a comment

2D chrome appears briefly after DON flow

Project Member Reported by bshe@chromium.org, Mar 29 2017

Issue description

What steps will reproduce the problem?
(1) open a webvr site: https://webvr.info/samples/03-vr-presentation.html?polyfill=0
(2) press presentation button
(3) Finish DON flow

What is the expected result?
Directly show webvr binocular frames

What happens instead?
2D chrome showed up briefly.

M59 for now, if the same problem exist on M58. We could consider backport to M58.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b374988abdf6fe6d5976c08fb52144248cacb98

commit 8b374988abdf6fe6d5976c08fb52144248cacb98
Author: bshe <bshe@chromium.org>
Date: Fri Mar 31 14:36:36 2017

Fix showing 2D chrome shortly after DON finished

BUG= 706629 

Review-Url: https://codereview.chromium.org/2779223004
Cr-Commit-Position: refs/heads/master@{#461116}

[modify] https://crrev.com/8b374988abdf6fe6d5976c08fb52144248cacb98/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Comment 2 by bshe@chromium.org, Apr 3 2017

Labels: -M-59 Merge-Approved-58 M-58
M58 had the same issue. Try to merge back to M58 since this could improve the transition from 2D to VR. 
Labels: -Merge-Approved-58 Merge-Request-58
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 3 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
[Bulk edit]

This issue has been approved for a merge to M58.  Please ensure the merge is processed by tomorrow at 5 PM PT so it's included in our next beta build.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 4 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/911f9470515ed170b3bb9675fdc124a3567ac704

commit 911f9470515ed170b3bb9675fdc124a3567ac704
Author: bshe <bshe@chromium.org>
Date: Tue Apr 04 13:46:09 2017

Fix showing 2D chrome shortly after DON finished

BUG= 706629 

Review-Url: https://codereview.chromium.org/2779223004
Cr-Commit-Position: refs/heads/master@{#461116}
(cherry picked from commit 8b374988abdf6fe6d5976c08fb52144248cacb98)

Review-Url: https://codereview.chromium.org/2797703002 .
Cr-Commit-Position: refs/branch-heads/3029@{#563}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/911f9470515ed170b3bb9675fdc124a3567ac704/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Comment 7 by bshe@chromium.org, Apr 4 2017

Status: Fixed (was: Started)
Labels: Proj-VR-Shell

Sign in to add a comment