New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706615 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove signature checking from run_oci

Project Member Reported by ejcaruso@chromium.org, Mar 29 2017

Issue description

imageloader is doing signature checking for oci containers, so we don't need to do it again in run_oci, rendering this dead code. This will also allow us to get rid of the scary-looking "--unsigned" flag.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/92aa970e35ff34a4ea35b77e67e3b8e342f797c7

commit 92aa970e35ff34a4ea35b77e67e3b8e342f797c7
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Mon May 08 19:41:01 2017

run_oci: remove signature checking

We always use the unsigned option because signature checking is
done when imageloader mounts the squashfs image rather than at
run_oci time. For VMs, this checking happens outside of the VM
so we've already done it by the time run_oci is called in that
case as well. This also removes the need to have libcrypto in the
deps.

BUG= chromium:706615 
TEST=emerge, c adb

Change-Id: I7d816df8f69228de80d1c4b4720bf6f1d79bd946
Reviewed-on: https://chromium-review.googlesource.com/494087
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/92aa970e35ff34a4ea35b77e67e3b8e342f797c7/run_oci/run_oci.cc
[modify] https://crrev.com/92aa970e35ff34a4ea35b77e67e3b8e342f797c7/crosh/dev.d/50-crosh.sh
[modify] https://crrev.com/92aa970e35ff34a4ea35b77e67e3b8e342f797c7/run_oci/run_oci.gyp
[modify] https://crrev.com/92aa970e35ff34a4ea35b77e67e3b8e342f797c7/run_oci/container_options.h

Status: Fixed (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8a0c32cfe6914e5cecf5ef83a8f2e418ec5584a0

commit 8a0c32cfe6914e5cecf5ef83a8f2e418ec5584a0
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu May 18 02:06:28 2017

run_oci: drop unused manifest.json check

The previous cleanup here left behind an unused variable.

BUG= chromium:706615 
TEST=precq passes

Change-Id: Ic71f3f5823a5f4b2571ab8111421014f881607e8
Reviewed-on: https://chromium-review.googlesource.com/506751
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/8a0c32cfe6914e5cecf5ef83a8f2e418ec5584a0/run_oci/run_oci.cc

Sign in to add a comment