New issue
Advanced search Search tips

Issue 706610 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

AnalyserNode.channelCount = 2

Project Member Reported by rtoy@chromium.org, Mar 29 2017 
According to https://webaudio.github.io/web-audio-api/#the-analysernode-interface the channelCount should be 1, not 2:

c = new AudioContext()
n = new AnalyserNode(c)
n.channelCount
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dbd3497a559c2227a37a4e108f6380394c049a4

commit 2dbd3497a559c2227a37a4e108f6380394c049a4
Author: rtoy <rtoy@chromium.org>
Date: Mon Apr 24 22:06:33 2017

AnalyserNode.channelCount should be 1

The spec says channelCount should be 1.

Also change the default number of output channels to be 1 (was 2).
This reduces complexity of any down-stream nodes so that they will
process mono unless the input to the AnalyserNode has more than one
channel.  Without this, all down-stream nodes will see a stereo input,
doubling processing costs.  This change should not be user-detectable
in any way.

BUG= 706610 
TEST=constructor/analyser.html

Review-Url: https://codereview.chromium.org/2809923004
Cr-Commit-Position: refs/heads/master@{#466787}

[modify] https://crrev.com/2dbd3497a559c2227a37a4e108f6380394c049a4/third_party/WebKit/LayoutTests/webaudio/constructor/analyser.html
[modify] https://crrev.com/2dbd3497a559c2227a37a4e108f6380394c049a4/third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp

Comment 2 by rtoy@chromium.org, Apr 25 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment