The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e15c66857e9d4ebc0bf3a5e13ca1c7ba29eea97

commit 1e15c66857e9d4ebc0bf3a5e13ca1c7ba29eea97
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Jun 21 21:07:29 2017

Roll Fuchsia SDK to 457adecd1600ab82efa6d142cc506560b7d8f7c8

Follows https://bugs.chromium.org/p/chromium/issues/detail?id=707030#c4.

Notable changes:
- Includes https://fuchsia-review.googlesource.com/c/35564/ which makes
  futime[n]s() work, except that access time is not supported on
  Fuchsia (see linked bug). So FileUtilTest.TouchFile mostly works now.
- Includes
  https://fuchsia.googlesource.com/magenta/+/2db38e2b99162c84ae43d39715031d59fcee7ac5
  which removes '..' from readdir() (see other linked bug). For this
  case, update FileEnumerator to include a fake .. to preserve the
  interface expected for INCLUDE_DOT_DOT. This is necessary to keep
  FileUtilTest.FileEnumeratorTest working. (yay! caught a semi-
  regression)

Bug: 706592,  735233 ,  735540 
Change-Id: Iafbd0f80ef386c2def9edd5be3e309b034cdf215
Reviewed-on: https://chromium-review.googlesource.com/542945
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481293}
[modify] https://crrev.com/1e15c66857e9d4ebc0bf3a5e13ca1c7ba29eea97/DEPS
[modify] https://crrev.com/1e15c66857e9d4ebc0bf3a5e13ca1c7ba29eea97/base/files/file_enumerator_posix.cc
[modify] https://crrev.com/1e15c66857e9d4ebc0bf3a5e13ca1c7ba29eea97/base/files/file_util_unittest.cc
[modify] https://crrev.com/1e15c66857e9d4ebc0bf3a5e13ca1c7ba29eea97/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa8116176f4c3fd9a86083a2b08147fdc749b078

commit fa8116176f4c3fd9a86083a2b08147fdc749b078
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Jun 22 16:44:36 2017

fuchsia: remove suppression of MemoryPeakDetectorTest.StartStopQuickly

Fixed by https://chromium-review.googlesource.com/544818.

Bug:  734218 , 706592
Change-Id: I3359266830902964bd884293e5f418529c49c318
Reviewed-on: https://chromium-review.googlesource.com/544518
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481562}
[modify] https://crrev.com/fa8116176f4c3fd9a86083a2b08147fdc749b078/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f51fbcd2367c3d4d5f91ca8bf37b76eda60f4da0

commit f51fbcd2367c3d4d5f91ca8bf37b76eda60f4da0
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Jun 22 18:00:26 2017

fuchsia: get symbolized backtraces

Removes the attempted manual in-process printing of stack traces in
favour of letting the system crashlogger print one to stdout and then
filtering that in the run script to get file/line info. It does not
yet resolve kernel/system symbols, only those in the test binary, but
I think that's OK for now.

(I started trying to do this all in-process
https://chromium-review.googlesource.com/c/544108/1/base/debug/stack_trace_fuchsia.cc
but it was getting out of hand, and there was still quite a lot more
code required. Using the system one for debug backtraces seems better
anyway.)

Example output:
https://gist.github.com/sgraham/d9d332de986c1caa5dc2644ab9c5191a

Bug: 706592
Change-Id: Ic5e6241544d4e38b46db04d4c29f584f316c26b5
Reviewed-on: https://chromium-review.googlesource.com/544109
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481600}
[modify] https://crrev.com/f51fbcd2367c3d4d5f91ca8bf37b76eda60f4da0/base/debug/stack_trace_fuchsia.cc
[modify] https://crrev.com/f51fbcd2367c3d4d5f91ca8bf37b76eda60f4da0/build/fuchsia/test_runner.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff38a416a16591a0606b0eebf2daf96eaab24091

commit ff38a416a16591a0606b0eebf2daf96eaab24091
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Jun 22 18:59:11 2017

Fix various issues with ObserverListThreadSafeTest.CrossThread*

In porting base to Fuchsia,
ObserverListThreadSafeTest.CrossThreadObserver was sometimes crashing.
This appears to be due to different thread scheduling, but was an
all-platforms bug. Fix that by waiting for ThreadMains to start.

Additionally, .CrossThreadNotifications wasn't working as intended
because the "true" it passed into the utility function was ignored.
(This has always been wrong: https://codereview.chromium.org/7353)

Also, two Adder objects were unnecessarily created; remove them.

Bug: 706592,  735603 
Change-Id: I1be4a825d05b1a46cbf554b6cd3b4c91410d4b76
Reviewed-on: https://chromium-review.googlesource.com/544176
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481615}
[modify] https://crrev.com/ff38a416a16591a0606b0eebf2daf96eaab24091/base/observer_list_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9874dbf193fa584b91675245627598676b2b4360

commit 9874dbf193fa584b91675245627598676b2b4360
Author: Scott Graham <scottmg@chromium.org>
Date: Fri Jun 23 00:26:29 2017

fuchsia: allocate vmo/vmar instead of mmap/mprotect to create guarded memory

Fuchsia doesn't (currently? uncertain) support mprotect(...NONE...).
Work around this by using native apis to create a memory block and a
virtual memory mapping, and then leaving a guard page unmapped at the
end of the mapping.

Bug: 706592
Change-Id: I5329cf9206e5aa8056edf0cfb50b8745b9d1c83e
Reviewed-on: https://chromium-review.googlesource.com/545155
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481742}
[modify] https://crrev.com/9874dbf193fa584b91675245627598676b2b4360/base/trace_event/heap_profiler_allocation_register_posix.cc
[modify] https://crrev.com/9874dbf193fa584b91675245627598676b2b4360/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f94d84d8cd80e52a4a5950bbf82fba73dada7424

commit f94d84d8cd80e52a4a5950bbf82fba73dada7424
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Jun 26 18:51:10 2017

fuchsia: Add beginning of build docs

TBR=thakis@chromium.org

Bug: 706592
Change-Id: I7d18caed8ddb8c7c5d34f680d58a547c0516953e
Reviewed-on: https://chromium-review.googlesource.com/549056
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482340}
[add] https://crrev.com/f94d84d8cd80e52a4a5950bbf82fba73dada7424/docs/fuchsia_build_instructions.md

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b69a2f67ad51e197483d42c094c0ed94fcad6f3a

commit b69a2f67ad51e197483d42c094c0ed94fcad6f3a
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Jun 26 19:33:20 2017

fuchsia: tweak build docs

TBR=thakis@chromium.org

Bug: 706592
Change-Id: I26abd7a3f0c4a13f46530917785119ec56dee7d5
Reviewed-on: https://chromium-review.googlesource.com/549038
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482356}
[modify] https://crrev.com/b69a2f67ad51e197483d42c094c0ed94fcad6f3a/docs/fuchsia_build_instructions.md

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a26c270f0ade55141141f4c23ab9e2c93de342c2

commit a26c270f0ade55141141f4c23ab9e2c93de342c2
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Jun 26 20:32:26 2017

fuchsia: Implement SharedMemory and SharedMemoryHandle

For regular shared memory, posix maps a file in /tmp, but this isn't
fully supported in Fuchsia. Instead, use simpler native system calls to
create shared memory and map/unmap it into the address space. The
implementation of SharedMemory is closer to the Windows implementation
than the posix one.

field_trials is also updated to follow something more similar to its
Windows path, rather than the fd-based posix-y path, but only insofar
as compiling, I haven't investigated the tests yet.

Makes SharedMemoryTest.* pass on Fuchsia.

Ref:
- https://fuchsia.googlesource.com/magenta/+/HEAD/docs/syscalls/vmo_create.md
- https://fuchsia.googlesource.com/magenta/+/HEAD/docs/syscalls/vmar_map.md
- https://fuchsia.googlesource.com/magenta/+/HEAD/docs/syscalls/vmar_unmap.md

Bug: 706592
Change-Id: Id1503831f4eeeae5b2e4cafe0b90834febe3d06b
Reviewed-on: https://chromium-review.googlesource.com/545148
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482380}
[modify] https://crrev.com/a26c270f0ade55141141f4c23ab9e2c93de342c2/base/BUILD.gn
[modify] https://crrev.com/a26c270f0ade55141141f4c23ab9e2c93de342c2/base/memory/shared_memory.h
[add] https://crrev.com/a26c270f0ade55141141f4c23ab9e2c93de342c2/base/memory/shared_memory_fuchsia.cc
[modify] https://crrev.com/a26c270f0ade55141141f4c23ab9e2c93de342c2/base/memory/shared_memory_handle.h
[add] https://crrev.com/a26c270f0ade55141141f4c23ab9e2c93de342c2/base/memory/shared_memory_handle_fuchsia.cc
[modify] https://crrev.com/a26c270f0ade55141141f4c23ab9e2c93de342c2/base/memory/shared_memory_helper.cc
[modify] https://crrev.com/a26c270f0ade55141141f4c23ab9e2c93de342c2/base/memory/shared_memory_unittest.cc
[modify] https://crrev.com/a26c270f0ade55141141f4c23ab9e2c93de342c2/base/metrics/field_trial.cc
[modify] https://crrev.com/a26c270f0ade55141141f4c23ab9e2c93de342c2/base/metrics/field_trial.h
[modify] https://crrev.com/a26c270f0ade55141141f4c23ab9e2c93de342c2/base/metrics/field_trial_unittest.cc
[modify] https://crrev.com/a26c270f0ade55141141f4c23ab9e2c93de342c2/base/process/launch.h
[modify] https://crrev.com/a26c270f0ade55141141f4c23ab9e2c93de342c2/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66411becd2b5a570b5629b64422a17a3583b2d0e

commit 66411becd2b5a570b5629b64422a17a3583b2d0e
Author: Scott Graham <scottmg@chromium.org>
Date: Tue Jun 27 19:21:27 2017

Make XmlUnitTestResultPrinter handle failing to open output

This was causing occasional crashes on Fuchsia. See
https://bugs.chromium.org/p/chromium/issues/detail?id=736783#c6 for a
detailed explanation of the conditions under which this can happen.

Bug:  736783 , 706592
Change-Id: I5000509d846dd9b8f10b9ae7a58bbfbdd642cc96
Reviewed-on: https://chromium-review.googlesource.com/550200
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482709}
[modify] https://crrev.com/66411becd2b5a570b5629b64422a17a3583b2d0e/base/test/gtest_xml_unittest_result_printer.cc
[modify] https://crrev.com/66411becd2b5a570b5629b64422a17a3583b2d0e/base/test/gtest_xml_unittest_result_printer.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dfbd3fa246a046c79a1d015f8c99040aa416624

commit 5dfbd3fa246a046c79a1d015f8c99040aa416624
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Jun 29 00:09:08 2017

Roll Fuchsia SDK to 8b1076a14d3e31dd3e569b44ddb49e49e0799baf

Includes
https://fuchsia.googlesource.com/magenta/+/86fca78429c3a09e4d7e99fcaf3cb79262f3cd7f
and
https://fuchsia.googlesource.com/magenta/+/4ae4c542d434ec4e3e619145b773f23818632d54

to fix FileTest.Append without regressing FileUtilTest.SetNonBlocking.

Bug: 707030, 706592
Change-Id: Ia29f3cca09101eb7fb721c924d688c6a3d0fb406
Reviewed-on: https://chromium-review.googlesource.com/553718
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483208}
[modify] https://crrev.com/5dfbd3fa246a046c79a1d015f8c99040aa416624/DEPS
[modify] https://crrev.com/5dfbd3fa246a046c79a1d015f8c99040aa416624/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3002e5d40231945950c3b96a905662d412212d84

commit 3002e5d40231945950c3b96a905662d412212d84
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Jun 29 01:57:18 2017

fuchsia: Fix field trial shm serialization, enable FieldTrialListTest.*

Mostly fixed by https://chromium-review.googlesource.com/c/545148/.
After also fixing the handle serialization, the associated tests all
pass.

Bug: 706592
Change-Id: I996a7463b10774c57123e5ae0f06e0d841035de8
Reviewed-on: https://chromium-review.googlesource.com/546900
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483253}
[modify] https://crrev.com/3002e5d40231945950c3b96a905662d412212d84/base/metrics/field_trial.cc
[modify] https://crrev.com/3002e5d40231945950c3b96a905662d412212d84/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac24b8c6e0c3056bd54167d029238e28953210ff

commit ac24b8c6e0c3056bd54167d029238e28953210ff
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Jun 29 15:37:54 2017

fuchsia: Scrub disabled test list

Enable a bunch of passing tests. Most of these were fixed by the shared
memory implementation.

Bug: 706592
Change-Id: I56a51c6e34ef4f7666c9a2f4c4f9253ad087d017
Reviewed-on: https://chromium-review.googlesource.com/553444
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483372}
[modify] https://crrev.com/ac24b8c6e0c3056bd54167d029238e28953210ff/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f53b4e764daa8eb42455eaeb15f1a25cb89d4fbc

commit f53b4e764daa8eb42455eaeb15f1a25cb89d4fbc
Author: James Robinson <jamesr@google.com>
Date: Thu Jun 29 20:59:55 2017

[fuchsia] Implement persistent file watches in MessagePumpFuchsia

This implements "persistent" file watches in the Fuchsia message pump
by re-arming the watch after it is triggered. libevent states that
timeouts are also reset when the EV_PERSIST flag is set, but we don't
use timeouts on file watches so this aspect is ignored.

Bug: 706592
Change-Id: I49b499435b1414f25a7e3e7a3462dfdaecec6cda
Reviewed-on: https://chromium-review.googlesource.com/553545
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: James Robinson <jamesr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483483}
[modify] https://crrev.com/f53b4e764daa8eb42455eaeb15f1a25cb89d4fbc/base/message_loop/message_pump_fuchsia.cc
[modify] https://crrev.com/f53b4e764daa8eb42455eaeb15f1a25cb89d4fbc/base/message_loop/message_pump_fuchsia.h
[modify] https://crrev.com/f53b4e764daa8eb42455eaeb15f1a25cb89d4fbc/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3b71657085128930144893b598218a6c0748b2c

commit d3b71657085128930144893b598218a6c0748b2c
Author: Scott Graham <scottmg@chromium.org>
Date: Fri Jun 30 23:56:52 2017

fuchsia: Fix lifetime of was_destroyed_ pointer in MessagePumpFuchsia

Missed in review here, oops! https://chromium-review.googlesource.com/c/553545/

Bug: 738275, 706592
Change-Id: I69071b31cee784398eb3a123aff56d592e753d91
Reviewed-on: https://chromium-review.googlesource.com/558201
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483867}
[modify] https://crrev.com/d3b71657085128930144893b598218a6c0748b2c/base/message_loop/message_pump_fuchsia.cc
[modify] https://crrev.com/d3b71657085128930144893b598218a6c0748b2c/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac4b41c24003ca58a3f2cf8c48567a0e2f69a779

commit ac4b41c24003ca58a3f2cf8c48567a0e2f69a779
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Tue Jul 11 18:20:47 2017

Fuchsia: only emit ".." from file enumerator if requested.

Fuchsia: only emit ".." from file enumerator if requested.
The Fuchsia-specific workaround which appended ".." to POSIX readdir()
output was not respecting the INCLUDE_DOT_DOT type flag.


R=sergeyu@chromium.org,thakis@chromium.org
CC=wez@chromium.org

Bug: 706592
Change-Id: Ice40cbecd67bf86410d53bd32e91e74e0575efc1
Reviewed-on: https://chromium-review.googlesource.com/562358
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485679}
[modify] https://crrev.com/ac4b41c24003ca58a3f2cf8c48567a0e2f69a779/base/files/file_enumerator_posix.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52118eee387b24fe8c3001a7e31d11f588a8b183

commit 52118eee387b24fe8c3001a7e31d11f588a8b183
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Jul 13 02:48:07 2017

Remove unsupported perm, symlink calls for Fuchsia.

Remove unsupported perm, symlink calls for Fuchsia.
Fuchsia's POSIX support does not extend to file permission bit or
symbolic links. This CL conditionally removes the relevant calls from
file_util and disables affected tests under Fuchsia builds.

R: thakis@chromium.org
Bug: 706592
Change-Id: Id6b68fd9a440f37debe50feb7ce3f457bbee3e4f
Reviewed-on: https://chromium-review.googlesource.com/562901
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486236}
[modify] https://crrev.com/52118eee387b24fe8c3001a7e31d11f588a8b183/base/files/file_path_watcher_unittest.cc
[modify] https://crrev.com/52118eee387b24fe8c3001a7e31d11f588a8b183/base/files/file_util.h
[modify] https://crrev.com/52118eee387b24fe8c3001a7e31d11f588a8b183/base/files/file_util_posix.cc
[modify] https://crrev.com/52118eee387b24fe8c3001a7e31d11f588a8b183/base/files/file_util_unittest.cc
[modify] https://crrev.com/52118eee387b24fe8c3001a7e31d11f588a8b183/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/450a8feea254f54e61be2bf5529e26027c656d6b

commit 450a8feea254f54e61be2bf5529e26027c656d6b
Author: Nico Weber <thakis@chromium.org>
Date: Thu Jul 13 16:57:40 2017

Revert "Remove unsupported perm, symlink calls for Fuchsia."

This reverts commit 52118eee387b24fe8c3001a7e31d11f588a8b183.

Reason for revert:
Breaks build: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FFuchsia%2F6583%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

Original change's description:
> Remove unsupported perm, symlink calls for Fuchsia.
> 
> Remove unsupported perm, symlink calls for Fuchsia.
> Fuchsia's POSIX support does not extend to file permission bit or
> symbolic links. This CL conditionally removes the relevant calls from
> file_util and disables affected tests under Fuchsia builds.
> 
> R: thakis@chromium.org
> Bug: 706592
> Change-Id: Id6b68fd9a440f37debe50feb7ce3f457bbee3e4f
> Reviewed-on: https://chromium-review.googlesource.com/562901
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486236}

TBR=thakis@chromium.org,kmarshall@chromium.org

Change-Id: Icdd32651551e1a77adf9322fb531d4af69b56b38
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 706592
Reviewed-on: https://chromium-review.googlesource.com/570499
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486414}
[modify] https://crrev.com/450a8feea254f54e61be2bf5529e26027c656d6b/base/files/file_path_watcher_unittest.cc
[modify] https://crrev.com/450a8feea254f54e61be2bf5529e26027c656d6b/base/files/file_util.h
[modify] https://crrev.com/450a8feea254f54e61be2bf5529e26027c656d6b/base/files/file_util_posix.cc
[modify] https://crrev.com/450a8feea254f54e61be2bf5529e26027c656d6b/base/files/file_util_unittest.cc
[modify] https://crrev.com/450a8feea254f54e61be2bf5529e26027c656d6b/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a57f692006e551d1ae8e5aca714b51f8cd3aa7c

commit 7a57f692006e551d1ae8e5aca714b51f8cd3aa7c
Author: Wez <wez@chromium.org>
Date: Thu Jul 13 17:03:09 2017

Revert "Remove unsupported perm, symlink calls for Fuchsia."

This reverts commit 52118eee387b24fe8c3001a7e31d11f588a8b183.

Reason for revert: This prevents net_unittests from building, due to a dependency on these APIs in sql/connection.cc. We should consider stubbing them out to return sensible values, e.g. GetPosixPermissions returning ugo+rwx and SetPosixPermissions returning not-implemented error.

Original change's description:
> Remove unsupported perm, symlink calls for Fuchsia.
> 
> Remove unsupported perm, symlink calls for Fuchsia.
> Fuchsia's POSIX support does not extend to file permission bit or
> symbolic links. This CL conditionally removes the relevant calls from
> file_util and disables affected tests under Fuchsia builds.
> 
> R: thakis@chromium.org
> Bug: 706592
> Change-Id: Id6b68fd9a440f37debe50feb7ce3f457bbee3e4f
> Reviewed-on: https://chromium-review.googlesource.com/562901
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486236}

TBR=thakis@chromium.org,kmarshall@chromium.org

Change-Id: I1ce22ac0d60db6891c8264e269247deec0f29f32
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 706592
Reviewed-on: https://chromium-review.googlesource.com/570518
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486416}

Re #114: Note that the revert CL generated by Gerrit was empty, so the perms CL was not actually reverted.

It was empty because the Cl already got reverted in 113

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9f05ecc9dac5df61c6320dd1509a77554e1c14e

commit a9f05ecc9dac5df61c6320dd1509a77554e1c14e
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Fri Jul 14 02:10:05 2017

Reland "Remove unsupported perm, symlink calls for Fuchsia."

Reland "Remove unsupported perm, symlink calls for Fuchsia."
The previous CL was landed at the same time as net_unittests,
which depended on calls that were conditionally removed from this CL.

This CL adds !OS_FUCHSIA guards to the relevant ifdef blocks in
url_request_unittest and sql/connection.cc.

Removing these functions from Fuchsia builds will make it easier to
detect and prevent any future regressions, since they'll appear as
build breakages.

R: thakis@chromium.org
Bug: 706592
Change-Id: Iad6343a3cb6fcc90b742de04bb8052e77ba498c7
Reviewed-on: https://chromium-review.googlesource.com/569845
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486632}
[modify] https://crrev.com/a9f05ecc9dac5df61c6320dd1509a77554e1c14e/base/files/file_path_watcher_unittest.cc
[modify] https://crrev.com/a9f05ecc9dac5df61c6320dd1509a77554e1c14e/base/files/file_util.h
[modify] https://crrev.com/a9f05ecc9dac5df61c6320dd1509a77554e1c14e/base/files/file_util_posix.cc
[modify] https://crrev.com/a9f05ecc9dac5df61c6320dd1509a77554e1c14e/base/files/file_util_unittest.cc
[modify] https://crrev.com/a9f05ecc9dac5df61c6320dd1509a77554e1c14e/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/a9f05ecc9dac5df61c6320dd1509a77554e1c14e/sql/connection.cc
[modify] https://crrev.com/a9f05ecc9dac5df61c6320dd1509a77554e1c14e/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2804dbe239069dc2bb41d67d381689105c53e85d

commit 2804dbe239069dc2bb41d67d381689105c53e85d
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Fri Jul 14 02:58:07 2017

Remove File::Lock() and Unlock() under Fuchsia.

Remove File::Lock() and Unlock() under Fuchsia.
Fuchsia does not support POSIX file locking, so Lock() and Unlock()
have been removed. As the porting effort continues, it'll be easier to
find and fix dependent code because they'll generate build breakages.

Removed the unit test file from the test build target under Fuchsia.

BUG: 706592
Change-Id: I585f5c2ae254c993a64ecf534feb384890971fad
Reviewed-on: https://chromium-review.googlesource.com/569418
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486651}
[modify] https://crrev.com/2804dbe239069dc2bb41d67d381689105c53e85d/base/BUILD.gn
[modify] https://crrev.com/2804dbe239069dc2bb41d67d381689105c53e85d/base/files/file.h
[modify] https://crrev.com/2804dbe239069dc2bb41d67d381689105c53e85d/base/files/file_posix.cc
[modify] https://crrev.com/2804dbe239069dc2bb41d67d381689105c53e85d/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e821e1a89eac8982aa1d8fd3a3fbb31660309cf

commit 7e821e1a89eac8982aa1d8fd3a3fbb31660309cf
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Jul 24 22:36:03 2017

fuchsia: Only run test binary once

Regressed at https://chromium-review.googlesource.com/c/582047/, or
possibly https://chromium.googlesource.com/chromium/src.git/+/b29655da291d0fe10c945899913a21a63c278636
when bootstrap was rolled in (?).

bootstrap already runs autorun in apps.config, so don't add a second
run of the test binary.

Bug:  731302 , 706592
Change-Id: I6847942b64598777424ab2b106d2c7e1ba3ca8f5
Reviewed-on: https://chromium-review.googlesource.com/583928
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489105}
[modify] https://crrev.com/7e821e1a89eac8982aa1d8fd3a3fbb31660309cf/build/fuchsia/test_runner.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/269d83f247e1e2ec199ee4c4787e2eed80d1417b

commit 269d83f247e1e2ec199ee4c4787e2eed80d1417b
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Jul 24 23:14:26 2017

fuchsia: Disable ProcessMemoryDumpTest.CountResidentBytesInSharedMemory to green up bot

Added in https://chromium-review.googlesource.com/c/575802/. Not
implemented on Fuchsia.

TBR=wez@chromium.org

Bug: 706592
Change-Id: Ica615d18ad37e597fdf78e392e36159f809edade
Reviewed-on: https://chromium-review.googlesource.com/583793
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489129}
[modify] https://crrev.com/269d83f247e1e2ec199ee4c4787e2eed80d1417b/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf086248858ef769cfecaf9bd0b0b9284926d1b8

commit bf086248858ef769cfecaf9bd0b0b9284926d1b8
Author: Scott Graham <scottmg@chromium.org>
Date: Tue Jul 25 02:16:59 2017

fuchsia: Make ProcessUtilTest.GetAppOutput work

There's no `true`, `false`, or PATH on Fuchsia, so this test fails.
Instead, use the Android-like (exit 0 or exit 1) along with a
fully-specified path to sh.

Bug: 706592
Change-Id: I1cbb22e636f946a07cbec77b68586af8c6491cc3
Reviewed-on: https://chromium-review.googlesource.com/584002
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489189}
[modify] https://crrev.com/bf086248858ef769cfecaf9bd0b0b9284926d1b8/base/process/process_util_unittest.cc
[modify] https://crrev.com/bf086248858ef769cfecaf9bd0b0b9284926d1b8/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef6a75c026258dbb3405b8db2f96c0ae156d2141

commit ef6a75c026258dbb3405b8db2f96c0ae156d2141
Author: Scott Graham <scottmg@chromium.org>
Date: Tue Jul 25 21:25:32 2017

Fix flake in TimerTest.OneShotTimer_CustomTaskRunner

The test code started the timer and assumed it could not finish before
the line after the Start(), but since it's all asynchronous, there's no
reason that it can't. i.e. this ought to work, but always fails:

diff --git a/base/timer/timer_unittest.cc b/base/timer/timer_unittest.cc
index 75f353f..4919b86 100644
--- a/base/timer/timer_unittest.cc
+++ b/base/timer/timer_unittest.cc
@@ -419,6 +419,7 @@ TEST(TimerTest, OneShotTimer_CustomTaskRunner) {
   OneShotTimerTester f(&did_run);
   f.SetTaskRunner(other_thread.task_runner());
   f.Start();
+  sleep(1);
   EXPECT_TRUE(f.IsRunning());

   f.WaitAndConfirmTimerFiredAfterDelay();


This was exposed on Fuchsia in
https://luci-milo.appspot.com/buildbot/chromium.fyi/Fuchsia/7261 but is
cross-platform.

Bug: 706592, 738275
Change-Id: If53604e76fd91a34143ee650a18fba7280a8630b
Reviewed-on: https://chromium-review.googlesource.com/585568
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489439}
[modify] https://crrev.com/ef6a75c026258dbb3405b8db2f96c0ae156d2141/base/timer/timer_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6744c44fe0dc9773fcef488ba3a65f73246bac75

commit 6744c44fe0dc9773fcef488ba3a65f73246bac75
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Jul 26 01:08:47 2017

fuchsia: make ProcessUtilTest.LaunchProcess work

There's no `sh` in PATH on Fuchsia. Other tests already use kShellPath
so we have to have one there. So add kShellPath for Fuchsia, and remove
kPosixShell, since it's a bit silly and was only used by this test
anyway.

Bug: 706592
Change-Id: I6b067702cce6464ef69e27e72d428597ad459d28
Reviewed-on: https://chromium-review.googlesource.com/585559
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489507}
[modify] https://crrev.com/6744c44fe0dc9773fcef488ba3a65f73246bac75/base/process/process_util_unittest.cc
[modify] https://crrev.com/6744c44fe0dc9773fcef488ba3a65f73246bac75/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b0f7d7b025a1171ce15203c9f4cce83f16b88d2

commit 0b0f7d7b025a1171ce15203c9f4cce83f16b88d2
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Jul 26 01:47:11 2017

fuchsia: Fix return value of Process::GetAppOutputWithExitCode()

Oops, I messed this up when I first wrote it. It's almost parallel to
GetAppOutput(), but as tested by the second run in
ProcessUtilTest.GetAppOutputWithExitCode, the return value is true if
the process ran, but the process need not have an exit code of 0.

Ref: https://cs.chromium.org/chromium/src/base/process/process_util_unittest.cc?l=852

Bug: 706592
Change-Id: I4e553fe19c7fbc365ca515ae15ac628e949ede01
Reviewed-on: https://chromium-review.googlesource.com/585688
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489522}
[modify] https://crrev.com/0b0f7d7b025a1171ce15203c9f4cce83f16b88d2/base/process/launch_fuchsia.cc
[modify] https://crrev.com/0b0f7d7b025a1171ce15203c9f4cce83f16b88d2/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8ac35950fdea5d0292544618a23709d2558a12e

commit c8ac35950fdea5d0292544618a23709d2558a12e
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Jul 26 21:32:52 2017

fuchsia: Re-exclude posix/unix_domain_socket

https://chromium-review.googlesource.com/c/580543 semi-accidentally
started including this in the Fuchsia build by renaming it from _linux
to generic posix/. It may be usable on Fuchsia too, but for now
re-exclude it to make the build compile again.

NOTRY=true

Bug: 706592, 738275,  748568 
Change-Id: I46c33bec5736a9ae2b3aa3afbc52aa0752270ad5
Reviewed-on: https://chromium-review.googlesource.com/587091
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489760}
[modify] https://crrev.com/c8ac35950fdea5d0292544618a23709d2558a12e/base/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05b3b6349f8febd0d4bbda554962514c1913876e

commit 05b3b6349f8febd0d4bbda554962514c1913876e
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Jul 27 00:26:50 2017

fuchsia: Support running on hardware

Adds a '--device' flag to Fuchsia run scripts. This causes the script
to run the Fuchsia SDK's bootserver instead of launching QEMU. If a
configured device is then connected to the bootserver the kernel and
boot image are sent to the device, and the tests run by autorun, the
same as in the QEMU case. (Press Alt-F1 to switch to 'debuglog' to see
the output on-device.)

Bug:  707029 , 706592,  749242 
Change-Id: I0a84885232463ee4cf316c6399edd6155ce97536
Reviewed-on: https://chromium-review.googlesource.com/585411
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489812}
[modify] https://crrev.com/05b3b6349f8febd0d4bbda554962514c1913876e/build/fuchsia/test_runner.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec8b0b3a1c8a354f075369c5e388983672e323d6

commit ec8b0b3a1c8a354f075369c5e388983672e323d6
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Jul 27 01:01:00 2017

fuchsia: Allocate only the non-guard-page size of physical pages in heap profiler

In a previous confused CL
https://chromium-review.googlesource.com/c/545155/, I allocated the VMO
with the size of the accessible bytes plus the size of the guard page
(map_size). This is unnecessary, instead, vmo_create() only the size
that will be writable and map that, leaving the guard page size unmapped
at the end of the buffer.

No behaviour change.

Bug: 706592
Change-Id: I61e6b28b0ab4e2a65c7fb5196423dc45dfb912cd
Reviewed-on: https://chromium-review.googlesource.com/585777
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489822}
[modify] https://crrev.com/ec8b0b3a1c8a354f075369c5e388983672e323d6/base/trace_event/heap_profiler_allocation_register_posix.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/286466404ae95349a01738dfaef53fab1c93d618

commit 286466404ae95349a01738dfaef53fab1c93d618
Author: Scott Graham <scottmg@chromium.org>
Date: Sat Jul 29 01:59:20 2017

fuchsia: enable some ProcessUtilTest that work

(The last three are probably perma-disabled because mx_task_kill()
doesn't support an exit code. Those should be #if'd out instead, but
will wait on doing that until 1) we're sure they won't be implementable,
and 2) maybe with a block of other tests in the same situation.)

Bug: 706592
Change-Id: Icc7f88f6da903328fce3be93cfb3074516f640fc
Reviewed-on: https://chromium-review.googlesource.com/592140
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490578}
[modify] https://crrev.com/286466404ae95349a01738dfaef53fab1c93d618/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/324443a60943a320dc0074bdd8b4b1524493166d

commit 324443a60943a320dc0074bdd8b4b1524493166d
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Jul 31 23:08:42 2017

fuchsia: Stub a few functions to get Debug linking

AmountOfAvailablePhysicalMemoryImpl isn't currently implementable as
there's no system call for it.

The GPU collection ones, there's no GPU access set up yet at all.

Bug: 706592, 707031,  743296 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib161bf45120ff13127ad198d57017ffc6d7c9a79
Reviewed-on: https://chromium-review.googlesource.com/592642
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490815}
[modify] https://crrev.com/324443a60943a320dc0074bdd8b4b1524493166d/base/sys_info_fuchsia.cc
[modify] https://crrev.com/324443a60943a320dc0074bdd8b4b1524493166d/gpu/config/BUILD.gn
[add] https://crrev.com/324443a60943a320dc0074bdd8b4b1524493166d/gpu/config/gpu_info_collector_fuchsia.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e929b08cf279a77f17525d88ed85b038f3c5ef7e

commit e929b08cf279a77f17525d88ed85b038f3c5ef7e
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Wed Aug 02 01:55:40 2017

Fuchsia: enable MemoryMappedFile tests

Fuchsia: enable MemoryMappedFile tests
Fuchsia now supports mmap() for tmpfs, so these tests Just Work.


Bug:  746051 , 706592
Change-Id: I208c88852bcd22cec0b03f8c2578c71fd305c663
Reviewed-on: https://chromium-review.googlesource.com/596611
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491205}
[modify] https://crrev.com/e929b08cf279a77f17525d88ed85b038f3c5ef7e/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abf2e85ada60eb318e91976a8845288d0cec959f

commit abf2e85ada60eb318e91976a8845288d0cec959f
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Wed Aug 02 19:41:09 2017

Emit symbolizable backtraces on DCHECK/LOG(FATAL) under Fuchsia.

This adds code to query the process' debug symbol maps for offsets
and produces an externally symbolizable backtrace using that data.

R: thakis@chromium.org,wez@chromium.org
CC: jamesr@chromium.org
Bug: 706592
Change-Id: I7b3257ff154671b2eb1c90f7ab91947f55cfa873
Reviewed-on: https://chromium-review.googlesource.com/575290
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491470}
[modify] https://crrev.com/abf2e85ada60eb318e91976a8845288d0cec959f/base/debug/stack_trace_fuchsia.cc
[modify] https://crrev.com/abf2e85ada60eb318e91976a8845288d0cec959f/build/fuchsia/test_runner.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec2506fb061589c01820bd4ef4444f38bf3f47f0

commit ec2506fb061589c01820bd4ef4444f38bf3f47f0
Author: Wez <wez@chromium.org>
Date: Thu Aug 03 17:49:18 2017

Fix LaunchProcess to clone stdio descriptors even with fds_to_map.

Previously we would only clone the stdio FDs into the child if the
option.fds_to_map was empty. Callers instead expect that stdio FDs will
always be cloned into the child, but can also be overridden via the
fds_to_map option.

Bug: 706592
Change-Id: Ifd401b75ceda3b8fe1fb69604ff361ba50b2f40d
Reviewed-on: https://chromium-review.googlesource.com/598749
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491782}
[modify] https://crrev.com/ec2506fb061589c01820bd4ef4444f38bf3f47f0/base/process/launch_fuchsia.cc
[modify] https://crrev.com/ec2506fb061589c01820bd4ef4444f38bf3f47f0/base/process/process_util_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/483a4433d8eb95b841adbefe3b306cb8521a3494

commit 483a4433d8eb95b841adbefe3b306cb8521a3494
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Aug 03 20:14:12 2017

Roll Fuchsia SDK to bb4f07c0178ae528aeb9d284333e3d0bf59a0eb7

Notably includes
https://fuchsia.googlesource.com/magenta/+/396b28ef2039e962c19f9d972d72ed56aa665d5b
which makes the POSIX-y impl of PartitionAlloc work on Fuchsia, so
enable those tests.

TBR=wez@chromium.org

Bug: 706592, 707030
Change-Id: I81969597e87969c755afb6e538bccf5ab1cf1eb9
Reviewed-on: https://chromium-review.googlesource.com/600987
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491825}
[modify] https://crrev.com/483a4433d8eb95b841adbefe3b306cb8521a3494/DEPS
[modify] https://crrev.com/483a4433d8eb95b841adbefe3b306cb8521a3494/testing/buildbot/filters/fuchsia.base_unittests.filter

Normalizing the bug description, to match the ones for other directories.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb183a5800e457d7a4ac756568eb9d37545cc773

commit bb183a5800e457d7a4ac756568eb9d37545cc773
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Aug 09 03:47:34 2017

fuchsia: Enable PersistentHistogramAllocatorTest.*

These started working when mmap was implemented for more file systems.

Bug: 706592
Change-Id: I553454626262a2da595d42c586c231de8cfc451a
Reviewed-on: https://chromium-review.googlesource.com/607127
Commit-Queue: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492815}
[modify] https://crrev.com/bb183a5800e457d7a4ac756568eb9d37545cc773/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79fffc046f9c446746f54cb9f188af76498adeb6

commit 79fffc046f9c446746f54cb9f188af76498adeb6
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Aug 09 05:08:18 2017

fuchsia: Remove unnecessary filtering of VerifyPathControlledByUserTest

These were #if'd out in
https://chromium-review.googlesource.com/c/569845, so the .filter
suppression is no longer required.

Bug: 706592
Change-Id: I2fed75128d8f0f0f277c93f2cf4a7498073c32b2
Reviewed-on: https://chromium-review.googlesource.com/607349
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492830}
[modify] https://crrev.com/79fffc046f9c446746f54cb9f188af76498adeb6/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1481d40c9c6c45d99c489cfd5091384a4a1631f6

commit 1481d40c9c6c45d99c489cfd5091384a4a1631f6
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Aug 09 06:48:34 2017

fuchsia: Fix Process op= and ctor for move operations

This fixes ProcessTest.Move.

Bug: 706592
Change-Id: I56842bf6bf107f41e4bde169a72b0e2744c10295
Reviewed-on: https://chromium-review.googlesource.com/607050
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492866}
[modify] https://crrev.com/1481d40c9c6c45d99c489cfd5091384a4a1631f6/base/process/process_fuchsia.cc
[modify] https://crrev.com/1481d40c9c6c45d99c489cfd5091384a4a1631f6/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9795d24b6e8882c5ca0a9b0348a0cb36fd8258b6

commit 9795d24b6e8882c5ca0a9b0348a0cb36fd8258b6
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Aug 09 06:49:58 2017

fuchsia: Enable FilePersistentMemoryAllocatorTest.*

Some more that started working when mmap() for other file systems was
implemented.

Bug: 706592
Change-Id: Ib3a422613911573fb69cb55018ced0195c0f95be
Reviewed-on: https://chromium-review.googlesource.com/607096
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492868}
[modify] https://crrev.com/9795d24b6e8882c5ca0a9b0348a0cb36fd8258b6/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a43eb8a10f17beaf919046c6a2cb4a128c74f41

commit 6a43eb8a10f17beaf919046c6a2cb4a128c74f41
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Aug 09 07:31:09 2017

fuchsia: enable ActivityTrackerTest.*

These would have started working either when mmap on more file systems
was supported, or when mprotect with PROT_NONE was implemented. Enable
them now as they seem to pass.

Bug: 706592
Change-Id: Ic570ba37867e2f4ecc192e9a3d3cbc82616143b2
Reviewed-on: https://chromium-review.googlesource.com/607045
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492888}
[modify] https://crrev.com/6a43eb8a10f17beaf919046c6a2cb4a128c74f41/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/610ec6f9d3fb9ba54632036eaf2fdf2413860a03

commit 610ec6f9d3fb9ba54632036eaf2fdf2413860a03
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Aug 09 15:21:31 2017

fuchsia: Disable LoggingTest.CheckCausesDistinctBreakpoints due to fork() reliance

This test is implemented by using fork() to inherit fds to the child,
but fork() isn't supported on Fuchsia. Since the functionality to make
CHECK locations distinct isn't too important, just disable this test on
Fuchsia (as it is on NaCl and iOS).

Bug: 706592
Change-Id: I830a55fe7587b54258f296be4da388d2384e5ad0
Reviewed-on: https://chromium-review.googlesource.com/607410
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492989}
[modify] https://crrev.com/610ec6f9d3fb9ba54632036eaf2fdf2413860a03/base/logging_unittest.cc
[modify] https://crrev.com/610ec6f9d3fb9ba54632036eaf2fdf2413860a03/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78b733135719f3a6784eb6f0c2ae902dd12a792b

commit 78b733135719f3a6784eb6f0c2ae902dd12a792b
Author: Wez <wez@chromium.org>
Date: Wed Aug 09 18:41:59 2017

Provide base::ScopedMxHandle helper for use in Fuchsia implementations.

base::ScopedMxHandle uses ScopedGeneric to manage an mx_handle_t.

ScopedGeneric is updated to provide a receive() API, allowing its use as
a direct out-parameter, since most Magenta APIs return handles that way.

Bug:  740791 , 706592
Change-Id: I1491fe3a3eba354e4dd4ebf2d3feae6759e3f87b
Reviewed-on: https://chromium-review.googlesource.com/602394
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493073}
[modify] https://crrev.com/78b733135719f3a6784eb6f0c2ae902dd12a792b/base/BUILD.gn
[add] https://crrev.com/78b733135719f3a6784eb6f0c2ae902dd12a792b/base/fuchsia/scoped_mx_handle.h
[modify] https://crrev.com/78b733135719f3a6784eb6f0c2ae902dd12a792b/base/memory/shared_memory_fuchsia.cc
[modify] https://crrev.com/78b733135719f3a6784eb6f0c2ae902dd12a792b/base/memory/shared_memory_unittest.cc
[modify] https://crrev.com/78b733135719f3a6784eb6f0c2ae902dd12a792b/base/message_loop/message_pump_fuchsia.cc
[modify] https://crrev.com/78b733135719f3a6784eb6f0c2ae902dd12a792b/base/message_loop/message_pump_fuchsia.h
[modify] https://crrev.com/78b733135719f3a6784eb6f0c2ae902dd12a792b/base/process/process.h
[modify] https://crrev.com/78b733135719f3a6784eb6f0c2ae902dd12a792b/base/process/process_fuchsia.cc
[modify] https://crrev.com/78b733135719f3a6784eb6f0c2ae902dd12a792b/base/scoped_generic.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1812f18bd6f54403afaf9c12f4c1c035944810b

commit e1812f18bd6f54403afaf9c12f4c1c035944810b
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Aug 09 19:10:43 2017

fuchsia: Make PlatformThread::SetName communicate with tracked_objects

Fixes TrackedObjectsTest.ReuseRetiredThreadData.

Bug: 706592
Change-Id: Iaa18eab58237c26c91b96fc020c4d87c0d5402e6
Reviewed-on: https://chromium-review.googlesource.com/607156
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493085}
[modify] https://crrev.com/e1812f18bd6f54403afaf9c12f4c1c035944810b/base/threading/platform_thread_fuchsia.cc
[modify] https://crrev.com/e1812f18bd6f54403afaf9c12f4c1c035944810b/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcea246e3283d79c160bc71d707610afac10eef2

commit fcea246e3283d79c160bc71d707610afac10eef2
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Aug 09 21:53:53 2017

fuchsia: Shuffle filter file for task_kill-related failures

Bug: 706592, 753490
Change-Id: I0468e996471029d271225886c00493d92c8f30fc
Reviewed-on: https://chromium-review.googlesource.com/607394
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493155}
[modify] https://crrev.com/fcea246e3283d79c160bc71d707610afac10eef2/base/process/process_fuchsia.cc
[modify] https://crrev.com/fcea246e3283d79c160bc71d707610afac10eef2/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1603c32c3ba7564dae9dd1055c58c4a0dad6c775

commit 1603c32c3ba7564dae9dd1055c58c4a0dad6c775
Author: Wez <wez@chromium.org>
Date: Thu Aug 10 05:24:54 2017

Support passing native platform handles via LaunchProcess.

Since some types of Fuchsia handle (e.g. channels) cannot be duplicated,
LaunchProcess transfers the supplied handles, requiring the caller to
provide copies of any handles it wishes to retain.

Callers must provide a unique identifier for each handle which is
to be transferred, which the client process can use to retrieve the
handle via mx_get_startup_handle().

This will be used to pass the initial Mojo channel to child processes.

Bug:  740791 , 706592
Change-Id: I4f9028db730533605142b4911607efb1e0e3c33a
Reviewed-on: https://chromium-review.googlesource.com/602089
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493265}
[modify] https://crrev.com/1603c32c3ba7564dae9dd1055c58c4a0dad6c775/base/metrics/field_trial.cc
[modify] https://crrev.com/1603c32c3ba7564dae9dd1055c58c4a0dad6c775/base/metrics/field_trial.h
[modify] https://crrev.com/1603c32c3ba7564dae9dd1055c58c4a0dad6c775/base/process/launch.h
[modify] https://crrev.com/1603c32c3ba7564dae9dd1055c58c4a0dad6c775/base/process/launch_fuchsia.cc
[modify] https://crrev.com/1603c32c3ba7564dae9dd1055c58c4a0dad6c775/base/process/process_util_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a7c7272fa05de95cf66d9a7b615458846185d67

commit 9a7c7272fa05de95cf66d9a7b615458846185d67
Author: Wez <wez@chromium.org>
Date: Thu Aug 10 06:29:27 2017

Implement a MessageLoopForIO::WatchMxHandle API under Fuchsia.

WatchMxHandle() follows the design of the WatchFileDescriptor() API
provided by MessageLoopForIO across the POSIX platforms, and now serves
as the underlying implementation for watching file-descriptors under
Fuchsia.

This will be used for asynchronous I/O on native Fuchsia primitives,
e.g. in the Mojo IPC implementation, which will use Fuchsia "channels".

This CL also fixes the behaviour of StopWatchingFileDescriptor() from
within an event callback, and an mxio leak arising from use of that
API, and pulls in sergeyu's test for StopWatchingFileDescriptor(), from
https://chromium-review.googlesource.com/c/608983

Bug: 706592,  740791 
Change-Id: I675c5cfe8a443d48863361028c0f9222fdde8182
Reviewed-on: https://chromium-review.googlesource.com/602396
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493307}
[modify] https://crrev.com/9a7c7272fa05de95cf66d9a7b615458846185d67/base/message_loop/message_loop.cc
[modify] https://crrev.com/9a7c7272fa05de95cf66d9a7b615458846185d67/base/message_loop/message_loop.h
[modify] https://crrev.com/9a7c7272fa05de95cf66d9a7b615458846185d67/base/message_loop/message_loop_io_posix_unittest.cc
[modify] https://crrev.com/9a7c7272fa05de95cf66d9a7b615458846185d67/base/message_loop/message_pump_fuchsia.cc
[modify] https://crrev.com/9a7c7272fa05de95cf66d9a7b615458846185d67/base/message_loop/message_pump_fuchsia.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d92d6e30ca54d4f4c32fcfced4dd6803ac034486

commit d92d6e30ca54d4f4c32fcfced4dd6803ac034486
Author: Scott Graham <scottmg@chromium.org>
Date: Tue Aug 15 17:36:34 2017

fuchsia: fix --dry-run in runner_common.py

After https://chromium.googlesource.com/chromium/src.git/+/ebb64f8e585ffb3923eee174c080f5ead800e6fb

Bug: 706592,  755016 
Change-Id: I68e582dee653be32d4217ba1a9e07946c4ec9885
Reviewed-on: https://chromium-review.googlesource.com/614870
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494430}
[modify] https://crrev.com/d92d6e30ca54d4f4c32fcfced4dd6803ac034486/build/fuchsia/runner_common.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05407bb2c6452b139d9afd426691dac058602bd7

commit 05407bb2c6452b139d9afd426691dac058602bd7
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Aug 16 11:19:20 2017

Fix MessagePumpFuchsia to avoid handling the same event multiple times.

Previously, when MX_ERR_TIMED_OUT is retuned from mx_port_wait() the
message pump would handle it the same way as MX_OK, i.e. it would
process the content of packet parameter. Due to this issue the pump
would handles the same packet received from the port more than once,
sometimes calling a watch controller that's already stopped or deleted.

Bug:  731302 , 706592
Change-Id: I80f64ea9a00c3b2ea6344ce31be5d6339e37d904
Reviewed-on: https://chromium-review.googlesource.com/615730
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494747}
[modify] https://crrev.com/05407bb2c6452b139d9afd426691dac058602bd7/base/message_loop/message_pump_fuchsia.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec32f1828e254a45836f30fca990e58bcc0fd077

commit ec32f1828e254a45836f30fca990e58bcc0fd077
Author: Wez <wez@chromium.org>
Date: Thu Aug 17 02:58:25 2017

Fix base::Process::Current().Pid() and .Terminate().

Pid() and Terminate() became broken on base::Process instances returned
by base::Process::Current() when the calling-process was special-cased,
since those calls continued to rely upon the |process_| handle, which
was then null, rather than calling mx_process_self().

Also fix GetTerminationStatus() to correctly zero-out |exit_code|, and
to avoid touching it when it is null.

Bug: 706592, 753490
Change-Id: I8b5c211b81e5156784e92eff09578201f0b134c0
Reviewed-on: https://chromium-review.googlesource.com/618180
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495060}
[modify] https://crrev.com/ec32f1828e254a45836f30fca990e58bcc0fd077/base/process/kill_fuchsia.cc
[modify] https://crrev.com/ec32f1828e254a45836f30fca990e58bcc0fd077/base/process/process_fuchsia.cc
[modify] https://crrev.com/ec32f1828e254a45836f30fca990e58bcc0fd077/base/process/process_unittest.cc
[modify] https://crrev.com/ec32f1828e254a45836f30fca990e58bcc0fd077/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f8498b3987d2036fb8f7e578c1d24e4a046e163

commit 8f8498b3987d2036fb8f7e578c1d24e4a046e163
Author: Wez <wez@chromium.org>
Date: Fri Aug 18 04:26:34 2017

Fix SysInfo::AmountOfVirtualMemory and PlatformSharedBuffer::Map().

The meaning of base::SysInfo::AmountOfVirtualMemory() isn't well-
specified (e.g. under Windows it returns the calling process' maximum
address-space size, while under POSIX it returns the maximum memory
available via brk()-based malloc()). Under Fuchsia the Virtual Memory
Address Range is practically unlimited, so rather than return the size
of e.g. the root VMAR object of the calling process, we just return
zero (meaning "unlimited").

PlatformSharedBuffer::Map() was previously DCHECK()ing that mapping the
underlying SharedMemory object succeeded, and then always returning
"success" to the caller. This is fixed so that callers, including the
Mojo PlatformSharedBufferTest.TooBig test, can handle the Map()
failure.

The PlatformSharedBuffer.TooBig test is fixed to actually attempt to
Create() a too-big shared buffer, rather than a zero-byte one, and the
test is removed from the Fuchsia test filters.

Bug:  740791 , 706592
Change-Id: I76d3f1e4201c8cc6c143e469e5d1f081b359aa38
Reviewed-on: https://chromium-review.googlesource.com/620293
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495459}
[modify] https://crrev.com/8f8498b3987d2036fb8f7e578c1d24e4a046e163/base/sys_info_fuchsia.cc
[modify] https://crrev.com/8f8498b3987d2036fb8f7e578c1d24e4a046e163/base/sys_info_posix.cc
[modify] https://crrev.com/8f8498b3987d2036fb8f7e578c1d24e4a046e163/mojo/edk/embedder/platform_shared_buffer.cc
[modify] https://crrev.com/8f8498b3987d2036fb8f7e578c1d24e4a046e163/mojo/edk/embedder/platform_shared_buffer_unittest.cc
[modify] https://crrev.com/8f8498b3987d2036fb8f7e578c1d24e4a046e163/testing/buildbot/filters/fuchsia.mojo_system_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bd06b00330012cb88137b11a1311814d653cd41

commit 7bd06b00330012cb88137b11a1311814d653cd41
Author: Sergey Ulanov <sergeyu@google.com>
Date: Fri Aug 18 18:15:40 2017

Add more unittests for MessageLoopForIO on POSIX.

Added two unittests that run timers and IO events on the same loop.
These tests would catch the issues like the one fixed in
crrev.com/494747 .

Bug: 706592
Change-Id: I553a4b0c6c6df3cd67ab918a0a1d1536d8cd04bd
Reviewed-on: https://chromium-review.googlesource.com/617842
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495621}
[modify] https://crrev.com/7bd06b00330012cb88137b11a1311814d653cd41/base/message_loop/message_loop_io_posix_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61ea11ee9494e1863fbf88819dceef85397e5ac5

commit 61ea11ee9494e1863fbf88819dceef85397e5ac5
Author: Scott Graham <scottmg@chromium.org>
Date: Fri Aug 18 20:22:15 2017

fuchsia: Stub process_metrics' GetSystemMemoryInfo

Needed for headless_shell in is_component_mode=true.

Bug: 706592,  743296 ,  746674 
Change-Id: Ic2fba5cad27a171542c36fb1ccae0168a93089e5
Reviewed-on: https://chromium-review.googlesource.com/621422
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495665}
[modify] https://crrev.com/61ea11ee9494e1863fbf88819dceef85397e5ac5/base/process/process_metrics.h
[modify] https://crrev.com/61ea11ee9494e1863fbf88819dceef85397e5ac5/base/process/process_metrics_fuchsia.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f13437045c172db8c914d7633dc26beedbcea110

commit f13437045c172db8c914d7633dc26beedbcea110
Author: Sergey Ulanov <sergeyu@google.com>
Date: Sat Aug 19 01:02:08 2017

Allow nested loop after Quit in Fuchsia and Default impls of MessagePump

Some unittests run a nested RunLoop after calling Quit() for the current
one. Fuchsia and Default implementations of MessagePump were not
handling this case properly (DCHECK in debug builds, hang in release).
Updated both implementations to handle this case consistently with
others. Also added a unittest.

Bug:  757093 , 706592
Change-Id: I9fabbe09a6ed2178316ec3ba4b2edd8e7b89dd3f
Reviewed-on: https://chromium-review.googlesource.com/622287
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495773}
[modify] https://crrev.com/f13437045c172db8c914d7633dc26beedbcea110/base/message_loop/message_loop_unittest.cc
[modify] https://crrev.com/f13437045c172db8c914d7633dc26beedbcea110/base/message_loop/message_pump_default.cc
[modify] https://crrev.com/f13437045c172db8c914d7633dc26beedbcea110/base/message_loop/message_pump_fuchsia.cc
[modify] https://crrev.com/f13437045c172db8c914d7633dc26beedbcea110/base/message_loop/message_pump_fuchsia.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e95a365bdbec8987d8fd5747c47c3cbc25eb84b

commit 8e95a365bdbec8987d8fd5747c47c3cbc25eb84b
Author: Scott Graham <scottmg@chromium.org>
Date: Tue Aug 22 19:47:20 2017

fuchsia: filter TaskSchedulerWorkerPoolImplTest.PostDelayedTask which relies on questionable timing assumption

TBR=jamesr@chromium.org

Bug: 706592
Change-Id: I3d23ddee7c364c4f978d08120f2d30b3b782eac4
Reviewed-on: https://chromium-review.googlesource.com/627100
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496411}
[modify] https://crrev.com/8e95a365bdbec8987d8fd5747c47c3cbc25eb84b/testing/buildbot/filters/fuchsia.base_unittests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34b6bbd8fca3beddfb1894a9299c1b02aaa741f1

commit 34b6bbd8fca3beddfb1894a9299c1b02aaa741f1
Author: Sergey Ulanov <sergeyu@google.com>
Date: Fri Aug 25 21:15:01 2017

Make HANDLE_EINTR a no-op on Fuchsia.

Fuchsia doesn't have signals, so the is no need to handle EINTR. Updated
HANDLE_EINTR to make it no-op.

Bug: 706592
Change-Id: Idbfd749713827a438a7b753e8f1ad9d81897a56b
Reviewed-on: https://chromium-review.googlesource.com/636403
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497536}
[modify] https://crrev.com/34b6bbd8fca3beddfb1894a9299c1b02aaa741f1/base/posix/eintr_wrapper.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76d447efac192f76bdf193371ee1130d796f57c6

commit 76d447efac192f76bdf193371ee1130d796f57c6
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Oct 18 00:32:30 2017

fuchsia: Stub ProcessMetrics::GetWorkingSetKBytes

Referenced in some configs that we weren't trying to build before.

Bug: 706592
Change-Id: Ieae810b39ef6c99a2aedbda8db12763e81ff692a
Reviewed-on: https://chromium-review.googlesource.com/724422
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509626}
[modify] https://crrev.com/76d447efac192f76bdf193371ee1130d796f57c6/base/process/process_metrics_fuchsia.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a93cf8bfc9894215ed68a1b3cc86e8a981cec19d

commit a93cf8bfc9894215ed68a1b3cc86e8a981cec19d
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Dec 01 21:52:53 2017

[Fuchsia] Add RaiseProcessToHighPriority() stub

Component build was broken on Fuchsia because
base::RaiseProcessToHighPriority() was not defined.

Bug: 706592
Change-Id: Ie88ffa6c7ad09729249417c6fb094e2194026854
Reviewed-on: https://chromium-review.googlesource.com/804210
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521076}
[modify] https://crrev.com/a93cf8bfc9894215ed68a1b3cc86e8a981cec19d/base/process/launch_fuchsia.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/449cb549b0e6e5c0863971443c609f08a280ae9e

commit 449cb549b0e6e5c0863971443c609f08a280ae9e
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Dec 13 19:41:03 2017

[Fuchsia] Bugfixes in stacktrace handling

1. Updated the max limit on number for entries in link map when
   reporting a stack trace from 64 to 512. 64 is not enough, e.g.
   component builds of content_unittests load 158 libs.
2. Fixed the code to handle the case when the limit is reached
   Previously that code was using sizeof() to get array size.
3. Update regex in runner_common.py to handle the case when pc_offset
   part is missing.

Bug: 706592
Change-Id: Iededea88c86206b247948c789043c4f4dfd8a8d9
Reviewed-on: https://chromium-review.googlesource.com/815155
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523847}
[modify] https://crrev.com/449cb549b0e6e5c0863971443c609f08a280ae9e/base/debug/stack_trace_fuchsia.cc
[modify] https://crrev.com/449cb549b0e6e5c0863971443c609f08a280ae9e/build/fuchsia/runner_common.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b050130deb6696e4e1904d11f17febc1eb2190ae

commit b050130deb6696e4e1904d11f17febc1eb2190ae
Author: Wez <wez@chromium.org>
Date: Fri Mar 09 05:18:45 2018

Fix base::LogMessage to report the process Id under Fuchsia.

Previously LogMessage would use the POSIX getpid() API, which is not
a real implementation under Fuchsia.

Bug: 706592
Change-Id: I9d2b2f06efcecfea9457f7d96295457de2ef888d
Reviewed-on: https://chromium-review.googlesource.com/954420
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542034}
[modify] https://crrev.com/b050130deb6696e4e1904d11f17febc1eb2190ae/base/logging.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e13b0df320193b16a351e78002262f8d1eb5bc6

commit 9e13b0df320193b16a351e78002262f8d1eb5bc6
Author: Wez <wez@chromium.org>
Date: Thu May 03 15:21:10 2018

Enable base_unittests on the commit queue and waterfall.

Bug: 706592
Change-Id: I5e399e76e3ca98ee80d76aa4fd92b2d3bba60d39
Reviewed-on: https://chromium-review.googlesource.com/976085
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555737}
[modify] https://crrev.com/9e13b0df320193b16a351e78002262f8d1eb5bc6/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/9e13b0df320193b16a351e78002262f8d1eb5bc6/testing/buildbot/test_suite_exceptions.pyl

Propose that the remaining work to complete this task is to work through the remaining base_unittests filters, disabling the tests or fixing them, as appropriate.

Assigning to fdegans@ to follow-up on the work described in comment #176.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8225bf8f08b77933b2cab3008515cf98992fa75b

commit 8225bf8f08b77933b2cab3008515cf98992fa75b
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Wed Jun 20 18:50:41 2018

Fuchsia: Remove the base unittests filter.

All the remaining tests have been manually disabled.

Bug: 706592
Change-Id: I043163517817794891f8a31d6f09913ca74b500c
Reviewed-on: https://chromium-review.googlesource.com/1105020
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568955}
[modify] https://crrev.com/8225bf8f08b77933b2cab3008515cf98992fa75b/docs/fuchsia_build_instructions.md
[modify] https://crrev.com/8225bf8f08b77933b2cab3008515cf98992fa75b/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/8225bf8f08b77933b2cab3008515cf98992fa75b/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/8225bf8f08b77933b2cab3008515cf98992fa75b/testing/buildbot/filters/BUILD.gn
[delete] https://crrev.com/f633a5703946d0301949c8e0d82f904d85c66793/testing/buildbot/filters/fuchsia.base_unittests.filter
[modify] https://crrev.com/8225bf8f08b77933b2cab3008515cf98992fa75b/testing/buildbot/test_suites.pyl

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42c014d0916cb84be9420e0f3542a0112bc7b797

commit 42c014d0916cb84be9420e0f3542a0112bc7b797
Author: Wez <wez@chromium.org>
Date: Thu Jun 21 11:36:14 2018

Remove extra Fuchsia-specific logging from Process and TestLauncher.

The issues that this logging was introduced to diagnose are understood
and/or resolved, so it can be removed.

Also clean up some OS_POSIX && !OS_FUCHSIA preprocessor conditionals,
and migrate TestLauncher to use the zx::job container from the SDK.

Bug:  755282 ,  750370 , 738275, 706592
Change-Id: Iedfaa62684a0b6e8524a456766186b4122e98ae0
Reviewed-on: https://chromium-review.googlesource.com/1108483
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569219}
[modify] https://crrev.com/42c014d0916cb84be9420e0f3542a0112bc7b797/base/process/process_fuchsia.cc
[modify] https://crrev.com/42c014d0916cb84be9420e0f3542a0112bc7b797/base/test/BUILD.gn
[modify] https://crrev.com/42c014d0916cb84be9420e0f3542a0112bc7b797/base/test/launcher/test_launcher.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f130981cbd9032229906a0171bb87aa2c6fe2abb

commit f130981cbd9032229906a0171bb87aa2c6fe2abb
Author: Wez <wez@chromium.org>
Date: Sat Nov 03 05:42:24 2018

Add FDIO_EVT_PEER_CLOSED to WatchFileDescriptor(WATCH_READ) events.

WatchFileDescriptor(WATCH_READ) should result in
OnFileCanReadWithoutBlocking() if the descriptor is at end-of-stream
when it is invoked, to wake the caller to detect that by attempting to
read and receiving zero bytes.

Bug:  898938 , 706592, 884299
Change-Id: I77662fe77eb8fb988089640a75a60d470770b78f
Reviewed-on: https://chromium-review.googlesource.com/c/1316672
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605154}
[modify] https://crrev.com/f130981cbd9032229906a0171bb87aa2c6fe2abb/base/message_loop/message_pump_fuchsia.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/088e95617862c91da15e97a233e59811b798a95f

commit 088e95617862c91da15e97a233e59811b798a95f
Author: Wez <wez@chromium.org>
Date: Sat Nov 03 06:08:28 2018

Revert "Add FDIO_EVT_PEER_CLOSED to WatchFileDescriptor(WATCH_READ) events."

This reverts commit f130981cbd9032229906a0171bb87aa2c6fe2abb.

Reason for revert: Doesn't actually fix anything. >.<

Original change's description:
> Add FDIO_EVT_PEER_CLOSED to WatchFileDescriptor(WATCH_READ) events.
> 
> WatchFileDescriptor(WATCH_READ) should result in
> OnFileCanReadWithoutBlocking() if the descriptor is at end-of-stream
> when it is invoked, to wake the caller to detect that by attempting to
> read and receiving zero bytes.
> 
> Bug:  898938 , 706592, 884299
> Change-Id: I77662fe77eb8fb988089640a75a60d470770b78f
> Reviewed-on: https://chromium-review.googlesource.com/c/1316672
> Commit-Queue: Wez <wez@chromium.org>
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605154}

TBR=wez@chromium.org,sergeyu@chromium.org,fdegans@chromium.org

Change-Id: I1a98ece4b90de54c2c789dee64c226eb92bcda38
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  898938 , 706592, 884299
Reviewed-on: https://chromium-review.googlesource.com/c/1316675
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605157}
[modify] https://crrev.com/088e95617862c91da15e97a233e59811b798a95f/base/message_loop/message_pump_fuchsia.cc

Lowering priority and making available again.
Most of the groundwork is done. We are left with Fuchsia-specific test failures that will need fixing but most are dependent on system fixes or implementations.