New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706589 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 705686
issue 708279
issue 708287

Blocking:
issue 718860
issue 731255



Sign in to add a comment

simplified mushrome display management

Project Member Reported by rjkroege@chromium.org, Mar 29 2017

Issue description

Wrapper bug for the simplified mushrome display management scheme: mojo proxies for NativeDisplayDelegate and NativeDisplayObserver

 
Labels: mustash-display

Comment 2 by sky@chromium.org, Apr 4 2017

Kyle and myself talked about this in detail. Here's my understanding of what we're going to do (Kyle is working on a design doc):

ash will connect to the gpu/viz service to observe display related changes. The connection will be done in an implementation of NativeDisplayDelegate. ash will use a custom DisplayManager::Delegate to update the necessary state in ash as well informing mus of state that only ash knows about but mus needs to know as well (Kyle mentioned scale_factor as one).

Currently when displays are added/removed mus tells ash via the WindowManager interface. When a display is added mus creates the window and embeds ash in it. This will change so that ash can create windows corresponding to roots and tell mus about it.

Currently ash's DisplayManager::Delegate implementation is WindowTreeHostManager. We need to make WTHM work with both classic ash, and mushrome/mash.

Display settings change various display state. Display settings will talk to an ash specific interface that updates internal ash state and then updates mus.

Comment 3 by sky@chromium.org, Apr 4 2017

Blockedon: 708279

Comment 4 by sky@chromium.org, Apr 4 2017

Blockedon: 708287
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f47442541a1b4292f7c428717a90a15712f9c62b

commit f47442541a1b4292f7c428717a90a15712f9c62b
Author: kylechar <kylechar@chromium.org>
Date: Mon Apr 10 18:01:15 2017

Add Mojo NativeDisplayDelegate / NativeDisplayObserver.

For mushrome, in order to have screen management in one process and
Ozone in another process we need a mojom::NativeDisplayDelegate and
implementation. The ForwardingDisplayDelegate will be created in ash and
will connect to mus-ws. In mus-ws ScreenManagerForwarding will own the
real NativeDisplayDelegate. A mojom::NativeDisplayObserver works in the
other direction.

This only implements the Ozone DRM parts of NativeDisplayDelegate. Most
of the other methods exist for the X11 implementation which isn't used.

BUG= 706589 

Review-Url: https://codereview.chromium.org/2805633004
Cr-Commit-Position: refs/heads/master@{#463321}

[modify] https://crrev.com/f47442541a1b4292f7c428717a90a15712f9c62b/services/ui/display/BUILD.gn
[add] https://crrev.com/f47442541a1b4292f7c428717a90a15712f9c62b/services/ui/display/screen_manager_forwarding.cc
[add] https://crrev.com/f47442541a1b4292f7c428717a90a15712f9c62b/services/ui/display/screen_manager_forwarding.h
[modify] https://crrev.com/f47442541a1b4292f7c428717a90a15712f9c62b/services/ui/manifest.json
[modify] https://crrev.com/f47442541a1b4292f7c428717a90a15712f9c62b/ui/display/manager/BUILD.gn
[add] https://crrev.com/f47442541a1b4292f7c428717a90a15712f9c62b/ui/display/manager/forwarding_display_delegate.cc
[add] https://crrev.com/f47442541a1b4292f7c428717a90a15712f9c62b/ui/display/manager/forwarding_display_delegate.h
[modify] https://crrev.com/f47442541a1b4292f7c428717a90a15712f9c62b/ui/display/mojo/BUILD.gn
[add] https://crrev.com/f47442541a1b4292f7c428717a90a15712f9c62b/ui/display/mojo/native_display_delegate.mojom

Owner: sky@chromium.org
Cc: kylec...@chromium.org

Comment 8 by sky@chromium.org, Apr 18 2017

Blockedon: 647421

Comment 9 by wutao@chromium.org, Apr 21 2017

Cc: wutao@chromium.org
Cc: moshayedi@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a81beada89c87c32e6ac4faea3e2823985994dc

commit 0a81beada89c87c32e6ac4faea3e2823985994dc
Author: kylechar <kylechar@chromium.org>
Date: Tue Apr 25 13:21:39 2017

Make ForwardingDisplayDelegate initially sync.

In ash::Shell::Init() there is an assumption that NativeDisplayDelegate
is synchronous. This is accomplished through a couple of hacks with
Ozone DRM to load the current DisplaySnapshots in the browser process.

We need to do something similar for mushrome. This is a quick workaround
that makes a synchronous call from ash to mus-ws to get the list of
display snapshots. After Shell::Init() has finished and
ForwardingDisplaySnapshot has received an OnConfigurationChanged() IPC
it resumes making calls over Mojo.

This isn't ideal because it will add significant delay to ash
initialization. It will work in the short term for mushrome though.

BUG= 706589 

Review-Url: https://codereview.chromium.org/2835933005
Cr-Commit-Position: refs/heads/master@{#466962}

[modify] https://crrev.com/0a81beada89c87c32e6ac4faea3e2823985994dc/mojo/public/cpp/bindings/sync_call_restrictions.h
[modify] https://crrev.com/0a81beada89c87c32e6ac4faea3e2823985994dc/services/ui/display/screen_manager_forwarding.cc
[modify] https://crrev.com/0a81beada89c87c32e6ac4faea3e2823985994dc/services/ui/display/screen_manager_forwarding.h
[modify] https://crrev.com/0a81beada89c87c32e6ac4faea3e2823985994dc/ui/display/manager/forwarding_display_delegate.cc
[modify] https://crrev.com/0a81beada89c87c32e6ac4faea3e2823985994dc/ui/display/manager/forwarding_display_delegate.h
[modify] https://crrev.com/0a81beada89c87c32e6ac4faea3e2823985994dc/ui/display/mojo/native_display_delegate.mojom

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5

commit cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5
Author: sky <sky@chromium.org>
Date: Fri Apr 28 20:52:58 2017

chromeos: Makes mushrome use simplified display management

This also adds a stanalone_ash target that is the equivalent of
ash_shell_with_content but running in mushrome mode and without
content.

BUG= 708287 , 706589 
TEST=covered by tests
R=kylechar@chromium.org

Review-Url: https://codereview.chromium.org/2840043003
Cr-Commit-Position: refs/heads/master@{#468123}

[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/aura/shell_port_classic.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/display/mirror_window_controller.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/display/window_tree_host_manager.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/host/transformer_helper.h
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/mus/BUILD.gn
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/mus/DEPS
[add] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/mus/ash_window_tree_host_mus.cc
[add] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/mus/ash_window_tree_host_mus.h
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/mus/bridge/shell_port_mash.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/mus/bridge/shell_port_mash.h
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/mus/main.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/mus/test/ash_test_impl_mus.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/mus/test/wm_test_base.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/mus/test/wm_test_helper.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/mus/window_manager.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/mus/window_manager.h
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/mus/window_manager_application.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/mus/window_manager_application.h
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/shell.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/shell_init_params.h
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/test/ash_test_base.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/test/ash_test_helper.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/chrome/app/mash/embedded_services.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/chrome/browser/ui/ash/ash_init.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/services/ui/display/screen_manager_forwarding.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/services/ui/ws/window_server.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ui/aura/mus/window_manager_delegate.h
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/cfaad89ae8da7b8a0d0055db9f5bc5ac76cf6cf5/ui/aura/window_tree_host.h

Comment 13 by sky@chromium.org, May 5 2017

Blocking: 718860
Project Member

Comment 14 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edef2a4e69984700e09359b2f3e7234363a16d2c

commit edef2a4e69984700e09359b2f3e7234363a16d2c
Author: sky <sky@chromium.org>
Date: Fri May 12 03:47:24 2017

chromeos: wireup more display management for mushrome

In addition to making ShellPortMash use more code that
ShellPortClassic uses this also enables more test code for
mushrome. As part of 718860  I plan to remove the functions from
ShellPort that end up being identical.

BUG= 706589 
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2874963002
Cr-Commit-Position: refs/heads/master@{#471212}

[modify] https://crrev.com/edef2a4e69984700e09359b2f3e7234363a16d2c/ash/mus/bridge/shell_port_mash.cc
[modify] https://crrev.com/edef2a4e69984700e09359b2f3e7234363a16d2c/ash/mus/bridge/shell_port_mash.h
[modify] https://crrev.com/edef2a4e69984700e09359b2f3e7234363a16d2c/ash/system/screen_layout_observer.cc
[modify] https://crrev.com/edef2a4e69984700e09359b2f3e7234363a16d2c/ash/system/screen_layout_observer.h
[modify] https://crrev.com/edef2a4e69984700e09359b2f3e7234363a16d2c/ash/test/ash_test_helper.cc
[modify] https://crrev.com/edef2a4e69984700e09359b2f3e7234363a16d2c/testing/buildbot/filters/ash_mus_unittests.filter

Comment 15 by sky@chromium.org, May 18 2017

Blockedon: 705686
Project Member

Comment 16 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dee298442f93c6a40c41bd74fd50260cd2dfba1

commit 5dee298442f93c6a40c41bd74fd50260cd2dfba1
Author: sky <sky@chromium.org>
Date: Wed May 24 21:16:16 2017

chromeos: Changes DisplayManagerObserver to have a single function

Having a single function handle all updates makes it easy for
simplified display management where the window-manager needs to call a
single function that updates everything.

BUG= 706589 
TEST=covered by tests
R=erg@chromium.org, tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2897303002
Cr-Commit-Position: refs/heads/master@{#474426}

[modify] https://crrev.com/5dee298442f93c6a40c41bd74fd50260cd2dfba1/services/ui/public/interfaces/display_manager.mojom
[modify] https://crrev.com/5dee298442f93c6a40c41bd74fd50260cd2dfba1/services/ui/ws/display.cc
[modify] https://crrev.com/5dee298442f93c6a40c41bd74fd50260cd2dfba1/services/ui/ws/display_manager.cc
[modify] https://crrev.com/5dee298442f93c6a40c41bd74fd50260cd2dfba1/services/ui/ws/display_manager.h
[modify] https://crrev.com/5dee298442f93c6a40c41bd74fd50260cd2dfba1/services/ui/ws/user_display_manager.cc
[modify] https://crrev.com/5dee298442f93c6a40c41bd74fd50260cd2dfba1/services/ui/ws/user_display_manager.h
[modify] https://crrev.com/5dee298442f93c6a40c41bd74fd50260cd2dfba1/services/ui/ws/user_display_manager_unittest.cc
[modify] https://crrev.com/5dee298442f93c6a40c41bd74fd50260cd2dfba1/ui/views/mus/screen_mus.cc
[modify] https://crrev.com/5dee298442f93c6a40c41bd74fd50260cd2dfba1/ui/views/mus/screen_mus.h
[modify] https://crrev.com/5dee298442f93c6a40c41bd74fd50260cd2dfba1/ui/views/mus/screen_mus_unittest.cc

Comment 17 by sky@chromium.org, May 25 2017

Status: Started (was: Assigned)
Project Member

Comment 19 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2771709f0236929814545a8738053b227d44a170

commit 2771709f0236929814545a8738053b227d44a170
Author: sky <sky@chromium.org>
Date: Fri May 26 19:04:06 2017

chromeos: changes how DisplayManagerObservers are notified

This patch makes it such that in manual display mode (controlled via
WindowManagerWindowTreeFactory) DisplayManagerObservers are only
notified when the WindowManager calls
SetDisplayConfiguration(). Having a separate function allows the
WindowManager to add/remove displays and then trigger notifying
client. This is necessary so that the clients see a consistent state.

BUG= 706589 
TEST=covered by tests
R=erg@chromium.org, tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2904993003
Cr-Commit-Position: refs/heads/master@{#475076}

[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/ash/mus/BUILD.gn
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/ash/mus/bridge/shell_port_mash.cc
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/ash/mus/bridge/shell_port_mash.h
[add] https://crrev.com/2771709f0236929814545a8738053b227d44a170/ash/mus/display_synchronizer.cc
[add] https://crrev.com/2771709f0236929814545a8738053b227d44a170/ash/mus/display_synchronizer.h
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/ash/mus/window_manager.cc
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/ash/mus/window_manager.h
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/public/interfaces/window_manager.mojom
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/service.cc
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/service.h
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/BUILD.gn
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/display.cc
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/display.h
[add] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/display_creation_config.h
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/display_manager.cc
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/display_manager.h
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/test_utils.cc
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/test_utils.h
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/user_display_manager.cc
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/user_display_manager.h
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/user_display_manager_unittest.cc
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/window_manager_state.cc
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/window_manager_window_tree_factory.cc
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/window_server.cc
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/window_server.h
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/window_server_delegate.cc
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/window_server_delegate.h
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/window_tree.cc
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/window_tree.h
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/services/ui/ws/window_tree_unittest.cc
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/ui/aura/mus/window_manager_delegate.h
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/ui/aura/test/mus/test_window_manager_client.cc
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/ui/aura/test/mus/test_window_manager_client.h
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/ui/display/display.h
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/ui/display/display_list.cc
[modify] https://crrev.com/2771709f0236929814545a8738053b227d44a170/ui/display/display_list.h

Comment 20 by sky@chromium.org, Jun 8 2017

Blocking: 731255
Project Member

Comment 21 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/596bb46345c755ac777efae231a56afa26121283

commit 596bb46345c755ac777efae231a56afa26121283
Author: Scott Violet <sky@chromium.org>
Date: Wed Jun 21 19:45:36 2017

chromeos: removes complex display management path

We never really called it complex, but as we named the new code
'simplified' it seems complex is a good name for the old.

Anyway, this removes all the now dead code related to the complex
display management code path. 

BUG= 706589 , 718860 
TEST=covered by tests

Change-Id: Icadd7ba9a56c29c47d5615aaf51bfbb28e69f5d5
Reviewed-on: https://chromium-review.googlesource.com/541060
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481280}
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/DEPS
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/app_list/app_list_delegate_impl.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/aura/shell_port_classic.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/aura/shell_port_classic.h
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/display/cursor_window_controller.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/display/display_configuration_controller.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/display/extended_mouse_warp_controller.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/display/screen_orientation_controller_chromeos.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/mus/BUILD.gn
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/mus/bridge/shell_port_mash.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/mus/bridge/shell_port_mash.h
[delete] https://crrev.com/1d75a1d92beee4cb3a492375d5f55094b7f82229/ash/mus/screen_mus.cc
[delete] https://crrev.com/1d75a1d92beee4cb3a492375d5f55094b7f82229/ash/mus/screen_mus.h
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/mus/window_manager.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/mus/window_manager.h
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/mus/window_manager_application.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/root_window_controller.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/rotator/screen_rotation_animator.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/rotator/screen_rotation_animator_unittest.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/screen_util.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/shelf/shelf_window_watcher.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/shell.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/shell.h
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/shell/window_watcher.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/shell_init_params.h
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/shell_port.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/shell_port.h
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/system/audio/tray_audio.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/system/rotation/tray_rotation_lock.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/test/ash_test_base.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/test/ash_test_helper.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/test/ash_test_helper.h
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/touch/touch_observer_hud.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/touch/touch_observer_hud_unittest.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/utility/screenshot_controller.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/wallpaper/wallpaper_view.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/wm/drag_window_controller.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/wm/maximize_mode/maximize_mode_controller.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_x11.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/wm/window_util.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/chrome/browser/chromeos/display/overscan_calibrator.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/chrome/browser/chromeos/ui/accessibility_cursor_ring_layer.cc
[modify] https://crrev.com/596bb46345c755ac777efae231a56afa26121283/chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc

Comment 22 by sky@chromium.org, Jun 21 2017

This is enabled and I'm calling it done. There is one remaining issue, 647421, but that can be fixed separately.

Comment 23 by sky@chromium.org, Jun 21 2017

Status: Fixed (was: Started)

Comment 24 by sky@chromium.org, Jun 21 2017

Blockedon: -647421
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment