New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706582 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 685673
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 685673



Sign in to add a comment

No way to override PPD for USB printers

Project Member Reported by justincarlson@chromium.org, Mar 29 2017

Issue description

There is, at present, no way to override the ppd for a usb printer.

Right now, when you click "add printer" in the cups settings, you get a discovery dialog with a list of nearby printers that includes usb printers.

However, if you click on one of those printers, the system attempts to automatically set up the usb printer.  This is doomed to fail, because the system *already* tried to auto-set-up the usb printer and failed; when the device is plugged in, we attempt to auto-configure it, and only make it show up in the discovery dialog if the auto-configuration fails.

I think what *should* happen is clicking on a usb printer should take you to a dialog that has the Address/Protocol/Queue fields pre-populated (and probably uneditable) but allows the user to still select a different ppd to use with the printer.

There are variants on this that would also be ok, but right now we just appear to offer to let the user take action, but in actuality *don't* let the user take action.
 
Owner: justincarlson@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5243e7446e4bae1bdeb43f1d4c526de3bf939f5

commit e5243e7446e4bae1bdeb43f1d4c526de3bf939f5
Author: justincarlson <justincarlson@chromium.org>
Date: Tue Apr 11 19:58:57 2017

Make CUPS USB printing play better with the settings page.  This change does several things:

* Provides a real implementation of PrinterDiscoverer, and re-enables
  it.

* Adds support for observers to CupsPrinterDetector,

* Connects PrinterDiscoverer to CupsPrinterDetector, so
  PrinterDiscoverer knows about USB printers

BUGS=616866, 706582 
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2790603003
Cr-Commit-Position: refs/heads/master@{#463738}

[modify] https://crrev.com/e5243e7446e4bae1bdeb43f1d4c526de3bf939f5/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/e5243e7446e4bae1bdeb43f1d4c526de3bf939f5/chrome/browser/chromeos/printer_detector/cups_printer_detector.cc
[modify] https://crrev.com/e5243e7446e4bae1bdeb43f1d4c526de3bf939f5/chrome/browser/chromeos/printer_detector/printer_detector.h
[delete] https://crrev.com/9fe3bc8107285979782a49dbcf0a37cfe0187696/chrome/browser/chromeos/printing/fake_printer_discoverer.cc
[delete] https://crrev.com/9fe3bc8107285979782a49dbcf0a37cfe0187696/chrome/browser/chromeos/printing/fake_printer_discoverer.h
[add] https://crrev.com/e5243e7446e4bae1bdeb43f1d4c526de3bf939f5/chrome/browser/chromeos/printing/printer_discoverer.cc
[modify] https://crrev.com/e5243e7446e4bae1bdeb43f1d4c526de3bf939f5/chrome/browser/chromeos/printing/printer_discoverer.h
[modify] https://crrev.com/e5243e7446e4bae1bdeb43f1d4c526de3bf939f5/chrome/browser/chromeos/printing/printers_manager.h
[modify] https://crrev.com/e5243e7446e4bae1bdeb43f1d4c526de3bf939f5/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/e5243e7446e4bae1bdeb43f1d4c526de3bf939f5/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

Blockedon: 685673
Labels: OS-Chrome
This should be resolved by allowing the Edit of a printer's configuration under  crbug.com/685673 .
Mergedinto: 685673
Status: Duplicate (was: Assigned)

Sign in to add a comment