New issue
Advanced search Search tips

Issue 706571 link

Starred by 1 user
Status: Archived
Owner:
penghuang@chromium.org
Closed: Mar 2017
Cc:
sadrul@chromium.org
sky@chromium.org
mustash-bugs@google.com
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

mash: Autorepeat does not work for volume keys

Project Member Reported by jamescook@chromium.org, Mar 29 2017 
On link, canary OS 9412.0.0, chrome ToT r460396

* Login. Press and hold volume up.
* Volume only goes up one step.

Autorepeat keys works in the omnibox, in web pages and in system UI (press alt-shift-S for system tray then hold down tab). It also works if the system tray is open.

It must be something special about media keys and focus.

Comment 1 by penghuang@chromium.org, Mar 30 2017

Cc: sadrul@chromium.org
As my test, when holding volume keys, the ui::ws::Display::OnEventFromSource() is called repeatedly with rewritten events (with volume keycodes). So the problem must be related to focus or accelerator.

BTW, media keys rewriting works on desktop mustash, but the volume popup dialog doesn't show up.

Comment 2 by jamescook@chromium.org, Mar 30 2017 

FYI I'm seeing some weird behavior with repeated key presses (not autorepeat) from the window server, see  issue 706574
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16dd65423c4063f423238456001c672464474a99

commit 16dd65423c4063f423238456001c672464474a99
Author: penghuang <penghuang@chromium.org>
Date: Fri Mar 31 15:03:32 2017

services/ui: make autorepeat work with accelerator.

BUG= 706571 

Review-Url: https://codereview.chromium.org/2788753002
Cr-Commit-Position: refs/heads/master@{#461122}

[modify] https://crrev.com/16dd65423c4063f423238456001c672464474a99/services/ui/ws/event_matcher.cc

Comment 4 by penghuang@chromium.org, Mar 31 2017

Status: Fixed (was: Assigned)

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment