New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706559 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 674593


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment

Rename ANGLEInstancedArrays to ANGLE_instanced_arrays (and similar for other WebGL extensions)

Project Member Reported by lunalu@chromium.org, Mar 29 2017

Issue description

2 things:
1. The IDL file is missing a spec link, is this what should be added https://www.khronos.org/registry/webgl/extensions/ANGLE_instanced_arrays/?

2. Gecko and IE have the interface name match with the spec (link above), but Blink and WebKit don't. I suspect we should rename it to match the spec too? 

 

Comment 1 by kbr@chromium.org, Mar 29 2017

This is deliberately NoInterfaceObject. The name of the extension type is not supposed to matter. In Blink I think we chose the naming convention of the browser, while the spec uses the OpenGL style with underscores between the words. Is this a big deal or may I close this as WontFix?

Comment 2 by lunalu@chromium.org, Mar 30 2017

Status: WontFix (was: Untriaged)
Yea, my bad. I guess if it is NoInterfaceObject it doesn't really matter.
Status: Available (was: WontFix)
The name of an interface can be observed even with [NoInterfaceObject], given an instance it will toString() to either "[object ANGLE_instanced_arrays]" or "[object ANGLEInstancedArrays]".

This is certainly not a big deal, but would be nice to avoid. Are there more interfaces like this related to WebGL? Would using [ImplementedAs=ANGLEInstancedArrays] in the IDL file work?

Comment 4 by kbr@chromium.org, Apr 4 2017

Cc: kainino@chromium.org
All of the WebGL extensions are exposed in this manner. The class names in the official IDL were chosen to follow the naming convention of the OpenGL extensions -- i.e., first name in all caps, underscores separating the rest of the identifiers.

However, since this naming convention didn't match Chromium's or Blink's, our group took the liberty of diverging from the official IDL.

If renaming the IDL files and using the ImplementedAs= directive would work, we could do that.

Cc: markdittmer@chromium.org
Summary: Rename ANGLEInstancedArrays to ANGLE_instanced_arrays (was: Rename ANGLEInstancedArrays to ANGLE_instanced_arrays?)
I started adding some spec links today and noticed, as you say, that there are lots of interfaces like this.

If the names match up then markdittmer@'s tooling will be able to notice differences between our IDL and what we link to, and I've spotted a few differences manually.

Using ImplementedAs= means that the files won't sit nicely together in a file listing. If that's a concern we could perhaps tweak the bindings generator to allow the mismatch between interface name and file name.
Summary: Rename ANGLEInstancedArrays to ANGLE_instanced_arrays (and similar for other WebGL extensions) (was: Rename ANGLEInstancedArrays to ANGLE_instanced_arrays)
FWIW, the names in Blink are definitely more webby than "correct" names. How much of a mess is it to get things changed in WebGL?
+1 to tweaking bindings generator rather than using custom extended
attributes to correctly match related IDL snippets!

Comment 8 by kbr@chromium.org, Apr 6 2017

We don't want to change the names in the WebGL extension specs. We've adopted Khronos' naming conventions for OpenGL extensions there.

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be1feafb3ea0da9a6a3b7f48320470fb61487fc6

commit be1feafb3ea0da9a6a3b7f48320470fb61487fc6
Author: foolip <foolip@chromium.org>
Date: Fri Apr 07 05:38:53 2017

Add spec links for WebGL IDL files

R=kbr@chromium.org
BUG=706559
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2805013002
Cr-Commit-Position: refs/heads/master@{#462774}

[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/ANGLEInstancedArrays.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/EXTBlendMinMax.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/EXTColorBufferFloat.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQuery.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQueryWebGL2.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/EXTFragDepth.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/EXTShaderTextureLOD.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/EXTTextureFilterAnisotropic.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/EXTsRGB.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/OESElementIndexUint.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/OESStandardDerivatives.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/OESTextureFloat.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/OESTextureFloatLinear.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/OESTextureHalfFloat.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/OESTextureHalfFloatLinear.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/OESVertexArrayObject.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLActiveInfo.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLBuffer.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLCompressedTextureASTC.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLCompressedTextureATC.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLCompressedTextureETC.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLCompressedTextureETC1.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLCompressedTexturePVRTC.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLCompressedTextureS3TC.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLCompressedTextureS3TCsRGB.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLDebugRendererInfo.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLDebugShaders.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLDepthTexture.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLGetBufferSubDataAsync.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLLoseContext.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLProgram.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLQuery.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLSampler.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLShader.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLShaderPrecisionFormat.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLSync.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLTexture.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLTimerQueryEXT.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLTransformFeedback.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLUniformLocation.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObject.idl
[modify] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectOES.idl

Cc: foolip@chromium.org
Project Member

Comment 11 by sheriffbot@chromium.org, Apr 11 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by kbr@chromium.org, Apr 11 2018

Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)

Sign in to add a comment