New should().throw(undefined) differs from old Should().throw(undefined) |
||
Issue descriptionWith the old Audit, Should().throw(undefined) behaved the same as Should().throw(). As long as an exception was thrown, the test passed. With new Audit, should().throw(undefined) and should().throw() behave differently. The latter behaves like Should().throw(), but the former expects the error type to be undefined. This is wrong; they should behave the same.
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ff2dbc1c7424cd12b6ac35ec438eb3057dc65d8 commit 6ff2dbc1c7424cd12b6ac35ec438eb3057dc65d8 Author: rtoy <rtoy@chromium.org> Date: Wed Mar 29 23:57:32 2017 Treat should().throw(undefined) like should().throw() Interpret throw(undefined) to mean that an error of any type is expected. This is the same as throw(). BUG= 706558 TEST=audit.html Review-Url: https://codereview.chromium.org/2783033002 Cr-Commit-Position: refs/heads/master@{#460584} [modify] https://crrev.com/6ff2dbc1c7424cd12b6ac35ec438eb3057dc65d8/third_party/WebKit/LayoutTests/webaudio/resources/audit.js [modify] https://crrev.com/6ff2dbc1c7424cd12b6ac35ec438eb3057dc65d8/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt [modify] https://crrev.com/6ff2dbc1c7424cd12b6ac35ec438eb3057dc65d8/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html
,
Mar 30 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by rtoy@chromium.org
, Mar 29 2017