CrWinClangLLD bot fails to update clang because svn is missing |
|||
Issue descriptionThe bot went red here: https://build.chromium.org/p/chromium.fyi/builders/CrWinClangLLD/builds/5151 It was green immediately before that build: https://build.chromium.org/p/chromium.fyi/builders/CrWinClangLLD/builds/5150 Our script is failing during 'gclient runhooks' like this: ________ running 'C:\b\depot_tools\python276_bin\python.exe src/tools/clang/scripts/update.py --if-needed' in 'C:\b\c\b\CrWinClangLLD' 'svn' is not recognized as an internal or external command, operable program or batch file. Traceback (most recent call last): File "src/tools/clang/scripts/update.py", line 916, in <module> sys.exit(main()) File "src/tools/clang/scripts/update.py", line 904, in main CLANG_REVISION = GetSvnRevision(LLVM_REPO_URL) File "src/tools/clang/scripts/update.py", line 170, in GetSvnRevision svn_info = subprocess.check_output('svn info ' + svn_repo, shell=True) File "C:\b\depot_tools\python276_bin\lib\subprocess.py", line 573, in check_output raise CalledProcessError(retcode, cmd, output=output) subprocess.CalledProcessError: Command 'svn info https://llvm.org/svn/llvm-project' returned non-zero exit status 1 Did we remove svn from depot_tools? Did the bot get reimaged?
,
Mar 29 2017
Normally, these types of issues are best filed through go/bug-a-trooper. In this specific case, we no longer support SVN and all code mentioning SVN was deleted from depot_tools. I'm adding Infra>SDK component in case something broke infra side, but I suspect something changed src-side and it's likely not an infra bug. If that's the case, please triage to the correct component.
,
Mar 30 2017
I have a patch out that hopefully fixes this: https://codereview.chromium.org/2784053003/
,
Mar 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4cddb4364a978f6ba20cf0b5b4e48c924b121a8 commit f4cddb4364a978f6ba20cf0b5b4e48c924b121a8 Author: rnk <rnk@chromium.org> Date: Thu Mar 30 02:54:12 2017 Check for SVN earlier in clang's update.py script We need to do this before the calls to GetSvnRevision, because they run svn. BUG= 706552 R=thakis@chromium.org,krasin@chromium.org Review-Url: https://codereview.chromium.org/2784053003 Cr-Commit-Position: refs/heads/master@{#460631} [modify] https://crrev.com/f4cddb4364a978f6ba20cf0b5b4e48c924b121a8/tools/clang/scripts/update.py
,
Mar 30 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by thakis@chromium.org
, Mar 29 2017