New issue
Advanced search Search tips

Issue 706531 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Omnibox - rename more things from autocomplete to omnibox (as appropriate)

Project Member Reported by mpear...@chromium.org, Mar 29 2017

Issue description


Spawned from  bug 80186 .

"It would be nice to rename things from "Autocomplete" in some cases.  We may not want to name everything "omnibox" e.g. because of non-omnibox uses of the core controller/providers like the URL classifier."

 
We also have potential name conflicts: AutocompleteController and OmniboxController both exist today.

There may be an opportunity for the "classifier" sort of functionality to be factored out elsewhere.  One of the design questions there is, does that system need to be using all the machinery it is today?  We built it atop the synchronous pass of the omnibox machinery because doing so was easy, but if it's going to be called in more places, perhaps it should be more well-separated.

What I'm imagining is splitting out something like AutocompleteInput::Parse() and a few bits of the HUP that check for intranet URLs and the like, and making those part of some kind of input_classifier/url_classifier component.
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 2 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment