Remove power.gpu_rasterization's top_[10,25] and typical_10_mobile |
|||
Issue descriptionA few notes about what makes these benchmarks ripe for deletion: - They don't add any additional coverage now that GPU rasterization is the default on Mac - In the last 200 runs, they've failed 20 times on the perf bots - They contribute 27m of total runtime to our Mac perf bots - They're only enabled on Mac, and therefore don't aid in our goal of having a consistent set of benchmarks across platforms - They're both unowned, which makes it difficult to get help for maintenance work and resolving regressions - In the past 30 days, they've only resulted in one total alert, which led to a bug marked as WontFix
,
Mar 30 2017
I'm going to expand this bug to include power.gpu_rasterization.typical_10_mobile: ericrk@ has confirmed that GPU rasterization is also the default on Android, so this benchmark is also a duplicate.
,
Mar 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/acb782439b5218aec440085b2560487bd344f7ef commit acb782439b5218aec440085b2560487bd344f7ef Author: Charlie Andrews <charliea@chromium.org> Date: Fri Mar 31 20:57:14 2017 Delete Mac power.gpu_rasterization.* benchmarks Now that GPU rasterization is the default on Mac, these benchmarks are exact duplicates of the non-GPU rasterization versions of the benchmarks. I've verified with ericrk@, shrike@, and erikchen@ that these benchmarks are okay to delete. NOTRY=true TBR=nednguyen@google.com,shrike@chromium.org,rnephew@chromium.org BUG= 706529 patch from issue 2781923004 at patchset 10001 (http://crrev.com/2781923004#ps10001) Change-Id: If02bca7c5b2a1c7156e694aac9e25aa517d7a0ac Reviewed-on: https://chromium-review.googlesource.com/465146 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#461223} [modify] https://crrev.com/acb782439b5218aec440085b2560487bd344f7ef/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/acb782439b5218aec440085b2560487bd344f7ef/testing/buildbot/chromium.perf.json [modify] https://crrev.com/acb782439b5218aec440085b2560487bd344f7ef/tools/perf/benchmark.csv [modify] https://crrev.com/acb782439b5218aec440085b2560487bd344f7ef/tools/perf/benchmarks/power.py
,
May 16 2017
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a55bab810f1a4c23b2fe118dbf19fb6804338f8 commit 5a55bab810f1a4c23b2fe118dbf19fb6804338f8 Author: charliea <charliea@chromium.org> Date: Thu May 18 06:27:13 2017 Remove power.gpu_rasterization.top_X from benchmark times JSON These benchmarks were deleted in an earlier CL. TBR=nednguyen@google.com BUG= 706529 Review-Url: https://codereview.chromium.org/2891483002 Cr-Commit-Position: refs/heads/master@{#472705} [modify] https://crrev.com/5a55bab810f1a4c23b2fe118dbf19fb6804338f8/tools/perf/core/desktop_benchmark_avg_times.json |
|||
►
Sign in to add a comment |
|||
Comment 1 by charliea@chromium.org
, Mar 29 2017Cc: -nednguyen@chromium.org nedngu...@google.com