Previews Infobar should track user actions that close the tab |
|||
Issue descriptionCurrently, user actions to dismiss the infobar are tracked (such as reload, new navigation, user dismissing the infobar, etc.) but it seems that closing the tab is not tracked. Tracking this will change the opt out rate.
,
Apr 14 2017
Good point. Seems like a P3 then since we only care about shown vs clicked link really.
,
Apr 14 2017
Ya, I don't think it's necessary to merge this either. Moving to M60.
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e111e380e8f4178c4a1907c4fa6b4408a22800bc commit e111e380e8f4178c4a1907c4fa6b4408a22800bc Author: megjablon <megjablon@chromium.org> Date: Mon Apr 17 21:53:47 2017 Track Previews infobar dismissals due to tab closure BUG= 706528 Review-Url: https://codereview.chromium.org/2820793003 Cr-Commit-Position: refs/heads/master@{#465032} [modify] https://crrev.com/e111e380e8f4178c4a1907c4fa6b4408a22800bc/chrome/browser/previews/previews_infobar_delegate.cc [modify] https://crrev.com/e111e380e8f4178c4a1907c4fa6b4408a22800bc/chrome/browser/previews/previews_infobar_delegate.h [modify] https://crrev.com/e111e380e8f4178c4a1907c4fa6b4408a22800bc/chrome/browser/previews/previews_infobar_delegate_unittest.cc [modify] https://crrev.com/e111e380e8f4178c4a1907c4fa6b4408a22800bc/tools/metrics/histograms/histograms.xml
,
Apr 27 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by megjab...@chromium.org
, Apr 14 2017