Issue 706527 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	----
Closed:	Sep 2017
Cc:	editing-dev@chromium.org
Components:	Blink>Editing
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Task

Blocked on:
issue 761254

Allow forward declaration of templated editing classes

Project Member Reported by xiaoche...@chromium.org, Mar 29 2017

Issue description

Editing code contains a lot of templated classes:
- PositionTemplate
- SelectionTemplate
- EphemeralRangeTemplate
- VisiblePositionTemplate
- VisibleSelectionTemplate
...

In most cases, we are using specialized aliases, like using the alias Position instead of its true name PositionTemplate<EditingStrategy> (*).

However, we cannot forward declare a alias. Header files are forced to include Position.h even if only a declaration of |Position| is needed. This makes compilation time longer.

We should allow some sort of forward declaration of this templated aliases.

Comment 1 by xiaoche...@chromium.org, Mar 30 2017

(*) EditingStrategy is also an alias, whose true name is EditingAlgorithm<NodeTraversal>.

Comment 2 by xiaoche...@chromium.org, Sep 13 2017

Labels: -Type-Bug Type-Task

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5

commit 389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Wed Sep 13 18:11:36 2017

Allow forward declaration of VisibleSelection

This patch changes the inclusion of VisibleSelection.h in header files
to forward declaration as much as possible to optimize compile time.

Bug:  706527 
Change-Id: I71b6ab8e0ac0264331eafece6c4e0e97712bf2dc
Reviewed-on: https://chromium-review.googlesource.com/663795
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501691}
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/BUILD.gn
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/DOMSelection.h
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/EditingStyle.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/EditingStyle.h
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/EditingStyleUtilities.h
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/EditingUtilities.h
[add] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/Forward.h
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/GranularityStrategy.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/LayoutSelection.h
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/SelectionAdjuster.h
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/SelectionEditor.h
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/WebSubstringUtil.mm
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/commands/SelectionForUndoStep.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/commands/SelectionForUndoStep.h
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/commands/TypingCommand.h
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/editing/suggestion/TextSuggestionControllerTest.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/exported/WebRange.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/exported/WebSurroundingText.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/input/MouseEventManager.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/layout/HitTestResult.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/core/svg/SVGTextContentElement.cpp
[modify] https://crrev.com/389d19a9c8a3b4c43d7d3d2cd0ea2ca07293f1b5/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30e1a4396cbd07167a20721d5a8aa08e1973bcd1

commit 30e1a4396cbd07167a20721d5a8aa08e1973bcd1
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Thu Sep 14 06:32:32 2017

Allow forward declaration of VisiblePosition

This patch changes all inclusions of VisiblePosition.h in header files
to forward declaration as much as possible to optimize compile time.

Non-trivial changes in this patch:
- Moved implementation of VisibleSelection::VisibleStart/End/Base/Extent
  to VisibleSelection.cpp
- Removed the default VisiblePosition parameter in
  CompositeEditCommand::CleanupAfterDeletion by introducing another
  overload without the VisiblePosition parameter
- Moved implementation of AXObject::VisiblePositionForIndex to
  AXObject.cpp

Bug:  706527 
Change-Id: I07a312dca47ba28b153e133dbd6c9357ed259d5b
Reviewed-on: https://chromium-review.googlesource.com/666092
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501883}
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/DragCaret.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/EditingUtilities.h
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/Forward.h
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/FrameCaret.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/GranularityStrategy.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/RenderedPosition.h
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/RenderedPositionTest.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/SelectionModifierCharacter.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/SelectionModifierTest.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/SelectionModifierWord.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/VisibleSelection.h
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/VisibleUnits.h
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/VisibleUnitsParagraph.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/VisibleUnitsSentence.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/VisibleUnitsWord.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/VisibleUnitsWordTest.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.h
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/commands/SelectionForUndoStep.h
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/editing/suggestion/TextSuggestionController.h
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.h
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/html/TextControlElement.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/html/TextControlElement.h
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/svg/SVGTextContentElement.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/30e1a4396cbd07167a20721d5a8aa08e1973bcd1/third_party/WebKit/Source/modules/exported/WebAXObject.cpp

Comment 5 by xiaoche...@chromium.org, Sep 15 2017

Blockedon: 761254

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8

commit be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Fri Sep 15 20:19:54 2017

Allow forward declaration of SelectionTemplate

This patch changes all inclusions of SelectionTemplate.h in header files
to forward declaration as much as possible to optimize compile time.

Bug:  706527 
Change-Id: I8a2e9af26629ca29a94be740c580f48d20d6aebf
Reviewed-on: https://chromium-review.googlesource.com/667129
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502346}
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/dom/Range.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/dom/RangeTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/CaretDisplayItemClientTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/DOMSelection.h
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/Forward.h
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/FrameCaretTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/GranularityStrategy.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/GranularityStrategy.h
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/LayoutSelection.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/LayoutSelectionTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/SurroundingTextTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/TextFinder.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/VisibleSelection.h
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/VisibleUnitsWordTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/WebSubstringUtil.mm
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommandTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/InsertIncrementalTextCommand.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/InsertIncrementalTextCommandTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/InsertTextCommandTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/SelectionForUndoStep.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/SelectionForUndoStep.h
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/commands/TypingCommandTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/suggestion/TextSuggestionController.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/suggestion/TextSuggestionControllerTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/testing/EditingTestBase.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/testing/EditingTestBase.h
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/testing/SelectionSample.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/testing/SelectionSample.h
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/editing/testing/SelectionSampleTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/html/TextControlElement.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/html/TextControlElement.h
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/svg/SVGTextContentElement.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/be35f28174767a1cd71f3614e1f3ec6ce4e1f0e8/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1882f476b61190a07529b6f9f1514cddd2e61f41

commit 1882f476b61190a07529b6f9f1514cddd2e61f41
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Sat Sep 16 18:16:29 2017

Allow forward declaration of PositionWithAffinityTemplate

This patch changes inclusions of PositionWithAffinity.h in header files
to forward declaration as much as possible to optimize compile time.

Bug:  706527 
Change-Id: I38909d7e8abd58fada6a7d41f6ad184ef9044ca0
Reviewed-on: https://chromium-review.googlesource.com/669690
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502509}
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.h
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/editing/DragCaret.h
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/editing/EditingUtilities.h
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/editing/Forward.h
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/editing/FrameCaret.cpp
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/editing/FrameCaret.h
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/editing/SelectionController.h
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/editing/SelectionTemplate.cpp
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/editing/SelectionTemplate.h
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/editing/VisibleUnits.h
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/input/TouchEventManager.cpp
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/layout/HitTestResult.cpp
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/layout/HitTestResult.h
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/layout/LayoutInline.h
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/layout/api/LineLayoutItem.h
[modify] https://crrev.com/1882f476b61190a07529b6f9f1514cddd2e61f41/third_party/WebKit/Source/core/page/ChromeClientTest.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/703c6b6cf1bcd212168721e72bc79b4afacb370e

commit 703c6b6cf1bcd212168721e72bc79b4afacb370e
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Tue Sep 19 02:54:27 2017

Allow forward declaration of EphemeralRangeTemplate

This patch changes inclusions of EphemeralRange.h in header files
to forward declaration as much as possible to optimize compile time.
To make this change:
- StaticRange::Create(EphemeralRange) is moved to .cpp file
- The removal of the inclusion of EphemeralRange.h from WebRange.h
  resulted in a lot of inclusions of some other header files in other
  .cpp files.

Bug:  706527 
Change-Id: I922d5d02f50aae4f1c0730fd1aab1a1659e0b898
Reviewed-on: https://chromium-review.googlesource.com/670164
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502767}
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/animation/AnimationSimTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/dom/RangeTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/dom/StaticRange.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/dom/StaticRange.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/DOMSelection.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/EditingUtilities.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/Editor.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/FindInPageCoordinates.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/FindInPageCoordinates.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/Forward.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/InputMethodController.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/LayoutSelection.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/PlainTextRange.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/SelectionAdjuster.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/SelectionTemplate.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/SelectionTemplate.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/SelectionTemplateTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/SurroundingText.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/SurroundingText.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/SurroundingTextTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/TextFinder.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/TextFinderTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/VisibleSelection.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/VisibleUnits.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/VisibleUnitsParagraph.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/VisibleUnitsSentence.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/WebSubstringUtil.mm
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/commands/InsertIncrementalTextCommand.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommandTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/iterators/BackwardsCharacterIterator.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/iterators/BackwardsCharacterIterator.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/iterators/CharacterIteratorTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/iterators/SearchBufferTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/iterators/TextIterator.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/iterators/TextIteratorTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/serializers/Serialization.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/suggestion/TextSuggestionController.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/suggestion/TextSuggestionController.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/editing/suggestion/TextSuggestionControllerTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/exported/PrerenderingTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/exported/WebFrameSerializerSanitizationTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/exported/WebRange.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/exported/WebRangeTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/exported/WebSurroundingText.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/frame/BrowserControlsTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/frame/DeferredLoadingTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/frame/FrameSerializer.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/frame/FrameSerializerTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/html/parser/HTMLDocumentParserLoadingTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/input/MouseEventManager.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/page/scrolling/SmoothScrollTest.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/703c6b6cf1bcd212168721e72bc79b4afacb370e/third_party/WebKit/public/web/WebRange.h

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00e329e0e60295cc622a393394bba31f0be74672

commit 00e329e0e60295cc622a393394bba31f0be74672
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Tue Sep 19 03:11:58 2017

Allow forward declaration of PositionTemplate

This patch changes inclusions of Position.h in header files
to forward declaration as much as possible to optimize compile time.

Bug:  706527 
Change-Id: I3597b0a2862dae6a89a754513a2d8ca2a5ead4a1
Reviewed-on: https://chromium-review.googlesource.com/670580
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502770}
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/clipboard/DataTransferTest.cpp
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/dom/DocumentTest.cpp
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/dom/NodeTest.cpp
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/dom/WhitespaceAttacher.cpp
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/DOMSelection.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/EditingStyle.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/EditingUtilities.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/Forward.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/FrameSelection.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/LayoutSelection.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/PositionIterator.cpp
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/PositionIterator.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/SelectionAdjuster.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/SurroundingText.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/VisibleSelection.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/VisibleUnits.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/serializers/Serialization.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingParagraph.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/suggestion/TextSuggestionController.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/testing/EditingTestBase.cpp
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/editing/testing/EditingTestBase.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/exported/WebPluginContainerTest.cpp
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/html/TextControlElement.cpp
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/html/TextControlElement.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/html/TextControlElementTest.cpp
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/layout/GeneratedChildren.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/00e329e0e60295cc622a393394bba31f0be74672/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp

Comment 10 by xiaoche...@chromium.org, Sep 20 2017

Status: Fixed (was: Available)

►

Issue 706527 link

Issue metadata

Allow forward declaration of templated editing classes

Issue description

Comment 1 by xiaoche...@chromium.org, Mar 30 2017

Comment 1 Deleted

Comment 2 by xiaoche...@chromium.org, Sep 13 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Sep 13 2017

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Sep 14 2017

Comment 4 Deleted

Comment 5 by xiaoche...@chromium.org, Sep 15 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Sep 15 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Sep 16 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Sep 19 2017

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Sep 19 2017

Comment 9 Deleted

Comment 10 by xiaoche...@chromium.org, Sep 20 2017

Comment 10 Deleted

Sign in to add a comment