Remove SchedulerBackwardCompatibility::INIT_COM_STA |
||
Issue descriptionNow that the Task Scheduler has an STA support, we can start to move callers to it and remove SchedulerBackwardCompatibility::INIT_COM_STA.
,
Jul 6 2017
,
Jul 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e738ae9532d712ce614fea32e146304dbaeb4eb commit 0e738ae9532d712ce614fea32e146304dbaeb4eb Author: Robert Liao <robliao@chromium.org> Date: Sat Jul 15 00:21:52 2017 Move DrawTaskbarDecoration's Call of SetOverlayIcon to Use the COM STA Task Runner BUG=706512 Change-Id: I933e2b06530b9d164a33966e9b70125729fc80ff Reviewed-on: https://chromium-review.googlesource.com/572404 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#486950} [modify] https://crrev.com/0e738ae9532d712ce614fea32e146304dbaeb4eb/chrome/browser/ui/views/frame/taskbar_decorator_win.cc
,
Jul 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ffda7c997834f0566b79e4ae294bb8d3492df4f commit 6ffda7c997834f0566b79e4ae294bb8d3492df4f Author: Robert Liao <robliao@chromium.org> Date: Sat Jul 15 00:22:28 2017 Move IncognitoModePrefs Initialization to the COM STA Task Runner BUG=706512 Change-Id: I185278d5230b00dc6b8b9c3a8712ae016b7d44f3 Reviewed-on: https://chromium-review.googlesource.com/572190 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#486951} [modify] https://crrev.com/6ffda7c997834f0566b79e4ae294bb8d3492df4f/chrome/browser/prefs/incognito_mode_prefs.cc
,
Jul 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a8680d6c1e8f93c2d82b7c60ab4d9697b975725 commit 9a8680d6c1e8f93c2d82b7c60ab4d9697b975725 Author: Robert Liao <robliao@chromium.org> Date: Mon Jul 17 19:58:32 2017 Move DefaultWebClientWorker to use the COM STA Task Runner BUG=706512 Change-Id: I51f6817dd9267ce842d77e8a85c5c2e15dacba22 Reviewed-on: https://chromium-review.googlesource.com/574436 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#487208} [modify] https://crrev.com/9a8680d6c1e8f93c2d82b7c60ab4d9697b975725/chrome/browser/shell_integration.cc
,
Jul 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06f34ffd8fa70c397da759006481a6b4630adb01 commit 06f34ffd8fa70c397da759006481a6b4630adb01 Author: Robert Liao <robliao@chromium.org> Date: Mon Jul 17 22:14:52 2017 Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() This change will allow for the detection of tasks running in TaskScheduler that fail to post their task in a COM STA Task Runner instead. BUG=706512 Change-Id: If8ea9df63cface0dc48aa11b5254ab3e6d87dc4f Reviewed-on: https://chromium-review.googlesource.com/549223 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#487269} [modify] https://crrev.com/06f34ffd8fa70c397da759006481a6b4630adb01/base/task_scheduler/scheduler_worker.cc [modify] https://crrev.com/06f34ffd8fa70c397da759006481a6b4630adb01/base/task_scheduler/scheduler_worker_unittest.cc
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7e9d41973104fa84bffeb410da4b07e2416be19 commit b7e9d41973104fa84bffeb410da4b07e2416be19 Author: Alice Boxhall <aboxhall@chromium.org> Date: Tue Jul 18 01:12:13 2017 Revert "Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED()" This reverts commit 06f34ffd8fa70c397da759006481a6b4630adb01. Reason for revert: Seems to have caused a test failure: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__dbg__1_%2F61641%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FPDFExtensionTest.DisablePlugin%2F0 in https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61641 Original change's description: > Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() > > This change will allow for the detection of tasks running in > TaskScheduler that fail to post their task in a COM STA Task Runner > instead. > > BUG=706512 > > Change-Id: If8ea9df63cface0dc48aa11b5254ab3e6d87dc4f > Reviewed-on: https://chromium-review.googlesource.com/549223 > Commit-Queue: Robert Liao <robliao@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487269} TBR=gab@chromium.org,robliao@chromium.org Change-Id: Ie490ffab894364493a8b79fdb517e360d36ea4ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 706512 Reviewed-on: https://chromium-review.googlesource.com/574894 Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#487330} [modify] https://crrev.com/b7e9d41973104fa84bffeb410da4b07e2416be19/base/task_scheduler/scheduler_worker.cc [modify] https://crrev.com/b7e9d41973104fa84bffeb410da4b07e2416be19/base/task_scheduler/scheduler_worker_unittest.cc
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a84ab56bfd1904c5bdd8da4eb3cfbbf75df0aad commit 9a84ab56bfd1904c5bdd8da4eb3cfbbf75df0aad Author: Robert Liao <robliao@chromium.org> Date: Tue Jul 18 20:24:29 2017 Move the DownloadTargetDeterminer Adobe Reader Check to use the COM STA Task Runner BUG=706512 Change-Id: Ib252b2e692f36494e829eeefdb9664fb82f34909 Reviewed-on: https://chromium-review.googlesource.com/576309 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#487589} [modify] https://crrev.com/9a84ab56bfd1904c5bdd8da4eb3cfbbf75df0aad/chrome/browser/download/download_target_determiner.cc
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/122a24f59d90a1b225e00b3ab6c9fd37fd365b8f commit 122a24f59d90a1b225e00b3ab6c9fd37fd365b8f Author: robliao <robliao@chromium.org> Date: Tue Jul 18 22:07:01 2017 Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() This change will allow for the detection of tasks running in TaskScheduler that fail to post their task in a COM STA Task Runner instead. BUG=706512 TBR=gab@chromium.org Previously Reviewed at https://chromium-review.googlesource.com/c/549223/ Review-Url: https://codereview.chromium.org/2978253002 Cr-Commit-Position: refs/heads/master@{#487625} [modify] https://crrev.com/122a24f59d90a1b225e00b3ab6c9fd37fd365b8f/base/task_scheduler/scheduler_worker.cc [modify] https://crrev.com/122a24f59d90a1b225e00b3ab6c9fd37fd365b8f/base/task_scheduler/scheduler_worker_unittest.cc
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d02b58c2721f40f9b1f89af4fde464b6531360d commit 9d02b58c2721f40f9b1f89af4fde464b6531360d Author: robliao <robliao@chromium.org> Date: Thu Jul 20 01:47:58 2017 Revert of Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() (patchset #1 id:1 of https://codereview.chromium.org/2978253002/ ) Reason for revert: Causes base/task_scheduler/scheduler_worker.h(199,40): error: private field 'backward_compatibility_' is not used [-Werror,-Wunused-private-field] const SchedulerBackwardCompatibility backward_compatibility_; Original issue's description: > Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() > > This change will allow for the detection of tasks running in > TaskScheduler that fail to post their task in a COM STA Task Runner > instead. > > BUG=706512 > TBR=gab@chromium.org > Previously Reviewed at https://chromium-review.googlesource.com/c/549223/ > > Review-Url: https://codereview.chromium.org/2978253002 > Cr-Commit-Position: refs/heads/master@{#487625} > Committed: https://chromium.googlesource.com/chromium/src/+/122a24f59d90a1b225e00b3ab6c9fd37fd365b8f TBR=gab@chromium.org,rnk@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=706512 Review-Url: https://codereview.chromium.org/2983143002 Cr-Commit-Position: refs/heads/master@{#488089} [modify] https://crrev.com/9d02b58c2721f40f9b1f89af4fde464b6531360d/base/task_scheduler/scheduler_worker.cc [modify] https://crrev.com/9d02b58c2721f40f9b1f89af4fde464b6531360d/base/task_scheduler/scheduler_worker_unittest.cc
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f9efe1f0d7e7d5c1c186f31a52956e8e5155c65 commit 8f9efe1f0d7e7d5c1c186f31a52956e8e5155c65 Author: robliao <robliao@chromium.org> Date: Thu Jul 20 18:45:02 2017 Disable COM Initialization on SchedulerWorkers When COM_INIT_CHECK_HOOK_ENABLED() This change will allow for the detection of tasks running in TaskScheduler that fail to post their task in a COM STA Task Runner instead. BUG=706512 TBR=gab@chromium.org Previously Reviewed at https://chromium-review.googlesource.com/c/549223/ Review-Url: https://codereview.chromium.org/2978253002 Cr-Original-Commit-Position: refs/heads/master@{#487625} Committed: https://chromium.googlesource.com/chromium/src/+/122a24f59d90a1b225e00b3ab6c9fd37fd365b8f Review-Url: https://codereview.chromium.org/2978253002 Cr-Commit-Position: refs/heads/master@{#488327} [modify] https://crrev.com/8f9efe1f0d7e7d5c1c186f31a52956e8e5155c65/base/task_scheduler/scheduler_worker.cc [modify] https://crrev.com/8f9efe1f0d7e7d5c1c186f31a52956e8e5155c65/base/task_scheduler/scheduler_worker.h [modify] https://crrev.com/8f9efe1f0d7e7d5c1c186f31a52956e8e5155c65/base/task_scheduler/scheduler_worker_unittest.cc
,
Jul 24 2017
@robliao: can we get rid of these error logs: ERROR:scoped_com_initializer.h(58)] Multiple CoInitialize() calls for thread 9832 are they related to this? (at least they show up besides these failures all the time and may puzzle a few although innocuous AFAIK).
,
Jul 24 2017
We can probably get rid of them. It isn't an error to call CoInitialize multiple times with the same apartment setting.
,
Jul 24 2017
Hmmm actually nvm, I think those are separate errors I'm seeing.
,
Jul 24 2017
But if they're innocuous errors yeah let's remove them (they just mislead me).
,
Apr 12 2018
Looks like there's only cloud printing left :) |
||
►
Sign in to add a comment |
||
Comment 1 by robliao@chromium.org
, Mar 29 2017