New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 706507 link

Starred by 1 user
Status: Verified
Owner:
lijeffrey@chromium.org
Closed: Mar 2017
Cc:
█ robert...@chromium.org
chanli@chromium.org
st...@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Check reverted CLs Nonetype has no attribute 'sort'

Project Member Reported by lijeffrey@chromium.org, Mar 29 2017 
cl_info.GetRevertCLsByRevision can return None if its return status != 200, causing check_revert_cls to crash when sorting the revert CLs list.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0af5c7b77293d96f2b238fa02342182d8ebdbcb4

commit 0af5c7b77293d96f2b238fa02342182d8ebdbcb4
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Wed Mar 29 19:30:11 2017

[Findit] Fixing Nonetype error in check_revert_cls

Bug:  706507 
Change-Id: I2ac80eefd11a3baaa571f379706b8f50fe62fd2b
Reviewed-on: https://chromium-review.googlesource.com/462357
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/0af5c7b77293d96f2b238fa02342182d8ebdbcb4/appengine/findit/handlers/check_reverted_cls.py
[modify] https://crrev.com/0af5c7b77293d96f2b238fa02342182d8ebdbcb4/appengine/findit/handlers/test/check_reverted_cls_test.py

Comment 2 by lijeffrey@chromium.org, Mar 29 2017

Components: Tools>Test>FindIt
Status: Verified (was: Assigned)
►

Sign in to add a comment