New issue
Advanced search Search tips

Issue 706499 link

Starred by 2 users
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Mar 2017
Cc:
tkent@chromium.org
jeffcarp@chromium.org
vadimsh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Rename w3c-test-autoroller -> wpt-importer

Project Member Reported by qyears...@chromium.org, Mar 29 2017 
Reasons:
 - The exporter builder is named wpt-exporter
 - The builder now only imports wpt (web-platform-tests).

So I think the name wpt-importer would be more consistent.

The troublesome thing about this change is that it involves changes in several different repos, and will result in the builder being broken for at least a day. I think that this week is a good time to do it though, since import is currently blocked on getting csswg-tests copied over.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4356209aed24abda3ab8a0c0a849085cbd893cc6

commit 4356209aed24abda3ab8a0c0a849085cbd893cc6
Author: Quinten Yearsley <qyearsley@google.com>
Date: Wed Mar 29 22:24:46 2017

Rename the builder w3c-test-autoroller -> wpt-importer.

Bug:  706499 
Change-Id: Ic71ffb9ad055ba77c4c64d4aaa951fe4b4fa79f6
Reviewed-on: https://chromium-review.googlesource.com/462435
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/4356209aed24abda3ab8a0c0a849085cbd893cc6/masters/master.chromium.infra.cron/slaves.cfg
[modify] https://crrev.com/4356209aed24abda3ab8a0c0a849085cbd893cc6/masters/master.chromium.infra.cron/master.cfg
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 29 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/b6f49107a0f925d646ae1b62f5f01459cf6e95aa

commit b6f49107a0f925d646ae1b62f5f01459cf6e95aa
Author: Quinten Yearsley <qyearsley@google.com>
Date: Wed Mar 29 22:29:26 2017

Comment 3 by qyears...@chromium.org, Mar 29 2017

Cc: -tandrii@chromium.org vadimsh@chromium.org
Components: Blink>Infra
Status: Started (was: Assigned)

Comment 4 by qyears...@chromium.org, Mar 29 2017 

Very closely related to this, I'd also like to rename the recipe "w3c_test_autoroller" -> "wpt_import" to be consistent with the recipe "wpt_export" used by the exporter...
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/74178ab52635bbe0b5836346139e5672e64ae1f6

commit 74178ab52635bbe0b5836346139e5672e64ae1f6
Author: Quinten Yearsley <qyearsley@google.com>
Date: Wed Mar 29 23:05:28 2017

Rename recipe used by the wpt-importer builder (change in master.cfg).

Bug:  706499 
Change-Id: I167401cb613197642aa0325e52972e65b3413a57
Reviewed-on: https://chromium-review.googlesource.com/462386
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/74178ab52635bbe0b5836346139e5672e64ae1f6/masters/master.chromium.infra.cron/master.cfg
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/74178ab52635bbe0b5836346139e5672e64ae1f6

commit 74178ab52635bbe0b5836346139e5672e64ae1f6
Author: Quinten Yearsley <qyearsley@google.com>
Date: Wed Mar 29 23:05:28 2017

Rename recipe used by the wpt-importer builder (change in master.cfg).

Bug:  706499 
Change-Id: I167401cb613197642aa0325e52972e65b3413a57
Reviewed-on: https://chromium-review.googlesource.com/462386
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/74178ab52635bbe0b5836346139e5672e64ae1f6/masters/master.chromium.infra.cron/master.cfg

Comment 7 by qyears...@chromium.org, Mar 29 2017 

Master restart request: bug 706588.

Comment 8 by qyears...@chromium.org, Mar 29 2017

Cc: tkent@chromium.org
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fab627a9bb7315be3a3eb9457861e786b49544c4

commit fab627a9bb7315be3a3eb9457861e786b49544c4
Author: Quinten Yearsley <qyearsley@google.com>
Date: Thu Mar 30 16:14:07 2017

Update builder name w3c-test-autoroller -> wpt-importer (src repo)

Bug:  706499 

Change-Id: Ia649d35f81089eee35f5fb8aab88cd55502a2a6e
Reviewed-on: https://chromium-review.googlesource.com/462339
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#460785}
[modify] https://crrev.com/fab627a9bb7315be3a3eb9457861e786b49544c4/docs/testing/web_platform_tests.md
[modify] https://crrev.com/fab627a9bb7315be3a3eb9457861e786b49544c4/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/fab627a9bb7315be3a3eb9457861e786b49544c4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py

Comment 11 by qyears...@chromium.org, Mar 31 2017

Status: Fixed (was: Started)
►

Sign in to add a comment