as requested in https://codereview.chromium.org/2778203003/#msg9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2009b0e3ce935a30f27334687773f7f3abc809cb commit 2009b0e3ce935a30f27334687773f7f3abc809cb Author: paulmiller <paulmiller@chromium.org> Date: Wed Apr 05 17:41:55 2017 WebView: Refactor PlatformServiceBridge.getInstance Split getInstance into a creator (getOrCreateInstance), a getter (getInstance), and setter for testing (injectInstance). This way, only the first user of PlatformServiceBridge need supply a Context. injectInstance cuts down on some redundant test code. Also remove the lock around creation, since that happens in WebViewChromiumFactoryProvider.startChromiumLocked, before there are any other users. BUG=681805 BUG= 706495 Review-Url: https://codereview.chromium.org/2787963003 Cr-Commit-Position: refs/heads/master@{#462134} [modify] https://crrev.com/2009b0e3ce935a30f27334687773f7f3abc809cb/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java [modify] https://crrev.com/2009b0e3ce935a30f27334687773f7f3abc809cb/android_webview/java/src/org/chromium/android_webview/AwMetricsLogUploader.java [modify] https://crrev.com/2009b0e3ce935a30f27334687773f7f3abc809cb/android_webview/java/src/org/chromium/android_webview/PlatformServiceBridge.java [modify] https://crrev.com/2009b0e3ce935a30f27334687773f7f3abc809cb/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java [modify] https://crrev.com/2009b0e3ce935a30f27334687773f7f3abc809cb/android_webview/javatests/src/org/chromium/android_webview/test/crash/MinidumpUploaderTest.java
whoops no still need the downstream part
Welp. https://codereview.chromium.org/2799263002/patch/20001/30003 makes this whole design obsolete, since getOrCreateInstance doesn't need a Context anymore. So we can turn this back into a single function. :P
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/20d74d0bca9f70f5dbce98ef2f3ffb41b7e43a69 commit 20d74d0bca9f70f5dbce98ef2f3ffb41b7e43a69 Author: Paul Miller <paulmiller@google.com> Date: Thu Apr 13 18:17:58 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00b225ddd0a5b1953d45ad4fdd22b7ce7baba58d commit 00b225ddd0a5b1953d45ad4fdd22b7ce7baba58d Author: paulmiller <paulmiller@chromium.org> Date: Tue Apr 18 16:39:55 2017 WebView: Refactor PlatformServiceBridge.getInstance() Fold getOrCreateInstance back into getInstance, since construction no longer requires a Context. This partially reverts 2009b0e3. BUG= 706495 Review-Url: https://codereview.chromium.org/2815403002 Cr-Commit-Position: refs/heads/master@{#465264} [modify] https://crrev.com/00b225ddd0a5b1953d45ad4fdd22b7ce7baba58d/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java [modify] https://crrev.com/00b225ddd0a5b1953d45ad4fdd22b7ce7baba58d/android_webview/java/src/org/chromium/android_webview/PlatformServiceBridge.java [modify] https://crrev.com/00b225ddd0a5b1953d45ad4fdd22b7ce7baba58d/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/c5975dbc1e7da1034dc92720f6205212ec085016 commit c5975dbc1e7da1034dc92720f6205212ec085016 Author: Paul Miller <paulmiller@google.com> Date: Tue Apr 18 20:38:54 2017
Comment 1 by bugdroid1@chromium.org
, Apr 5 2017